[virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-14 Thread Michael S. Tsirkin
We state that drivers can access config fields before FEATURES_OK. We do however need them to write the features before accessing config otherwise our forward compatibility won't work. We require devices to allow access to config space if they offer a feature bit as long as that has been offered,

Re: [virtio-dev] spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-14 Thread Michael S. Tsirkin
On Fri, Jan 14, 2022 at 05:33:58PM +0100, Cornelia Huck wrote: > On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > > > It is unfortunate that it does not copy this requirement in more places, > > and that the non-conformance text is incomplete and does not > > mention the MSI-X usage at all. > >

Re: [virtio-dev] Some thoughts on zero-copy between VM domains for discussion

2022-01-14 Thread Jean-Philippe Brucker
On Fri, Jan 14, 2022 at 02:28:11PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > [[PGP Signed Part:Undecided]] > > On Thu, Jan 06, 2022 at 05:03:38PM +, Alex Bennée wrote: > >> > >> Hi, > >> > >> To start the new year I thought would dump some of my thoughts on > >> zero-copy

Re: [virtio-dev] spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-14 Thread Cornelia Huck
On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > It is unfortunate that it does not copy this requirement in more places, > and that the non-conformance text is incomplete and does not > mention the MSI-X usage at all. > > I propose to extend 4.1.4.5 ISR status capability and > 4.1.5.4 Notific

Re: [virtio-dev] Some thoughts on zero-copy between VM domains for discussion

2022-01-14 Thread Alex Bennée
Stefan Hajnoczi writes: > [[PGP Signed Part:Undecided]] > On Thu, Jan 06, 2022 at 05:03:38PM +, Alex Bennée wrote: >> >> Hi, >> >> To start the new year I thought would dump some of my thoughts on >> zero-copy between VM domains. For project Stratos we've gamely avoided >> thinking too ha

[virtio-dev] spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-14 Thread Michael S. Tsirkin
The spec says (v1.1 4.1.4.5 ISR status capability): The VIRTIO_PCI_CAP_ISR_CFG capability refers to at least a single byte, which contains the 8­bit ISR status field to be used for INT#x interrupt handling. and to avoid an extra access, simply reading this register resets it to 0 and causes th

[virtio-dev] [PATCH] Reserve more feature bits for device type usage

2022-01-14 Thread Cornelia Huck
Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23. To avoid problems in the future, let's designate bits 50 to 127 to device type sp

Re: [virtio-dev] Re: [PATCH V2 2/2] virtio-pci: add PASID configuration extended capability

2022-01-14 Thread Jean-Philippe Brucker
On Fri, Jan 14, 2022 at 11:15:35AM +0800, Jason Wang wrote: > > 在 2022/1/13 下午11:17, Michael S. Tsirkin 写道: > > On Thu, Jan 13, 2022 at 02:53:36PM +, Stefan Hajnoczi wrote: > > > On Thu, Jan 13, 2022 at 05:45:11AM -0500, Michael S. Tsirkin wrote: > > > > On Thu, Jan 13, 2022 at 10:32:11AM +000

Re: [virtio-dev] Re: [PATCH V2 2/2] virtio-pci: add PASID configuration extended capability

2022-01-14 Thread Jean-Philippe Brucker
Hi Jason, On Thu, Jan 13, 2022 at 09:24:16AM +0800, Jason Wang wrote: > The device MUST use PASID TLP prefix for all memory transactions > initiated by the virtqueue that belong to a virtqueue group ... > > > vring reads/writes and data buffer reads/writes come > > to mind. Virtqueue MSI-X messag