[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 07:30:34AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 12:42 PM > > > > On Tue, Jan 18, 2022 at 07:07:03AM +, Parav Pandit wrote: > > > 1. Use AQ for msix query and config > > > 2. AQ to follows IN_ORDER and INDIREC

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 07:21:02AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 12:44 PM > > > > On Tue, Jan 18, 2022 at 07:07:03AM +, Parav Pandit wrote: > > > Can you please review current proposal as well before we revise v2? > > > > I

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 02:16:35 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 18, 2022 at 11:34:25AM +0800, Xuan Zhuo wrote: > > On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > > > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 17 Jan 2022 15:06:52 +0800, J

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 07:14:56AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 12:38 PM > > > > Subfunctions with PASID can be similarly managed by extending device > > identification and its MSIX/IMS vector details. > > > May be vf_number sho

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 11:34:25AM +0800, Xuan Zhuo wrote: > On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang > > > wrote: > > > > > > > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道:

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 07:07:03AM +, Parav Pandit wrote: > Can you please review current proposal as well before we revise v2? I think what you listed amounts to a significant rework and will make things easier to review. Not 100% sure you need more feedback at this point. -- MST

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 07:07:03AM +, Parav Pandit wrote: > 1. Use AQ for msix query and config > 2. AQ to follows IN_ORDER and INDIRECT_DESC negotiation like rest of the > queues > 3. Update commit log to describe why config space is not chosen (scale, > on-die registers, uniform way to hand

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 03:36:19AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 3:33 AM > > > > On Mon, Jan 17, 2022 at 02:12:33PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Thursday, January 13, 2022 11:24

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 06:32:50AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 11:54 AM > > > > On Tue, Jan 18, 2022 at 04:44:36AM +, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, January 18, 2022

[virtio-dev] Re: spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 11:12:43AM +0800, Zhu, Lingshan wrote: > > > On 1/18/2022 11:01 AM, Jason Wang wrote: > > On Mon, Jan 17, 2022 at 3:57 PM Michael S. Tsirkin > wrote: > > On Mon, Jan 17, 2022 at 02:15:55PM +0800, Jason Wang wrote: > > 在 2022/1/14 下午9:39, Michae

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 04:44:36AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 3:44 AM > > > > > It's a control queue. Why do we worry? > > > It is used to control/manage the resource of a VF which is deployed > > > usually > > to a VM. > > >

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 03:22:27AM +, Parav Pandit wrote: > > I don't recall discussion about UUID so I can't really say what I think > > about that. > > Do we need a UUID? I'm not sure I understand why. > > It can't hurt to abstract things a bit so it's not all tied to PFs/VFs > > since we k

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 10:18:29AM +0800, Jason Wang wrote: > > 在 2022/1/18 上午6:22, Michael S. Tsirkin 写道: > > On Mon, Jan 17, 2022 at 02:07:51PM +, Parav Pandit wrote: > > > > From: Max Gurtovoy > > > > Sent: Sunday, January 16, 2022 3:18 PM > > > > > > > > > > > > On 1/13/2022 7:56 PM, Mi

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo wrote: > > > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > > > > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > > > wrote: >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Jason Wang
On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo wrote: > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > > wrote: > > >> On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > >

[virtio-dev] Re: spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-17 Thread Jason Wang
在 2022/1/18 上午11:12, Zhu, Lingshan 写道: On 1/18/2022 11:01 AM, Jason Wang wrote: On Mon, Jan 17, 2022 at 3:57 PM Michael S. Tsirkin wrote: On Mon, Jan 17, 2022 at 02:15:55PM +0800, Jason Wang wrote: 在 2022/1/14 下午9:39, Michael S. Tsirkin 写道: The spec says (v1.1 4.1.4.5 ISR status capabili

[virtio-dev] Re: spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-17 Thread Jason Wang
On Mon, Jan 17, 2022 at 3:57 PM Michael S. Tsirkin wrote: > > On Mon, Jan 17, 2022 at 02:15:55PM +0800, Jason Wang wrote: > > > > 在 2022/1/14 下午9:39, Michael S. Tsirkin 写道: > > > The spec says (v1.1 4.1.4.5 ISR status capability): > > > > > > The VIRTIO_PCI_CAP_ISR_CFG capability refers to at leas

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-17 Thread Jason Wang
在 2022/1/18 上午6:22, Michael S. Tsirkin 写道: On Mon, Jan 17, 2022 at 02:07:51PM +, Parav Pandit wrote: From: Max Gurtovoy Sent: Sunday, January 16, 2022 3:18 PM On 1/13/2022 7:56 PM, Michael S. Tsirkin wrote: On Thu, Jan 13, 2022 at 04:51:02PM +0200, Max Gurtovoy wrote: Set the relevant

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 09:13:41 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 04:21:50PM +0800, Xuan Zhuo wrote: > > On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin > > wrote: > > > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > > > On Sat, 15 Jan 2022 13:17:26 -

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 04:39:32PM +0100, Cornelia Huck wrote: > On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > > > We state that drivers can access config fields before FEATURES_OK. We do > > however need them to write the features before accessing config > > otherwise our forward compatibil

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 02:07:51PM +, Parav Pandit wrote: > > > From: Max Gurtovoy > > Sent: Sunday, January 16, 2022 3:18 PM > > > > > > On 1/13/2022 7:56 PM, Michael S. Tsirkin wrote: > > > On Thu, Jan 13, 2022 at 04:51:02PM +0200, Max Gurtovoy wrote: > > >> Set the relevant index in case

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 01:59:29PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, January 13, 2022 10:56 PM > > > > On Thu, Jan 13, 2022 at 07:07:53PM +0200, Max Gurtovoy wrote: > > > > > > On 1/13/2022 5:33 PM, Michael S. Tsirkin wrote: > > > > On Thu, Jan 13, 202

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 02:12:33PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, January 13, 2022 11:24 PM > > > > > We had an off-list meeting where I proposed addressing one device from > > another or grouping multiple devices as a more specific scope. That wou

[virtio-dev] Re: [PATCH v1 0/5] VIRTIO: Provision maximum MSI-X vectors for a VF

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 10:00:21AM +, Shahaf Shuler wrote: > Thursday, January 13, 2022 8:32 PM, Michael S. Tsirkin: > > Subject: Re: [PATCH v1 0/5] VIRTIO: Provision maximum MSI-X vectors for a > > VF > > > > On Thu, Jan 13, 2022 at 04:50:58PM +0200, Max Gurtovoy wrote: > > > Hi, > > > > > >

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 11:56:09AM +0200, Max Gurtovoy wrote: > > On 1/13/2022 7:53 PM, Michael S. Tsirkin wrote: > > On Thu, Jan 13, 2022 at 04:50:59PM +0200, Max Gurtovoy wrote: > > > In one of the many use cases a user wants to manipulate features and > > > configuration of the virtio devices r

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-17 Thread Cornelia Huck
On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > We state that drivers can access config fields before FEATURES_OK. We do > however need them to write the features before accessing config > otherwise our forward compatibility won't work. > > We require devices to allow access to config space if

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 04:21:50PM +0800, Xuan Zhuo wrote: > On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin > wrote: > > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > > wrote: > > > > On Tue, Jan 11, 2022 at 1

Re: [virtio-dev] Some thoughts on zero-copy between VM domains for discussion

2022-01-17 Thread Stefan Hajnoczi
On Fri, Jan 14, 2022 at 02:28:11PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > [[PGP Signed Part:Undecided]] > > On Thu, Jan 06, 2022 at 05:03:38PM +, Alex Bennée wrote: > >> > >> Hi, > >> > >> To start the new year I thought would dump some of my thoughts on > >> zero-copy

[virtio-dev] Re: [PATCH V2 1/2] virtio-pci: introduce virtio structure PCI Extended Capability

2022-01-17 Thread Stefan Hajnoczi
On Fri, Jan 14, 2022 at 11:23:00AM +0800, Jason Wang wrote: > > 在 2022/1/13 下午6:19, Stefan Hajnoczi 写道: > > On Thu, Jan 13, 2022 at 08:55:18AM +0800, Jason Wang wrote: > > > On Wed, Jan 12, 2022 at 6:10 PM Stefan Hajnoczi > > > wrote: > > > > On Wed, Jan 12, 2022 at 01:57:54PM +0800, Jason Wang

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > wrote: > > > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > > > This patch allows the driver t

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > wrote: > > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > > This patch allows the driver to obtain some statistics from the device. > > > > > > In the back-end imp