[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-18 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 05:17:06PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 8:39 PM > > > > On Tue, Jan 18, 2022 at 10:50:52AM +, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, January 18, 2022

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-18 Thread Jason Wang
在 2022/1/18 下午3:40, Michael S. Tsirkin 写道: On Tue, Jan 18, 2022 at 07:30:34AM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Tuesday, January 18, 2022 12:42 PM On Tue, Jan 18, 2022 at 07:07:03AM +, Parav Pandit wrote: 1. Use AQ for msix query and config 2. AQ to follows

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-18 Thread Jason Wang
On Tue, Jan 18, 2022 at 1:25 PM Michael S. Tsirkin wrote: > > On Tue, Jan 18, 2022 at 10:18:29AM +0800, Jason Wang wrote: > > > > 在 2022/1/18 上午6:22, Michael S. Tsirkin 写道: > > > On Mon, Jan 17, 2022 at 02:07:51PM +, Parav Pandit wrote: > > > > > From: Max Gurtovoy > > > > > Sent: Sunday,

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-18 Thread Jason Wang
在 2022/1/18 下午3:07, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Tuesday, January 18, 2022 12:25 PM On Tue, Jan 18, 2022 at 06:32:50AM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Tuesday, January 18, 2022 11:54 AM On Tue, Jan 18, 2022 at 04:44:36AM +, Parav Pandit

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-18 Thread Jason Wang
在 2022/1/18 上午5:30, Michael S. Tsirkin 写道: On Mon, Jan 17, 2022 at 11:56:09AM +0200, Max Gurtovoy wrote: On 1/13/2022 7:53 PM, Michael S. Tsirkin wrote: On Thu, Jan 13, 2022 at 04:50:59PM +0200, Max Gurtovoy wrote: In one of the many use cases a user wants to manipulate features and

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-18 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 10:50:52AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 4:09 PM > > > > On Tue, Jan 18, 2022 at 07:30:34AM +, Parav Pandit wrote: > > > An unrelated command to AQ in Jason's proposal [1] is about " The > >

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-18 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 10:30:38AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 3:57 PM > > > > On Tue, Jan 18, 2022 at 08:23:57AM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, January 18, 2022 1:36

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-18 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 07:30:34AM +, Parav Pandit wrote: > An unrelated command to AQ in Jason's proposal [1] is about " The management > driver MUST create a managed device by allocating". > We see that creator of the subfunction is often not the only entity managing > it. > They being

[virtio-dev] Re: [PATCH 5/5] Add support for dynamic MSI-X vector mgmt for VFs

2022-01-18 Thread Michael S. Tsirkin
On Thu, Jan 13, 2022 at 04:51:03PM +0200, Max Gurtovoy wrote: > A typical cloud provider SR-IOV use case is to create many VFs for > use by guest VMs. The VFs may not be assigned to a VM until a user > requests a VM of a certain size, e.g., number of CPUs. > A VF may need > MSI-X vectors

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-18 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 08:23:57AM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 1:36 PM > > [..] > > > > > > You can map it to a queue, yes. But something static and read > > > > > > only such as list of commands maps well to config space. And >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: > On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: >> On Tue, Jan 18 2022, Xuan Zhuo wrote: >> >> >> > > above you said bytes sent. >> >> > >> >> > I mean, all about GSO are statistics based on big packets. So here is >> >> > the >> >> > package

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Xuan Zhuo
On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: > On Tue, Jan 18 2022, Xuan Zhuo wrote: > > >> > > above you said bytes sent. > >> > > >> > I mean, all about GSO are statistics based on big packets. So here is the > >> > package from Guest, and rx is the package passed to Guest. > >> >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: >> > > above you said bytes sent. >> > >> > I mean, all about GSO are statistics based on big packets. So here is the >> > package from Guest, and rx is the package passed to Guest. >> >> it's a subtle distinction that we need to make. > > I will make this

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-18 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 07:57:36AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 18, 2022 11:47 AM > > > > On Tue, Jan 18, 2022 at 03:22:27AM +, Parav Pandit wrote: > > > > I don't recall discussion about UUID so I can't really say what I think > >