Re: [virtio-dev] Re: [PATCH V2 2/2] virtio-pci: add PASID configuration extended capability

2022-01-19 Thread Michael S. Tsirkin
On Fri, Jan 14, 2022 at 09:43:11AM +, Jean-Philippe Brucker wrote: > Hi Jason, > > On Thu, Jan 13, 2022 at 09:24:16AM +0800, Jason Wang wrote: > > The device MUST use PASID TLP prefix for all memory transactions > > initiated by the virtqueue that belong to a virtqueue group ... > > > > >

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 06:50:18PM +0100, Cornelia Huck wrote: > On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > > > On Wed, Jan 19, 2022 at 01:23:43PM +0100, Halil Pasic wrote: > >> On Mon, 17 Jan 2022 17:26:10 -0500 > >> "Michael S. Tsirkin" wrote: > >> > >> > On Mon, Jan 17, 2022 at

Re: [virtio-dev] Re: [PATCH V2 2/2] virtio-pci: add PASID configuration extended capability

2022-01-19 Thread Jean-Philippe Brucker
On Mon, Jan 17, 2022 at 01:57:47PM +0800, Jason Wang wrote: > How about something like: > > " > Except for the MSI transactions, the device MUST use PASID TLP prefix > for the following memory transactions initiated by the virtqueue that > belong to a virtqueue group if a valid PASID is assigned

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 01:23:43PM +0100, Halil Pasic wrote: >> On Mon, 17 Jan 2022 17:26:10 -0500 >> "Michael S. Tsirkin" wrote: >> >> > On Mon, Jan 17, 2022 at 04:39:32PM +0100, Cornelia Huck wrote: >> > > On Fri, Jan 14 2022, "Michael S.

Re: [virtio-dev] Some thoughts on zero-copy between VM domains for discussion

2022-01-19 Thread Dr. David Alan Gilbert
* Alex Bennée (alex.ben...@linaro.org) wrote: > > Hi, > > To start the new year I thought would dump some of my thoughts on > zero-copy between VM domains. For project Stratos we've gamely avoided > thinking too hard about this while we've been concentrating on solving > more tractable problems.

Re: [virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 10:10:38AM +, Parav Pandit wrote: > Virtio spec should define a minimum expectations from the system such > as flushing the cache or no cache well one of the things virtio is trying to do is being compatible with a wide range of hypervisors/OSes. it might be tricky to

[virtio-dev] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: > On Fri, 14 Jan 2022 17:50:51 -0500 > "Michael S. Tsirkin" wrote: > > Subject: virtio: clarify feature negotiation > > This is in my opinion more of an incompatible change that a > clarification, but since the commit message does not

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 01:23:43PM +0100, Halil Pasic wrote: > On Mon, 17 Jan 2022 17:26:10 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Jan 17, 2022 at 04:39:32PM +0100, Cornelia Huck wrote: > > > On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > > > > > > > We state that drivers can

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 04:47:10PM +0200, Max Gurtovoy wrote: > I agree, I don't see why it's not possible to use a different command opcode > for vf interrupt configuration and sf interrupt configuration. > > We're not short in opcodes and it's very elegant and extendable IMO. > > I think the

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Halil Pasic
On Mon, 17 Jan 2022 17:26:10 -0500 "Michael S. Tsirkin" wrote: > On Mon, Jan 17, 2022 at 04:39:32PM +0100, Cornelia Huck wrote: > > On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > > > > > We state that drivers can access config fields before FEATURES_OK. We do > > > however need them to

[virtio-dev] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Halil Pasic
On Fri, 14 Jan 2022 17:50:51 -0500 "Michael S. Tsirkin" wrote: > Subject: virtio: clarify feature negotiation This is in my opinion more of an incompatible change that a clarification, but since the commit message does not constitute a part of the standard, it does not matter that much. [..] >

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 12:21:36PM +0800, Jason Wang wrote: > > 在 2022/1/18 下午3:40, Michael S. Tsirkin 写道: > > On Tue, Jan 18, 2022 at 07:30:34AM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, January 18, 2022 12:42 PM > > > > > > > > On Tue, Jan 18,

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 12:16:47PM +0800, Jason Wang wrote: > > We also need > > - something like injecting cvq commands to control rx mode from the admin > > device > > - page fault / dirty page handling > > > > these two seem to call for a vq. > > Right, but vq is not necessarily for PF if we

Re: [virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 08:15:50AM +, Parav Pandit wrote: > > > Virtio driver should not incur any additional complexity in re-reading > > > vector > > etc. > > > > I think it does this already. > When does it re-read? > I do not follow your point of "ask driver to read back any vector".

[virtio-dev] Re: [PATCH 1/5] Add virtio Admin Virtqueue specification

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 11:04:50AM +0800, Jason Wang wrote: > Exactly, another call for the using the PRS queue instead. But generally > speaking, admin virtqueue limit or complicate the functions that can be > exported to guest. That's why I suggest to decouple all the possible > features out of