Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Thu, Apr 28, 2022 at 11:43:16AM +0800, Jason Wang wrote: > > 在 2022/4/28 11:24, Parav Pandit 写道: > > > > > From: Jason Wang > > > Sent: Wednesday, April 27, 2022 11:15 PM > > > > > > On Wed, Apr 27, 2022 at 11:39 PM Parav Pandit wrote: > > > > > > > > > From: Michael S. Tsirkin > > > > >

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 7:46 PM Xuan Zhuo wrote: > > On Wed, 27 Apr 2022 19:29:37 +0800, Jason Wang wrote: > > On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > > > > > Currently when driver initiates a queue reset, device is expected > > > to communicate reset status to the driver by

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
在 2022/4/28 11:24, Parav Pandit 写道: From: Jason Wang Sent: Wednesday, April 27, 2022 11:15 PM On Wed, Apr 27, 2022 at 11:39 PM Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, April 27, 2022 11:30 AM On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: From:

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
在 2022/4/28 00:15, Parav Pandit 写道: From: Parav Pandit Sent: Wednesday, April 27, 2022 11:58 AM But this is so basic. It's hard to gaze at this spec for coming years and the code to see, Hey sometimes 0 means disabled, sometime 0 means still enabled, sometime 1 means enabled, and sometimes 1

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 11:39 PM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 27, 2022 11:30 AM > > > > On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: > > > > > > > From: Jason Wang > > > > Sent: Wednesday, April 27, 2022 7:30 AM > > > > > > > >

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:25:59PM +0300, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later

Re: RE: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 04:28:43PM +0800, Xuan Zhuo wrote: > On Tue, 26 Apr 2022 12:00:24 +, Parav Pandit wrote: > > > > > From: Xuan Zhuo > > > Sent: Sunday, April 24, 2022 3:29 AM > > > > > > > > A recently defined queue_reset register has a little weird definition > > > > that > > > we

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 04:15:05PM +, Parav Pandit wrote: > > > From: Parav Pandit > > Sent: Wednesday, April 27, 2022 11:58 AM > > > > But this is so basic. > > It's hard to gaze at this spec for coming years and the code to see, Hey > > sometimes 0 means disabled, sometime 0 means still

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 03:57:35PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 27, 2022 11:44 AM > > > > On Wed, Apr 27, 2022 at 03:39:40PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, April 27, 2022 11:30

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 03:39:40PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 27, 2022 11:30 AM > > > > On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: > > > > > > > From: Jason Wang > > > > Sent: Wednesday, April 27, 2022 7:30 AM > > > >

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: > > > From: Jason Wang > > Sent: Wednesday, April 27, 2022 7:30 AM > > > > On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > > > > > example flow: > > > a) 0,0 -> device init time value > > > b) 1,0 -> vq is enabled by driver

[virtio-dev] Re: [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Cornelia Huck
On Wed, Apr 27 2022, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to return 1 when

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Xuan Zhuo
On Wed, 27 Apr 2022 19:29:37 +0800, Jason Wang wrote: > On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > > > Currently when driver initiates a queue reset, device is expected > > to communicate reset status to the driver by changing the value of the > > queue_reset register twice. First

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to

[virtio-dev] Re: [PATCH v1] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 03:06:57 +0300, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 10:26:18 -0400, "Michael S. Tsirkin" wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little weird definition > > > that we

Re: RE: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 12:00:24 +, Parav Pandit wrote: > > > From: Xuan Zhuo > > Sent: Sunday, April 24, 2022 3:29 AM > > > > > > A recently defined queue_reset register has a little weird definition that > > we should improve. > > > When driver initiate queue reset, it writes queue_reset = 1.