[virtio-dev] Re: [PATCH v5 0/7] Introduce device group and device management

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:17AM +0300, Max Gurtovoy wrote: > Hi, > A device group definition will help extending the virtio specefication for > various future features that require a notion of grouping devices together or > managing devices inside a group. A device group include one or more

[virtio-dev] Re: [PATCH v5 1/7] Introduce device group

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:18AM +0300, Max Gurtovoy wrote: > Each device group has a type. For now, define initial type of device > groups: Type 1 - A virtio PCI SR-IOV physical function (PF) and its PCI > SR-IOV virtual functions (VFs). This group may contain one or more > virtio devices. > >

[virtio-dev] Re: [PATCH v5 2/7] Introduce admin command set

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:19AM +0300, Max Gurtovoy wrote: > This command set is used for essential administrative and management > operations. > > Admin commands should be submitted to a well defined management > interface. > > Reviewed-by: Parav Pandit > Signed-off-by: Max Gurtovoy > ---

[virtio-dev] Re: [PATCH v5 3/7] Introduce new destination type for admin commands

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:20AM +0300, Max Gurtovoy wrote: > Introduce a new mechanism to issue commands with dst_type field that is > not "self". With the new mechanism, driver can set dst_type to 1 > and use the vdev_id common field to describe the designated vdev_id. > > This mechanism is

[virtio-dev] Re: [PATCH v5 3/7] Introduce new destination type for admin commands

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:20AM +0300, Max Gurtovoy wrote: > Introduce a new mechanism to issue commands with dst_type field that is > not "self". With the new mechanism, driver can set dst_type to 1 > and use the vdev_id common field to describe the designated vdev_id. > > This mechanism is

[virtio-dev] Re: [PATCH v5 4/7] Introduce virtio admin virtqueue

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:21AM +0300, Max Gurtovoy wrote: > In one of the many use cases a user wants to manipulate features and > configuration of the virtio devices regardless of the device type > (net/block/console). For that the admin command set introduced. The > admin virtqueue will be

[virtio-dev] Re: [PATCH v5 5/7] Add miscellaneous configuration structure for PCI

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:22AM +0300, Max Gurtovoy wrote: > This new structure will be used for adding new miscellaneous registers > for a virtio device configuration layout. > > For now, only admin_queue_index register is added. Admin virtqueue index > does not depend on the device type.

[virtio-dev] Re: [PATCH v5 5/7] Add miscellaneous configuration structure for PCI

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:22AM +0300, Max Gurtovoy wrote: > This new structure will be used for adding new miscellaneous registers > for a virtio device configuration layout. > > For now, only admin_queue_index register is added. Admin virtqueue index > does not depend on the device type.

[virtio-dev] Re: [PATCH v5 7/7] RFC: add initial support for configuring feature bits

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:24AM +0300, Max Gurtovoy wrote: > After adding the concept of a management and a managed device, add > another example of using this concept to manage resources. > > Today there is no standard definition in the spec that allows user to > setup specific feature bits

[virtio-dev] Re: [PATCH v5 6/7] Introduce MGMT admin commands

2022-05-15 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:58:23AM +0300, Max Gurtovoy wrote: > Introduce the concept of a management and a managed device and add > example of using this concept to manage resources. > > A management device supports the VIRTIO_ADMIN_DEVICE_MGMT and > VIRTIO_ADMIN_DEVICE_MGMT_ATTRS admin commands