Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Jason Wang
在 2022/8/10 06:54, Si-Wei Liu 写道: On 8/9/2022 3:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote: On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday,

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Jason Wang
在 2022/8/10 02:38, Si-Wei Liu 写道: On 8/9/2022 12:44 AM, Jason Wang wrote: On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: On 8/9/2022 7:56 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/8/2022 12:31 AM, Gavin Li wrote: On 8/6/2022 6:11 AM, Si-Wei

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 3:49 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Tuesday, August 9, 2022 6:26 PM To: Parav Pandit Cc: Si-Wei Liu ; Jason Wang ; Gavin Li ; Hemminger, Stephen ; davem ; virtualization ; Virtio-Dev ; jesse.brandeb...@intel.com; alexander.h.du...@intel.com;

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 10:49:48PM +, Parav Pandit wrote: > > > When user prefers to override the device RO field, device is in the dark > > > and > > things work on best effort basis. > > > > Dropping packets is best effort. Getting stuck forever isn't, that's a > > quality of > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 03:54:57PM -0700, Si-Wei Liu wrote: > > > On 8/9/2022 3:37 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote: > > > > > > On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote: > > > > On Tue, Aug 09, 2022 at 07:18:30PM +, Parav

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 10:49:48PM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Tuesday, August 9, 2022 6:26 PM > > To: Parav Pandit > > Cc: Si-Wei Liu ; Jason Wang > > ; Gavin Li ; Hemminger, > > Stephen ; davem > > ; virtualization > foundation.org>; Virtio-Dev ; > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 3:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote: On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 3:09 PM From: Si-Wei Liu

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote: > > > On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote: > > > > From: Si-Wei Liu > > > > Sent: Tuesday, August 9, 2022 3:09 PM > > > > > > From: Si-Wei Liu > > > > > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 3:09 PM From: Si-Wei Liu Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a single patch nor this patch, but the

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 02:39:49PM -0700, Si-Wei Liu wrote: > > > On 8/9/2022 2:34 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 09, 2022 at 11:38:52AM -0700, Si-Wei Liu wrote: > > > > > > On 8/9/2022 12:44 AM, Jason Wang wrote: > > > > On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: > > > > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 09:49:03PM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Tuesday, August 9, 2022 5:38 PM > > [..] > > > > I think virtio-net driver doesn't differentiate MTU and MRU, in > > > > which case the receive buffer will be reduced to fit the 1500B > > > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 2:34 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 11:38:52AM -0700, Si-Wei Liu wrote: On 8/9/2022 12:44 AM, Jason Wang wrote: On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: On 8/9/2022 7:56 AM, Si-Wei Liu wrote: External email: Use caution opening links or

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote: > > From: Si-Wei Liu > > Sent: Tuesday, August 9, 2022 3:09 PM > > > >> From: Si-Wei Liu > > >> Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a > > >> single patch nor this patch, but the context for the eventual

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 11:38:52AM -0700, Si-Wei Liu wrote: > > > On 8/9/2022 12:44 AM, Jason Wang wrote: > > On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: > > > > > > On 8/9/2022 7:56 AM, Si-Wei Liu wrote: > > > > > > External email: Use caution opening links or attachments > > > > > > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 09:13:42PM +, Parav Pandit wrote: > > From: Si-Wei Liu > > Sent: Tuesday, August 9, 2022 4:33 PM > > > > On 8/9/2022 12:18 PM, Parav Pandit wrote: > > >> From: Si-Wei Liu > > >> Sent: Tuesday, August 9, 2022 3:09 PM > > From: Si-Wei Liu > > Sent: Tuesday,

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 12:18 PM, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 3:09 PM From: Si-Wei Liu Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a single patch nor this patch, but the context for the eventual goal is to allow XDP on a MTU=9000 link when

[virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-09 Thread Michael S. Tsirkin
On Wed, Mar 30, 2022 at 04:21:02PM +0100, Usama Arif wrote: > Driver auxiliary notifications allow the device to send notifications > other than configuration changes and used buffer notifications to the > driver, these are optional and their meaning is device-specific. > > Device auxiliary

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 11:42 AM, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a single patch nor this patch, but the context for the eventual goal is to allow XDP on a MTU=9000 link when guest users intentionally lower down MTU to 1500. Which

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 12:44 AM, Jason Wang wrote: On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: On 8/9/2022 7:56 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/8/2022 12:31 AM, Gavin Li wrote: On 8/6/2022 6:11 AM, Si-Wei Liu wrote: External email: Use

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 12:06 AM, Gavin Li wrote: On 8/9/2022 7:56 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/8/2022 12:31 AM, Gavin Li wrote: On 8/6/2022 6:11 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/1/2022 9:45

Re: [virtio-dev] Re: [PATCH] virtio_net: support split header

2022-08-09 Thread Cornelia Huck
On Fri, Aug 05 2022, Heng Qi wrote: > 在 2022/8/4 下午9:50, Cornelia Huck 写道: >> On Thu, Aug 04 2022, Heng Qi wrote: >> >>> 在 2022/8/4 下午2:27, Jason Wang 写道: On Mon, Aug 1, 2022 at 2:59 PM Heng Qi wrote: > @@ -3820,9 +3826,13 @@ \subsubsection{Processing of Incoming >

[virtio-dev] Re: [RFC v2] virtio-net: Add RoCE (RDMA over Converged Ethernet) support

2022-08-09 Thread Yongji Xie
On Thu, Aug 4, 2022 at 4:30 PM Jason Wang wrote: > > On Wed, May 11, 2022 at 5:59 PM Xie Yongji wrote: > > > > Hi all, > > > > Not very familiar with ROCE, try to give some comments from general > virtio level. > Thank you! > > This RFC aims to introduce our recent work on enabling RoCE

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Jason Wang
On Tue, Aug 9, 2022 at 5:25 PM Michael S. Tsirkin wrote: > > On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote: > > > + unsigned int mtu = vi->dev->mtu; > > BTW should this not be max_mtu? Yes. > Otherwise if user configures mtu that > is too small we'll add buffers that

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Jason Wang
On Tue, Aug 9, 2022 at 5:22 PM Michael S. Tsirkin wrote: > > On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote: > > > @@ -3571,8 +3581,10 @@ static int virtnet_probe(struct virtio_device > > > *vdev) > > > if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) || > > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote: > > + unsigned int mtu = vi->dev->mtu; BTW should this not be max_mtu? Otherwise if user configures mtu that is too small we'll add buffers that are too small. some backends simply lock up if this happens (I think vhost

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote: > > @@ -3571,8 +3581,10 @@ static int virtnet_probe(struct virtio_device > > *vdev) > > if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) || > > virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) || > >

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Jason Wang
On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: > > > On 8/9/2022 7:56 AM, Si-Wei Liu wrote: > > External email: Use caution opening links or attachments > > > On 8/8/2022 12:31 AM, Gavin Li wrote: > > > On 8/6/2022 6:11 AM, Si-Wei Liu wrote: > > External email: Use caution opening links or