Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-22 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 12:04:28PM +0800, Jason Wang wrote: > On Fri, Sep 23, 2022 at 11:33 AM Xuan Zhuo wrote: > > > > On Wed, 21 Sep 2022 14:20:19 +0800, Jason Wang wrote: > > > On Tue, Sep 20, 2022 at 11:28 AM Heng Qi wrote: > > > > > > > > On Tue, Sep 20, 2022 at 09:59:22AM +0800, Jason

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-22 Thread Jason Wang
On Fri, Sep 23, 2022 at 11:33 AM Xuan Zhuo wrote: > > On Wed, 21 Sep 2022 14:20:19 +0800, Jason Wang wrote: > > On Tue, Sep 20, 2022 at 11:28 AM Heng Qi wrote: > > > > > > On Tue, Sep 20, 2022 at 09:59:22AM +0800, Jason Wang wrote: > > > > > > > > 在 2022/9/16 10:56, hengqi 写道: > > > > >From:

[virtio-dev] RE: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-22 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 22, 2022 6:15 AM > > It's nitpicking to be frank. v6 arrived while I was traveling and I didn't > notice it. > I see Jason acked that so I guess I will just apply as is. Do you ack v6 too? > Yes. I reviewed it. Gavin added reviewed-by.

[virtio-dev] Re: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 10:04:53AM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, September 22, 2022 5:35 AM > > > > On Thu, Sep 01, 2022 at 05:10:38AM +0300, Gavin Li wrote: > > > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big > > > packets

[virtio-dev] RE: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-22 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 22, 2022 5:27 AM > > > > > > And I'd like commit log to include results of perf testing > > > - with indirect feature on > > Which device do you suggest using for this test? > > AFAIK most devices support INDIRECT, e.g. don't nvidia cards

[virtio-dev] RE: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-22 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 22, 2022 5:35 AM > > On Thu, Sep 01, 2022 at 05:10:38AM +0300, Gavin Li wrote: > > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big > > packets even when GUEST_* offloads are not present on the device. > > However, if

[virtio-dev] Re: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 01, 2022 at 05:10:38AM +0300, Gavin Li wrote: > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big > packets even when GUEST_* offloads are not present on the device. > However, if guest GSO is not supported, it would be sufficient to > allocate segments to cover just

[virtio-dev] Re: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-22 Thread Michael S. Tsirkin
On Wed, Sep 07, 2022 at 07:51:38PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, September 7, 2022 3:36 PM > > > > On Wed, Sep 07, 2022 at 07:27:16PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, September 7, 2022