[virtio-dev] Re: [PATCH v8 1/9] virtio: document forward compatibility guarantees

2022-11-22 Thread Michael S. Tsirkin
On Mon, Nov 21, 2022 at 04:24:26PM +0100, Cornelia Huck wrote: > On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > > > Feature negotiation forms the basis of forward compatibility > > guarantees of virtio but has never been properly documented. > > Do it now. > > > > Suggested-by: Halil Pasic

[virtio-dev] Re: [PATCH v8 2/9] admin: introduce device group and related concepts

2022-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2022 at 01:11:19PM +0100, Cornelia Huck wrote: > On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > > > Each device group has a type. For now, define one initial group: > > > > SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given > > PCI SR-IOV physical function (PF). This

[virtio-dev] Re: [PATCH v8 4/9] admin: introduce virtio admin virtqueues

2022-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2022 at 02:14:23PM +0100, Cornelia Huck wrote: > On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > > > The admin virtqueues will be the first interface to issue admin commands. > > > > Currently virtio specification defines control virtqueue to manipulate > > features and

[virtio-dev] Re: [PATCH v8 5/9] pci: add admin vq registers to virtio over pci

2022-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2022 at 03:46:38PM +0100, Cornelia Huck wrote: > On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > > > Add new registers to the PCI common configuration structure. > > > > These registers will be used for querying the indices of the admin > > virtqueues of the owner device. To

[virtio-dev] Re: [PATCH v8 9/9] admin: conformance clauses

2022-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2022 at 05:06:04PM +0100, Cornelia Huck wrote: > On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > > > Add conformance clauses for admin commands and admin virtqueues. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > admin.tex | 122

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2022 at 04:25:23PM +0100, Cornelia Huck wrote: > On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > > > Add commands to find out which commands does each group support, > > as well as enable their use by driver. > > This will be especially useful once we have multiple group

[virtio-dev] Re: [PATCH v8 9/9] admin: conformance clauses

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Add conformance clauses for admin commands and admin virtqueues. > > Signed-off-by: Michael S. Tsirkin > --- > admin.tex | 122 ++ > 1 file changed, 122 insertions(+) > > diff --git

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Add commands to find out which commands does each group support, > as well as enable their use by driver. > This will be especially useful once we have multiple group types. > > Signed-off-by: Max Gurtovoy > Signed-off-by: Michael S. Tsirkin >

[virtio-dev] Re: [PATCH v8 5/9] pci: add admin vq registers to virtio over pci

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Add new registers to the PCI common configuration structure. > > These registers will be used for querying the indices of the admin > virtqueues of the owner device. To configure, reset or enable the admin > virtqueues, the driver should follow

[virtio-dev] Re: [PATCH v8 4/9] admin: introduce virtio admin virtqueues

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > The admin virtqueues will be the first interface to issue admin commands. > > Currently virtio specification defines control virtqueue to manipulate > features and configuration of the device it operates on. However, > control virtqueue commands

[virtio-dev] Re: [PATCH v8 3/9] admin: introduce group administration commands

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > This introduces a general structure for group administration commands, > used to control device groups through their owner. > > Following patches will introduce specific commands and an interface for > submitting these commands to the owner. > >

[virtio-dev] Re: [PATCH v8 2/9] admin: introduce device group and related concepts

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Each device group has a type. For now, define one initial group: > > SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given > PCI SR-IOV physical function (PF). This group may contain one or more > virtio devices. > > Each device within a

[virtio-dev] Re: [PATCH v8 7/9] ccw: document ADMIN_VQ as reserved

2022-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2022 at 09:50:35AM +0100, Cornelia Huck wrote: > On Mon, Nov 21 2022, "Michael S. Tsirkin" wrote: > > > OK I think for now the following is sufficient, right? > > Separately, we should make an effort to document that these > > features are transport specific and not supported on

[virtio-dev] Re: [PATCH v8 7/9] ccw: document ADMIN_VQ as reserved

2022-11-22 Thread Cornelia Huck
On Mon, Nov 21 2022, "Michael S. Tsirkin" wrote: > OK I think for now the following is sufficient, right? > Separately, we should make an effort to document that these > features are transport specific and not supported on all transports: > happily VIRTIO_F_RING_RESET is only used in