[virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Heng Qi
在 2023/1/9 下午7:39, Michael S. Tsirkin 写道: Btw this "are defined below" all over the place is just contributing to making the spec unnecesarily verbose. Simple "are:" will do. Sure. I'll fix it in the next version. Thanks.

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Heng Qi
On Tue, Jan 10, 2023 at 12:57:38AM -0500, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirkin wrote: > > > This will give extra pressure on the management stack, e.g it requires > > > the device to have an out of spec way for introspection. > > > > > > Thanks

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirkin wrote: > > This will give extra pressure on the management stack, e.g it requires > > the device to have an out of spec way for introspection. > > > > Thanks > > As I tried to explain this is already the case. Feature bits do not >

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Tue, Jan 10, 2023 at 10:06:53AM +0800, Jason Wang wrote: > On Mon, Jan 9, 2023 at 7:34 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 09, 2023 at 04:59:26PM +0800, Jason Wang wrote: > > > On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > > > > > > > On Fri, Jan 06, 2023 at 01:59:38AM

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Jason Wang
On Mon, Jan 9, 2023 at 7:34 PM Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2023 at 04:59:26PM +0800, Jason Wang wrote: > > On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > > > > > On Fri, Jan 06, 2023 at 01:59:38AM -0500, Michael S. Tsirkin wrote: > > > > On Fri, Jan 06, 2023 at 02:42:21PM

[virtio-dev] RE: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, January 9, 2023 2:15 PM > > > > So my preference is \\input for now. > > \\input doesn't support reading from the directory. > > I just tested this and it seems to work fine: > > \input{sub/file.tex} > > what is the issue that you see? I was

[virtio-dev] Re: [PATCH v8] virtio-network: Clarify VLAN filter table configuration

2023-01-09 Thread Si-Wei Liu
On 1/9/2023 8:33 AM, Parav Pandit wrote: The filtering behavior of the VLAN filter commands is not very clear as discussed in thread [1]. Hence, add the command description and device requirements for it. [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg912392.html Fixes:

[virtio-dev] Re: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 02:12:36PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, January 9, 2023 8:43 AM > > > > I found another issue with this. Currently for redline diff generation > > we use latexpand. Using a flat expanded file has lots of benefits, in > >

[virtio-dev] Re: [PATCH v2 00/20] Split device spec to its individual files

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 06:28:29PM +0200, Parav Pandit wrote: > Relatively several of the recent device specifications are maintained > in their own specification file. Such separate files enables better > maintenance of the specification overall. > However, several of the initial virtio device

[virtio-dev] Re: [PATCH v8] virtio-network: Clarify VLAN filter table configuration

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 06:33:01PM +0200, Parav Pandit wrote: > The filtering behavior of the VLAN filter commands is not very clear as > discussed in thread [1]. > > Hence, add the command description and device requirements for it. > > [1]

[virtio-dev] Re: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 02:12:36PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, January 9, 2023 8:43 AM > > > > I found another issue with this. Currently for redline diff generation > > we use latexpand. Using a flat expanded file has lots of benefits, in > >

[virtio-dev] [PATCH v8] virtio-network: Clarify VLAN filter table configuration

2023-01-09 Thread Parav Pandit
The filtering behavior of the VLAN filter commands is not very clear as discussed in thread [1]. Hence, add the command description and device requirements for it. [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg912392.html Fixes: https://github.com/oasis-tcs/virtio-spec/issues/147

[virtio-dev] [PATCH v2 15/20] virtio-sound: Maintain sound device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - added missing device conformance reference v0->v1: -

[virtio-dev] [PATCH v2 20/20] virtio-pmem: Maintain pmem device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - rebased v0->v1: - new patch --- conformance.tex

[virtio-dev] [PATCH v2 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - added missing device conformance reference entry

[virtio-dev] [PATCH v2 03/20] virtio-block: Maintain block device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio block device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153

[virtio-dev] [PATCH v2 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - added missing device conformance reference v0->v1: -

[virtio-dev] [PATCH v2 18/20] virtio-scmi: Maintain scmi device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - rebased v0->v1: - new patch --- conformance.tex

[virtio-dev] [PATCH v2 17/20] virtio-i2c: Maintain i2c device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - added missing device conformance reference v0->v1: -

[virtio-dev] [PATCH v2 14/20] virtio-iommu: Maintain iommu device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - rebased v0->v1: - new patch --- conformance.tex

[virtio-dev] [PATCH v2 16/20] virtio-mem: Maintain memory device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v1->v2: - rebased v0->v1: - new patch --- conformance.tex

[virtio-dev] [PATCH v2 11/20] virtio-vsock: Maintain socket device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v0->v1: - new patch --- conformance.tex

[virtio-dev] [PATCH v2 10/20] virtio-crypto: Maintain crypto device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio crypto device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153

[virtio-dev] [PATCH v2 07/20] virtio-scsi: Maintain scsi host device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio SCSI host device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153

[virtio-dev] [PATCH v2 12/20] virtio-fs: Maintain file system device spec in separate directory

2023-01-09 Thread Parav Pandit
Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog: v0->v1: - new patch --- conformance.tex

[virtio-dev] [PATCH v2 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio memory balloon device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes:

[virtio-dev] [PATCH v2 09/20] virtio-input: Maintain input device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio input device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153

[virtio-dev] [PATCH v2 05/20] virtio-entropy: Maintain entropy device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio entropy device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153

[virtio-dev] [PATCH v2 08/20] virtio-gpu: Maintain gpu device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio gpu device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153

[virtio-dev] [PATCH v2 04/20] virtio-console: Maintain console device spec in separate directory

2023-01-09 Thread Parav Pandit
Move virtio console device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153

[virtio-dev] [PATCH v2 00/20] Split device spec to its individual files

2023-01-09 Thread Parav Pandit
Relatively several of the recent device specifications are maintained in their own specification file. Such separate files enables better maintenance of the specification overall. However, several of the initial virtio device specifications are located in single file. Hence, split them into their

[virtio-dev] [PATCH v2 02/20] virtio-network: Fix spelling errors

2023-01-09 Thread Parav Pandit
Fix two spelling errors in the virtio network device specification. Signed-off-by: Parav Pandit --- device-types/virtio-network/device.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/device-types/virtio-network/device.tex b/device-types/virtio-network/device.tex

[virtio-dev] RE: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Parav Pandit
> From: Cornelia Huck > Sent: Monday, January 9, 2023 8:47 AM > > On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > > > On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: > >> On Sun, Jan 01 2023, Parav Pandit wrote: > >> > >> > Place device specification, its driver and device

[virtio-dev] RE: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, January 9, 2023 8:43 AM > > I found another issue with this. Currently for redline diff generation > we use latexpand. Using a flat expanded file has lots of benefits, in > particular latexdiff is sometimes fragile as it is, with a flat file > one can

[virtio-dev] RE: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, January 9, 2023 8:36 AM > > On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: > > On Sun, Jan 01 2023, Parav Pandit wrote: > > > > > Place device specification, its driver and device conformance into > > > its own directory to have self

Re: [virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Mon, Jan 09 2023, Cornelia Huck wrote: > On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > >> On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: >>> On Sun, Jan 01 2023, Parav Pandit wrote: >>> >>> > Place device specification, its driver and device >>> > conformance into its

[virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: >> On Sun, Jan 01 2023, Parav Pandit wrote: >> >> > Place device specification, its driver and device >> > conformance into its own directory to have self contained device >> >

[virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: > On Sun, Jan 01 2023, Parav Pandit wrote: > > > Place device specification, its driver and device > > conformance into its own directory to have self contained device > > specification. > > > > Fixes:

[virtio-dev] Re: [virtio-comment] [PATCH v1 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 17/20] virtio-i2c: Maintain i2c device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 15/20] virtio-sound: Maintain sound device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote: > +are defined below: > + > +\begin{lstlisting} > +#define VIRTIO_NET_HASH_REPORT_TUNNEL_NONE 0 > +#define VIRTIO_NET_HASH_REPORT_GRE 1 > +#define VIRTIO_NET_HASH_REPORT_VXLAN 2 > +#define

[virtio-dev] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote: > If the tunnel is used to encapsulate the packets, the hash calculated > using the outer header of the receive packets is always fixed for the > same flow packets, i.e. they will be steered to the same receive queue. > > We add a feature

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 04:59:26PM +0800, Jason Wang wrote: > On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > > > On Fri, Jan 06, 2023 at 01:59:38AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Jan 06, 2023 at 02:42:21PM +0800, Heng Qi wrote: > > > > On Fri, Jan 06, 2023 at 12:27:04AM -0500,

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Jason Wang
On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > On Fri, Jan 06, 2023 at 01:59:38AM -0500, Michael S. Tsirkin wrote: > > On Fri, Jan 06, 2023 at 02:42:21PM +0800, Heng Qi wrote: > > > On Fri, Jan 06, 2023 at 12:27:04AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Jan 04, 2023 at 03:14:01PM