[virtio-dev] RE: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files

2023-01-13 Thread Parav Pandit
Hi Michael, > From: Michael S. Tsirkin > Sent: Friday, January 13, 2023 6:42 AM > > > > This LGTM now. > > > > Michael: did you check whether redlining works as expected? > > I have successfully generated a diff from 1.1 and did some manual spot > checking. Looks ok to me. I really expect

[virtio-dev] Re: [PATCH v4 00/20] Split device spec to its individual files

2023-01-13 Thread David Hildenbrand
On 12.01.23 22:22, Parav Pandit wrote: Relatively several of the recent device specifications are maintained in their own specification file. Such separate files enables better maintenance of the specification overall. However, several of the initial virtio device specifications are located in

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-13 Thread Michael S. Tsirkin
On Fri, Jan 13, 2023 at 02:24:14PM +0800, Xuan Zhuo wrote: > On Fri, 13 Jan 2023 10:29:49 +0800, Jason Wang wrote: > > On Fri, Jan 13, 2023 at 9:59 AM Xuan Zhuo > > wrote: > > > > > > On Thu, 12 Jan 2023 16:41:32 +0100, Halil Pasic > > > wrote: > > > > On Thu, 12 Jan 2023 15:30:58 +0100 > > >

[virtio-dev] Re: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files

2023-01-13 Thread Michael S. Tsirkin
On Thu, Jan 12, 2023 at 11:22:34PM +0200, Parav Pandit wrote: > Relatively several of the recent device specifications are maintained > in their own specification file. Such separate files enables better > maintenance of the specification overall. > However, several of the initial virtio device

[virtio-dev] Re: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files

2023-01-13 Thread Michael S. Tsirkin
On Fri, Jan 13, 2023 at 11:19:52AM +0100, Cornelia Huck wrote: > On Thu, Jan 12 2023, Parav Pandit wrote: > > > Relatively several of the recent device specifications are maintained > > in their own specification file. Such separate files enables better > > maintenance of the specification

[virtio-dev] Re: [PATCH v4 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-13 Thread David Hildenbrand
On 12.01.23 22:22, Parav Pandit wrote: Move virtio memory balloon device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes:

[virtio-dev] Re: [virtio-comment] [PATCH v4 11/20] virtio-vsock: Maintain socket device spec in separate directory

2023-01-13 Thread Stefano Garzarella
On Thu, Jan 12, 2023 at 11:22:45PM +0200, Parav Pandit wrote: Place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 Signed-off-by: Parav Pandit --- changelog:

[virtio-dev] Re: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files

2023-01-13 Thread Cornelia Huck
On Thu, Jan 12 2023, Parav Pandit wrote: > Relatively several of the recent device specifications are maintained > in their own specification file. Such separate files enables better > maintenance of the specification overall. > However, several of the initial virtio device specifications > are