On Tue, Jan 17, 2023 at 03:03:43PM +0200, Alvaro Karsz wrote:
> > By comparison this patch is an attempt to offload ethtool's
> > --coalesce parameters to the card. IMO what it misses is
> > completeness, e.g. sample-interval is not specified.
>
> AFAIK sample-interval refers to the adaptive
> By comparison this patch is an attempt to offload ethtool's
> --coalesce parameters to the card. IMO what it misses is
> completeness, e.g. sample-interval is not specified.
AFAIK sample-interval refers to the adaptive coalescing
(adaptive-rx/adaptive-tx) and not to high/low.
Hi,
> > This patch adds a new feature, VIRTIO_NET_F_NOTF_COAL_LOW_HIGH, while
> > clarifying/fixing existing coalescing concepts.
> >
> While its visible in the patch itself, what is being done,
> its important to mention the problem statement/motivation for the feature at
> start of the commit
> > #define VIRTIO_NET_CTRL_NOTF_COAL 6
> > #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0
> > #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
> > + #define VIRTIO_NET_CTRL_NOTF_COAL_LOW_TX_SET 2 //Only if
> > VIRTIO_NET_F_NOTF_COAL_LOW_HIGH negotiated
> > + #define
