[virtio-dev] Re: [PATCH v2] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

2023-02-05 Thread Michael S. Tsirkin
On Sun, Feb 05, 2023 at 05:19:11PM +0200, Alvaro Karsz wrote: > If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may > send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ > feature should be negotiated. > > --- > v2: Use SHOULD instead of Feature bit requirement, ve

[virtio-dev] [PATCH v2] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

2023-02-05 Thread Alvaro Karsz
If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ feature should be negotiated. --- v2: Use SHOULD instead of Feature bit requirement, version 1.2 is already out and doesn't include this depencency. Signed-

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-02-05 Thread Michael S. Tsirkin
On Wed, Jan 11, 2023 at 10:12:38PM +0100, Halil Pasic wrote: > On Wed, 11 Jan 2023 19:08:53 +0800 > Xuan Zhuo wrote: > > > > > +The device shares memory to the driver based on shared memory regions exposes memory to the driver btw. "share" is already overused in this text. > > > > +\ref{sec:Bas

Re: [virtio-dev] [PATCH] virtio-net: Mention that VIRTIO_NET_F_HASH_REPORT requires VIRTIO_NET_F_CTRL_VQ

2023-02-05 Thread Michael S. Tsirkin
On Sun, Feb 05, 2023 at 02:08:01PM +0200, Alvaro Karsz wrote: > If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may > send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ > feature must be negotiated. > > Signed-off-by: Alvaro Karsz Unfortunately we did not make t

[virtio-dev] [PATCH] virtio-net: Mention that VIRTIO_NET_F_HASH_REPORT requires VIRTIO_NET_F_CTRL_VQ

2023-02-05 Thread Alvaro Karsz
If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ feature must be negotiated. Signed-off-by: Alvaro Karsz --- device-types/net/description.tex | 1 + 1 file changed, 1 insertion(+) diff --git a/device-types/n