RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-07 Thread Parav Pandit
> From: Heng Qi > Sent: Tuesday, February 7, 2023 10:25 PM [..] > >> > >> Do you think we need both hash_types and hash_tunnel_types? > > In struct virtio_net_config we need two fields. > > a. supported_hash_types (already exists) b. supported_hash_tunnel_type > > -> bitmap indicating for which

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-07 Thread Parav Pandit
> From: Heng Qi > Sent: Tuesday, February 7, 2023 9:31 PM > > 在 2023/1/31 下午1:28, Heng Qi 写道: > > On Mon, Jan 16, 2023 at 04:42:11PM +0800, Jason Wang wrote: > >> 在 2023/1/16 16:01, Heng Qi 写道: > >>> On Wed, Jan 11, 2023 at 04:45:12AM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 04, 2023

RE: [virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Heng Qi > Sent: Tuesday, February 7, 2023 9:36 PM > > > 在 2023/2/8 上午10:20, Parav Pandit 写道: > >> From: Xuan Zhuo > >> Sent: Tuesday, February 7, 2023 8:46 PM > >> > >> On Tue, 7 Feb 2023 09:06:19 -0500, "Michael S. Tsirkin" > >> > >> wrote: > >>> On Tue, Feb 07, 2023 at 07:16:34PM

[virtio-dev] RE: RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, February 7, 2023 9:25 PM > > On Wed, 8 Feb 2023 02:20:27 +, Parav Pandit wrote: > > > > > From: Xuan Zhuo > > > Sent: Tuesday, February 7, 2023 8:46 PM > > > > > > On Tue, 7 Feb 2023 09:06:19 -0500, "Michael S. Tsirkin" > > > > > > wrote: > > > > On

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, February 7, 2023 8:46 PM > > On Tue, 7 Feb 2023 09:06:19 -0500, "Michael S. Tsirkin" > wrote: > > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > > > Currently, the coalescing profile is directly applied to all queues. > > > This patch supports

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Xuan Zhuo
On Tue, 7 Feb 2023 10:28:37 -0500, "Michael S. Tsirkin" wrote: > On Tue, Feb 07, 2023 at 03:25:55PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Tuesday, February 7, 2023 10:09 AM > > > > > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > > > >

[virtio-dev] RE: [PATCH v2] virtio-net: Improve introductory description

2023-02-07 Thread Parav Pandit
> From: Cornelia Huck > Sent: Tuesday, February 7, 2023 5:07 AM > > On Thu, Feb 02 2023, Parav Pandit wrote: > > > The control VQ of the virtio network device is used beyond advance > > steering control. The control VQ dynamically changes multiple features > > of the initialized device. > >

[virtio-dev] Re: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 09:33:11PM +, Parav Pandit wrote: > > > > From: Cornelia Huck > > Sent: Tuesday, February 7, 2023 10:50 AM > > > > On Tue, Feb 07 2023, Parav Pandit wrote: > > > > >> From: Cornelia Huck > > >> Sent: Tuesday, February 7, 2023 8:49 AM > > >> > > >> On Fri, Feb 03

[virtio-dev] RE: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Parav Pandit
> From: Cornelia Huck > Sent: Tuesday, February 7, 2023 10:50 AM > > On Tue, Feb 07 2023, Parav Pandit wrote: > > >> From: Cornelia Huck > >> Sent: Tuesday, February 7, 2023 8:49 AM > >> > >> On Fri, Feb 03 2023, Parav Pandit wrote: > >> > >> > Currently some fields of the

[virtio-dev] RE: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Cornelia Huck
On Tue, Feb 07 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Tuesday, February 7, 2023 8:49 AM >> >> On Fri, Feb 03 2023, Parav Pandit wrote: >> >> > Currently some fields of the virtio_net_config structure are defined >> > before introducing the structure and some are defined

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, February 7, 2023 10:29 AM > > On Tue, Feb 07, 2023 at 03:25:55PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Tuesday, February 7, 2023 10:09 AM > > > > > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 03:25:55PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, February 7, 2023 10:09 AM > > > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > > > An example of a question is this: we have two RX queues say 1 and 2 > > > >

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, February 7, 2023 10:09 AM > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > > An example of a question is this: we have two RX queues say 1 and 2 > > > each with a distinct interrupt vector. coalescing is set to 10 > > > packets.

[virtio-dev] Re: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 03:02:08PM +, Parav Pandit wrote: > > > From: Cornelia Huck > > Sent: Tuesday, February 7, 2023 8:49 AM > > > > On Fri, Feb 03 2023, Parav Pandit wrote: > > > > > Currently some fields of the virtio_net_config structure are defined > > > before introducing the

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > An example of a question is this: we have two RX queues say 1 and 2 each > > with a distinct interrupt vector. coalescing is set to 10 packets. Now > > 9 packets arrive on queue 1 and 1 on queue 2. Do you expect an > > interrupt?

[virtio-dev] RE: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Parav Pandit
> From: Cornelia Huck > Sent: Tuesday, February 7, 2023 8:49 AM > > On Fri, Feb 03 2023, Parav Pandit wrote: > > > Currently some fields of the virtio_net_config structure are defined > > before introducing the structure and some are defined after > > introducing virtio_net_config. > >

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Alvaro Karsz
> An example of a question is this: we have two RX queues say 1 and 2 each > with a distinct interrupt vector. coalescing is set to 10 packets. Now > 9 packets arrive on queue 1 and 1 on queue 2. Do you expect an > interrupt? If yes which one - 1 or 2 or both? Sorry, I wasn't clear enough. In

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 04:40:56PM +0200, Alvaro Karsz wrote: > > Arguably it's true. > > It will all be up to the committee vote of course ... > > To keep things a bit safer how about we just allow commands > > without qid instead of a special qid value? > > Also if we are going to change things

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Alvaro Karsz
> Arguably it's true. > It will all be up to the committee vote of course ... > To keep things a bit safer how about we just allow commands > without qid instead of a special qid value? > Also if we are going to change things how about adding a query command too? > > Also Alvaro what is your take

[virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 12:51:26PM +, Parav Pandit wrote: > > > From: Xuan Zhuo > > Sent: Tuesday, February 7, 2023 6:50 AM > > > > On Tue, 7 Feb 2023 13:25:13 +0200, Alvaro Karsz > > wrote: > > > Hi Heng, > > > > > > > Currently, the coalescing profile is directly applied to all queues. >

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 09:06:24AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > > Currently, the coalescing profile is directly applied to all queues. > > This patch supports configuring the parameters for a specified queue. > > > > When the

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] [PATCH] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature

2023-02-07 Thread Michael S. Tsirkin
On Mon, Feb 06, 2023 at 11:08:47PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, February 6, 2023 5:27 PM > > [..] > > > So, both can handle/generate spurious notifications, but it shouldn't be > > > best > > line guidance. > > > > Don't really see why not. Lots

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

2023-02-07 Thread Michael S. Tsirkin
On Mon, Feb 06, 2023 at 10:02:39PM +, Parav Pandit wrote: > > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Alvaro Karsz > > --- > > v2: Use SHOULD instead of Feature bit requirement, version 1.2 is already > > out and doesn't include this depencency. > > > > v3: Explain

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > Currently, the coalescing profile is directly applied to all queues. > This patch supports configuring the parameters for a specified queue. > > When the traffic between queues is unbalanced, for example, one queue > is busy and another

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-02-07 Thread Cornelia Huck
On Tue, Feb 07 2023, Alexandre Courbot wrote: > On Mon, Feb 6, 2023 at 11:13 PM Cornelia Huck wrote: >> >> On Thu, Jan 19 2023, Alexander Gordeev >> wrote: >> >> > Hi Alexandre, >> > >> > On 12.01.23 07:39, Alexandre Courbot wrote: >> >> On Thu, Jan 12, 2023 at 3:42 AM Alexander Gordeev >> >>

[virtio-dev] Re: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Cornelia Huck
On Fri, Feb 03 2023, Parav Pandit wrote: > Currently some fields of the virtio_net_config structure are defined > before introducing the structure and some are defined after > introducing virtio_net_config. > Better to define the configuration layout first followed by > description of all the

[virtio-dev] RE: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, February 7, 2023 6:50 AM > > On Tue, 7 Feb 2023 13:25:13 +0200, Alvaro Karsz > wrote: > > Hi Heng, > > > > > Currently, the coalescing profile is directly applied to all queues. > > > This patch supports configuring the parameters for a specified queue. > >

[virtio-dev] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Alvaro Karsz
Hi Heng, > Currently, the coalescing profile is directly applied to all queues. > This patch supports configuring the parameters for a specified queue. > > When the traffic between queues is unbalanced, for example, one queue > is busy and another queue is idle, then it will be very useful to >

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-02-07 Thread Alexander Gordeev
On 06.02.23 15:12, Cornelia Huck wrote: On Thu, Jan 19 2023, Alexander Gordeev wrote: On 12.01.23 07:39, Alexandre Courbot wrote: On Thu, Jan 12, 2023 at 3:42 AM Alexander Gordeev wrote: Well, on the one hand mimicking v4l2 looks like an easy solution from virtio-video spec writing

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-02-07 Thread Alexander Gordeev
On 07.02.23 07:51, Alexandre Courbot wrote: On Thu, Jan 19, 2023 at 8:06 AM Alexander Gordeev wrote: Well, on the one hand mimicking v4l2 looks like an easy solution from virtio-video spec writing perspective. (But the implementers will have to read the V4L2 API instead AFAIU, which is

[virtio-dev] Re: [PATCH v2] virtio-net: Improve introductory description

2023-02-07 Thread Cornelia Huck
On Thu, Feb 02 2023, Parav Pandit wrote: > The control VQ of the virtio network device is used beyond advance > steering control. The control VQ dynamically changes multiple features > of the initialized device. > > Hence, update this area of control VQ introductory description at few > places

Re: [virtio-dev] [PATCH] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature

2023-02-07 Thread Alvaro Karsz
Hi Parav, thanks for the comments. > > +Note: In general, these commands are best-effort: A device could send a > > notification even if it is not supposed to. > > > Please remove this note from this patch. > Instead of Note, we need to describe this device requirements description. > We better