[virtio-dev] RE: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Parav Pandit
> From: Heng Qi > Sent: Friday, February 10, 2023 2:02 AM > > Currently, the coalescing profile is directly applied to all queues. Say it, Currently coalescing parameters are grouped for all transmit and receive virtqueues. > This patch supports setting or getting the parameters for a

RE: [virtio-dev] Re: [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

2023-02-10 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Alvaro Karsz > > Should we have a vote? > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/158 I missed your previous response. Sorry for the late response. Why cannot device say as MUST requirement? Let say there is a device

[virtio-dev] Re: [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

2023-02-10 Thread Alvaro Karsz
Should we have a vote? Fixes: https://github.com/oasis-tcs/virtio-spec/issues/158 - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [virtio-comment] [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Heng Qi
在 2023/2/10 下午6:16, Alvaro Karsz 写道: So, should we remove VIRTIO_NET_F_CTRL_VQ here, or fix VIRTIO_NET_F_HOST_ECN? Ah good point. But I think VIRTIO_NET_F_VQ_NOTF_COAL should not depend on VIRTIO_NET_F_NOTF_COAL. This way devices can drop the all-rx/all-tx commands if they want to. We

[virtio-dev] Re: [PATCH] content.tex Fix Driver notifications label

2023-02-10 Thread Cornelia Huck
On Fri, Feb 03 2023, Parav Pandit wrote: > Driver notifications section is under "Basic Facilities of a Virtio > Device". However, the label is placed under "Virtqueues" section. > > Fix the label references. > > Signed-off-by: Parav Pandit > --- > content.tex | 14 +++--- > 1 file

[virtio-dev] Re: [virtio-comment] [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 06:00:42PM +0800, Heng Qi wrote: > > > 在 2023/2/10 下午5:38, Michael S. Tsirkin 写道: > > On Fri, Feb 10, 2023 at 11:22:14AM +0200, Alvaro Karsz wrote: > > > Thanks Heng. > > > > > > > Currently, the coalescing profile is directly applied to all queues. > > > > This patch

[virtio-dev] Re: [virtio-comment] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 05:53:40PM +0800, Heng Qi wrote: > > > 在 2023/2/10 下午4:38, Michael S. Tsirkin 写道: > > On Fri, Feb 10, 2023 at 03:01:30PM +0800, Heng Qi wrote: > > > Currently, the coalescing profile is directly applied to all queues. > > > This patch supports setting or getting the

[virtio-dev] Re: [virtio-comment] [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Alvaro Karsz
> >> So, should we remove VIRTIO_NET_F_CTRL_VQ here, or fix > >> VIRTIO_NET_F_HOST_ECN? > > Ah good point. > > But I think VIRTIO_NET_F_VQ_NOTF_COAL should not depend on > > VIRTIO_NET_F_NOTF_COAL. > > This way devices can drop the all-rx/all-tx commands if they want to. > > We need to confirm

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 11:30:40AM +0200, Alvaro Karsz wrote: > > > \devicenormative{\subparagraph}{Notifications Coalescing}{Device Types / > > > Network Device / Device Operation / Control Virtqueue / Notifications > > > Coalescing} > > > > > > -A device SHOULD respond to the

[virtio-dev] Re: [virtio-comment] [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 11:22:14AM +0200, Alvaro Karsz wrote: > Thanks Heng. > > > Currently, the coalescing profile is directly applied to all queues. > > This patch supports setting or getting the parameters for a specified queue, > > and a typical application of this function is NetDIM. > > >

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Alvaro Karsz
> On Fri, Feb 10, 2023 at 03:01:30PM +0800, Heng Qi wrote: > > Currently, the coalescing profile is directly applied to all queues. > > This patch supports setting or getting the parameters for a specified queue, > > and a typical application of this function is NetDIM. > > > > When the traffic

[virtio-dev] Re: [virtio-comment] [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Alvaro Karsz
Thanks Heng. > Currently, the coalescing profile is directly applied to all queues. > This patch supports setting or getting the parameters for a specified queue, > and a typical application of this function is NetDIM. > > When the traffic between queues is unbalanced, for example, one queue > is

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 03:01:30PM +0800, Heng Qi wrote: > Currently, the coalescing profile is directly applied to all queues. > This patch supports setting or getting the parameters for a specified queue, > and a typical application of this function is NetDIM. > > When the traffic between

[virtio-dev] Re: [virtio-comment] [PATCH v10 03/10] admin: introduce group administration commands

2023-02-10 Thread Zhu Lingshan
On 2/9/2023 8:13 PM, Michael S. Tsirkin wrote: This introduces a general structure for group administration commands, used to control device groups through their owner. Following patches will introduce specific commands and an interface for submitting these commands to the owner.