[virtio-dev] [PATCH 1/1] RFC: virtio-bt: add virtio BT device specification

2023-03-09 Thread Igor Skalkin
This PR is aimed as review for comments(RFC) purpose. * Initial draft version. Signed-off-by: Igor Skalkin --- conformance.tex| 12 ++- content.tex| 1 + device-types/bt/description.tex| 112 +

[virtio-dev] [PATCH 0/1] Virtio-bt specification draft

2023-03-09 Thread Igor Skalkin
We have been using virtio bluetooth linux kernel driver and virtio bluetooth devices for some time now, but it still has no spec. This is the first attempt to start developing this specification. Igor Skalkin (1): RFC: virtio-bt: add virtio BT device specification conformance.tex

[virtio-dev] RE: [PATCH v11] virtio-net: support the virtqueue coalescing moderation

2023-03-09 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, March 9, 2023 2:19 PM > > On Thu, Mar 09, 2023 at 01:53:37PM -0500, Parav Pandit wrote: > > > > > Network Device / Device Operation / Control Virtqueue / > > > Notifications Coalescing} -If the VIRTIO_NET_F_NOTF_COAL feature is > negotiated, the

Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 12:55:02PM +0800, Heng Qi wrote: > > > 在 2023/3/8 下午10:39, Michael S. Tsirkin 写道: > > On Wed, Mar 01, 2023 at 10:56:31AM +0800, Heng Qi wrote: > > > > > > 在 2023/2/28 下午7:16, Michael S. Tsirkin 写道: > > > > On Sat, Feb 18, 2023 at 10:37:15PM +0800, Heng Qi wrote: > > > >

[virtio-dev] Re: [PATCH v11] virtio-net: support the virtqueue coalescing moderation

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 01:53:37PM -0500, Parav Pandit wrote: > > > On 3/9/2023 8:05 AM, Heng Qi wrote: > > Currently, coalescing parameters are grouped for all transmit and receive > > virtqueues. This patch supports setting or getting the parameters for a > > specified virtqueue, and a typical

[virtio-dev] Re: [PATCH v11] virtio-net: support the virtqueue coalescing moderation

2023-03-09 Thread Parav Pandit
On 3/9/2023 8:05 AM, Heng Qi wrote: Currently, coalescing parameters are grouped for all transmit and receive virtqueues. This patch supports setting or getting the parameters for a specified virtqueue, and a typical application of this function is netdim[1]. When the traffic between

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, March 9, 2023 12:14 PM > > On Thu, Mar 09, 2023 at 04:53:59PM +, Parav Pandit wrote: > > Keeping my inputs aside for moment, what do you propose for v11? > > Following SCSI and relying on driver to worry about ordering. Got it. Thanks.

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 04:53:59PM +, Parav Pandit wrote: > Keeping my inputs aside for moment, what do you propose for v11? Following SCSI and relying on driver to worry about ordering. -- MST - To unsubscribe, e-mail:

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, March 9, 2023 9:43 AM > > > > > Ok. so there may be some use case for transport VQ. > > Worth to mention in the cover letter and things will be fine. > > Actual review of the transport VQ and its use will be in the respective > patchset. > > > > > >

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 05:46:50PM +0100, Halil Pasic wrote: > To uniquely identify an element we need both the index (a value) and > the array/table that is being indexed. And I believe this is what we > need to improve on. I don't think calling indexes into the conceptual > array of receive

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number

2023-03-09 Thread Halil Pasic
On Sun, 5 Mar 2023 04:51:54 -0500 "Michael S. Tsirkin" wrote: > > I don't think it would require an ABI change. We could just change the > > queue names. AFAIK those are not part of the ABI. I don't think it would > > be hard. > > Well at the moment this is the mapping: > > RSS index -

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Jiri Pirko
Thu, Mar 09, 2023 at 01:36:00PM CET, pa...@nvidia.com wrote: > > >> From: Jiri Pirko >> Sent: Thursday, March 9, 2023 2:37 AM > > >> >We want the ability to program/provision the virtio feature bits and virtio >> config space parameters of the VF through PF. >> >These are host-facing parameters

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 08:55:15AM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 09, 2023 at 07:35:42AM -0500, Stefan Hajnoczi wrote: > > On Wed, Mar 08, 2023 at 12:21:46PM -0500, Michael S. Tsirkin wrote: > > > On Wed, Mar 08, 2023 at 12:15:23PM -0500, Stefan Hajnoczi wrote: > > > > > > > > Or

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 02:30:52PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, March 9, 2023 9:23 AM > > > > On Thu, Mar 09, 2023 at 02:11:54PM +, Parav Pandit wrote: > > > > > > > > > > From: David Edmondson > > > > Sent: Thursday, March 9, 2023 9:03

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, March 9, 2023 9:23 AM > > On Thu, Mar 09, 2023 at 02:11:54PM +, Parav Pandit wrote: > > > > > > > From: David Edmondson > > > Sent: Thursday, March 9, 2023 9:03 AM > > > > > > Parav Pandit writes: > > > > > > >> From: Jiri Pirko > > > >>

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 02:11:54PM +, Parav Pandit wrote: > > > > From: David Edmondson > > Sent: Thursday, March 9, 2023 9:03 AM > > > > Parav Pandit writes: > > > > >> From: Jiri Pirko > > >> Sent: Thursday, March 9, 2023 2:31 AM > > >> > > >> Wed, Mar 08, 2023 at 10:25:32PM CET,

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Parav Pandit
> From: David Edmondson > Sent: Thursday, March 9, 2023 9:03 AM > > Parav Pandit writes: > > >> From: Jiri Pirko > >> Sent: Thursday, March 9, 2023 2:31 AM > >> > >> Wed, Mar 08, 2023 at 10:25:32PM CET, pa...@nvidia.com wrote: > >> > > >> >> From: virtio-comm...@lists.oasis-open.org > >>

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread David Edmondson
Parav Pandit writes: >> From: Jiri Pirko >> Sent: Thursday, March 9, 2023 2:31 AM >> >> Wed, Mar 08, 2023 at 10:25:32PM CET, pa...@nvidia.com wrote: >> > >> >> From: virtio-comm...@lists.oasis-open.org >> >> On Behalf Of David Edmondson >> > >> >> In support of live migration, might we end up

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 01:04:30PM +, Parav Pandit wrote: > > > From: Jiri Pirko > > Sent: Thursday, March 9, 2023 2:31 AM > > > > Wed, Mar 08, 2023 at 10:25:32PM CET, pa...@nvidia.com wrote: > > > > > >> From: virtio-comm...@lists.oasis-open.org > > >> On Behalf Of David Edmondson > > > >

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 07:35:42AM -0500, Stefan Hajnoczi wrote: > On Wed, Mar 08, 2023 at 12:21:46PM -0500, Michael S. Tsirkin wrote: > > On Wed, Mar 08, 2023 at 12:15:23PM -0500, Stefan Hajnoczi wrote: > > > > > > > Or we could say that admin commands must complete within bounded > > > > > > >

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Parav Pandit
> From: Jiri Pirko > Sent: Thursday, March 9, 2023 2:31 AM > > Wed, Mar 08, 2023 at 10:25:32PM CET, pa...@nvidia.com wrote: > > > >> From: virtio-comm...@lists.oasis-open.org > >> On Behalf Of David Edmondson > > > >> In support of live migration, might we end up moving large amounts of > >>

[virtio-dev] RE: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Parav Pandit
> From: Jiri Pirko > Sent: Thursday, March 9, 2023 2:37 AM > >We want the ability to program/provision the virtio feature bits and virtio > config space parameters of the VF through PF. > >These are host-facing parameters that usually migrate from one to another > host when a VF migrates. >

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 12:21:46PM -0500, Michael S. Tsirkin wrote: > On Wed, Mar 08, 2023 at 12:15:23PM -0500, Stefan Hajnoczi wrote: > > > > > > Or we could say that admin commands must complete within bounded > > > > > > time, > > > > > > but I'm not sure that is implementable for some device

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-09 Thread Heng Qi
在 2023/2/28 下午7:16, Michael S. Tsirkin 写道: On Sat, Feb 18, 2023 at 10:37:15PM +0800, Heng Qi wrote: If the tunnel is used to encapsulate the packets, the hash calculated using the outer header of the receive packets is always fixed for the same flow packets, i.e. they will be steered to the

[virtio-dev] Re: [PATCH V2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-09 Thread Viresh Kumar
On 07-03-23, 11:22, Stefan Hajnoczi wrote: > VHOST_USER_IOTLB_MSG probably isn't necessary because address > translation is not required. It will also reduce performance by adding > extra communication. > > Instead, you could change the 1 memory region : 1 mmap relationship that > existing

[virtio-dev] [PATCH V3 2/2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-09 Thread Viresh Kumar
The current model of memory mapping at the back-end works fine where a standard call to mmap() (for the respective file descriptor) is enough before the front-end can start accessing the guest memory. There are other complex cases though where the back-end needs more information and simple mmap()

[virtio-dev] [PATCH V3 1/2] docs: vhost-user: Define memory region separately

2023-03-09 Thread Viresh Kumar
The same layout is defined twice, once in "single memory region description" and then in "memory regions description". Separate out details of memory region from these two and reuse the same definition later on. While at it, also rename "memory regions description" to "multiple memory regions

[virtio-dev] [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks

2023-03-09 Thread Viresh Kumar
Hello, This patchset tries to update the vhost-user protocol to make it support special memory mapping required in case of Xen hypervisor. The first patch is mostly cleanup and second one introduces a new xen specific feature. V2->V3: - Remove the extra message and instead update the memory