[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Jason Wang
On Wed, May 10, 2023 at 2:05 PM Michael S. Tsirkin wrote: > > On Mon, May 08, 2023 at 10:23:39AM +0800, Jason Wang wrote: > > > I thought so too originally. Unfortunately I now think that no, legacy is > > > not > > > going to be a byproduct of transport virtqueue for modern - > > > it is differe

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 03:01:25PM +0800, Jason Wang wrote: > On Wed, May 10, 2023 at 2:05 PM Michael S. Tsirkin wrote: > > > > On Mon, May 08, 2023 at 10:23:39AM +0800, Jason Wang wrote: > > > > I thought so too originally. Unfortunately I now think that no, legacy > > > > is not > > > > going t

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash

2023-05-10 Thread Heng Qi
在 2023/5/9 下午11:15, Michael S. Tsirkin 写道: On Tue, May 09, 2023 at 10:22:19PM +0800, Heng Qi wrote: 在 2023/5/5 下午10:56, Michael S. Tsirkin 写道: On Fri, May 05, 2023 at 09:51:15PM +0800, Heng Qi wrote: On Thu, Apr 27, 2023 at 01:13:29PM -0400, Michael S. Tsirkin wrote: On Thu, Apr 27, 2023

[virtio-dev] Re: [PATCH v13 00/10] Introduce device group and device management

2023-05-10 Thread Jiri Pirko
Fri, May 05, 2023 at 05:40:33PM CEST, m...@redhat.com wrote: > > > >Change log: > >since 13: > command specific data is u8 again > exclude admin queues in blk's num_queues > minor other tweaks > >since 11: > addressed lots of comments, all minor. consistency with > out

[virtio-dev] RE: [PATCH v13 00/10] Introduce device group and device management

2023-05-10 Thread Parav Pandit
> From: Jiri Pirko > Sent: Wednesday, May 10, 2023 10:30 AM > > Michael, not sure if it is problem of this patchset or on my side but makepdf > fails to build this. With master branch, works fine. This patch fixes it. https://lore.kernel.org/virtio-comment/20230505163712.589460-1-pa...@nvidia

[virtio-dev] Re: [PATCH v13 00/10] Introduce device group and device management

2023-05-10 Thread Jiri Pirko
Wed, May 10, 2023 at 04:33:52PM CEST, pa...@nvidia.com wrote: > >> From: Jiri Pirko >> Sent: Wednesday, May 10, 2023 10:30 AM > >> >> Michael, not sure if it is problem of this patchset or on my side but makepdf >> fails to build this. With master branch, works fine. > >This patch fixes it. >http

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Parav Pandit
On 5/9/2023 11:51 PM, Jason Wang wrote: On Tue, May 9, 2023 at 11:56 AM Parav Pandit wrote: SIOV does not require mediation. Composition is optional like VFs. This is not what I read from SIOV spec. SIOV R1 spec was defined by _a_ vendor and it is undergoing upgrade to more practical us

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Parav Pandit
On 5/10/2023 12:22 AM, Jason Wang wrote: On Wed, May 10, 2023 at 11:51 AM Jason Wang wrote: Just to make sure we are at the same page. 1) if the hardware has configq and we need to make it work for current virtio-pci driver, hypervisor needs to trap guest PCI access and translate it to c

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Parav Pandit
On 5/10/2023 2:04 AM, Michael S. Tsirkin wrote: On Mon, May 08, 2023 at 10:23:39AM +0800, Jason Wang wrote: I thought so too originally. Unfortunately I now think that no, legacy is not going to be a byproduct of transport virtqueue for modern - it is different enough that it needs dedicated

[virtio-dev] Re: [PATCH v13 00/10] Introduce device group and device management

2023-05-10 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 02:33:52PM +, Parav Pandit wrote: > > > From: Jiri Pirko > > Sent: Wednesday, May 10, 2023 10:30 AM > > > > > Michael, not sure if it is problem of this patchset or on my side but > > makepdf > > fails to build this. With master branch, works fine. > > This patch f

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Parav Pandit
On 5/10/2023 3:43 AM, Michael S. Tsirkin wrote: On Wed, May 10, 2023 at 03:01:25PM +0800, Jason Wang wrote: On Wed, May 10, 2023 at 2:05 PM Michael S. Tsirkin wrote: On Mon, May 08, 2023 at 10:23:39AM +0800, Jason Wang wrote: I thought so too originally. Unfortunately I now think that no,

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 12:11:50PM -0400, Parav Pandit wrote: > > > On 5/10/2023 2:04 AM, Michael S. Tsirkin wrote: > > On Mon, May 08, 2023 at 10:23:39AM +0800, Jason Wang wrote: > > > > I thought so too originally. Unfortunately I now think that no, legacy > > > > is not > > > > going to be a

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, May 10, 2023 12:16 PM > > On Wed, May 10, 2023 at 12:11:50PM -0400, Parav Pandit wrote: > > > > > > On 5/10/2023 2:04 AM, Michael S. Tsirkin wrote: > > > On Mon, May 08, 2023 at 10:23:39AM +0800, Jason Wang wrote: > > > > > I thought so too origina

[virtio-dev] RE: [PATCH v3 0/2] transport-pci: msix register desc improve

2023-05-10 Thread Parav Pandit
> From: Parav Pandit > Sent: Friday, April 28, 2023 12:10 AM > To: Parav Pandit ; Michael S. Tsirkin > > Hi, > > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Parav Pandit > > Sent: Monday, April 24, 2023 11:15 AM > > > > LGTM. > > > Given the amount of back and forth,

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Parav Pandit
Hi Jason, Michel, > From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Parav Pandit > Sent: Wednesday, May 10, 2023 1:34 PM > > > From: Michael S. Tsirkin > > Sent: Wednesday, May 10, 2023 12:16 PM > > > > On Wed, May 10, 2023 at 12:11:50PM -0400, Parav Pandit wrote: > > > > > > >

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 09:08:44PM +, Parav Pandit wrote: > Hi Jason, Michel, > > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Parav Pandit > > Sent: Wednesday, May 10, 2023 1:34 PM > > > > > From: Michael S. Tsirkin > > > Sent: Wednesday, May 10, 2023 12:16 PM > > >

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-10 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, May 10, 2023 5:33 PM > > I think some kind of "enable" command for VFs might have value. No? Unlike the SIOV devices, VFs life cycle is under PF control, not sure how the enable command can help. After SR-IOV is enabled, VF is short of enabled, it m

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash

2023-05-10 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 05:15:37PM +0800, Heng Qi wrote: > > > 在 2023/5/9 下午11:15, Michael S. Tsirkin 写道: > > On Tue, May 09, 2023 at 10:22:19PM +0800, Heng Qi wrote: > > > > > > 在 2023/5/5 下午10:56, Michael S. Tsirkin 写道: > > > > On Fri, May 05, 2023 at 09:51:15PM +0800, Heng Qi wrote: > > > > >