Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Michael S. Tsirkin
On Wed, Jun 21, 2023 at 01:09:40AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, June 20, 2023 6:22 AM > > > > On Tue, Jun 20, 2023 at 12:14:16AM +, Parav Pandit wrote: > > > > > > > > > > From: virtio-dev@lists.oasis-open.org > > > > On Behalf Of Michael S

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, June 20, 2023 6:22 AM > > On Tue, Jun 20, 2023 at 12:14:16AM +, Parav Pandit wrote: > > > > > > > From: virtio-dev@lists.oasis-open.org > > > On Behalf Of Michael S. Tsirkin > > > Sent: Monday, June 19, 2023 1:46 PM > > > > > These devices have

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Parav Pandit
Michael, > From: Parav Pandit > Sent: Monday, June 19, 2023 2:07 PM > We don't need to do it now. > > > Current VF capability is kind of ok I guess ... > > > Already proposed one? > > > If you want admin command to query then it would need to map in PF > memory. > No need. > It is similar to

Re: [virtio-dev] Re: [virtio-comment] [PATCH v17] virtio-net: support inner header hash

2023-06-20 Thread Michael S. Tsirkin
On Tue, Jun 20, 2023 at 09:48:33PM +0800, Heng Qi wrote: > On Tue, Jun 20, 2023 at 08:06:16AM -0400, Michael S. Tsirkin wrote: > > On Mon, Jun 12, 2023 at 04:09:20PM +0800, Heng Qi wrote: > > > 1. Currently, a received encapsulated packet has an outer and an inner > > > header, but > > > the virti

Re: [virtio-dev] Re: [virtio-comment] [PATCH v17] virtio-net: support inner header hash

2023-06-20 Thread Heng Qi
On Tue, Jun 20, 2023 at 08:06:16AM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 12, 2023 at 04:09:20PM +0800, Heng Qi wrote: > > 1. Currently, a received encapsulated packet has an outer and an inner > > header, but > > the virtio device is unable to calculate the hash for the inner header. The

[virtio-dev] Re: [virtio-comment] [PATCH v17] virtio-net: support inner header hash

2023-06-20 Thread Michael S. Tsirkin
On Mon, Jun 12, 2023 at 04:09:20PM +0800, Heng Qi wrote: > 1. Currently, a received encapsulated packet has an outer and an inner > header, but > the virtio device is unable to calculate the hash for the inner header. The > same > flow can traverse through different tunnels, resulting in the enca

Re: [virtio-dev] [PATCH v17] virtio-net: support inner header hash

2023-06-20 Thread Michael S. Tsirkin
On Tue, Jun 20, 2023 at 06:52:22PM +0800, Heng Qi wrote: > > > 在 2023/6/15 下午5:29, Heng Qi 写道: > > > > Hi all! > > > > If after reviewing it you feel this version meets the > > necessaryrequirements, > > I kindly request a vote. > > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/17

Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Michael S. Tsirkin
On Tue, Jun 20, 2023 at 12:14:16AM +, Parav Pandit wrote: > > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:46 PM > > > These devices have a legacy interface yes? > Yes. partially. > > > So they should be transitional to avo