Re: [virtio-dev][PATCH 2/2] virtio-spi: add the device specification

2023-06-28 Thread Haixu Cui
Hi @jrreinh...@google.com, Thank you very much for your helpful comments. I missed the delay and cs_change_delay parameters. I will add both of them, although cs_change_delay can not be set from userspace, but can be set in kernel space. For CS delays such as PRE_DELAY/POST_DELAY

[virtio-dev] Re: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 11:46:22AM +0800, Jason Wang wrote: > On Wed, Jun 28, 2023 at 12:35 AM Heng Qi wrote: > > > > 1. Currently, a received encapsulated packet has an outer and an inner > > header, but > > the virtio device is unable to calculate the hash for the inner header. The > > same >

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 04:23:09AM +, Parav Pandit wrote: > > > From: Jason Wang > > Sent: Tuesday, June 27, 2023 11:46 PM > > > > Having it in the config space, then a type agnostic provisioning through > > config > > space + feature bits just works fine. > > > Provisioning is far simpler

[virtio-dev] Re: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Thu, Jun 22, 2023 at 05:58:29PM +, Parav Pandit wrote: > > > > > > So what is the solution proposed for this? > > > > > > > > > > > 1. Query member device capabilities via admin command > > > > > > > > But that's not 1.3 material. > > > > > > > > > > Yes the current migration is broken in ma

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Thu, Jun 22, 2023 at 08:27:48PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, June 22, 2023 3:02 PM > > > > > Existing fields used by existing drivers must be in MMIO. > > > Device does not have a choice. > > > > They can if they like mask some less import

[virtio-dev] RE: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, June 27, 2023 10:21 PM > > I can see this making sense as a feature bit that says VFs are not > > initialized by default and must first be setup through an admin command. > > This will likely need to be a feature bit because it's changing > > behaviour outsid

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 10:21:04AM +0800, Xuan Zhuo wrote: > On Tue, 27 Jun 2023 12:02:41 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote: > > > So, this is how I understand the process of creating vf: > > > > > > 1. Create a PCI VF, at this time

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 02:06:32PM +0800, Xuan Zhuo wrote: > On Wed, 28 Jun 2023 10:49:45 +0800, Jason Wang wrote: > > On Tue, Jun 27, 2023 at 6:54 PM Xuan Zhuo > > wrote: > > > > > > On Tue, 27 Jun 2023 17:00:06 +0800, Jason Wang > > > wrote: > > > > On Tue, Jun 27, 2023 at 4:28 PM Xuan Zhuo

[virtio-dev] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, June 28, 2023 1:38 AM [..] > > Provisioning is far simpler thing to do in device specific way than asking > > device > to store this value in onchip area which is rarely accessed. > > Are you suggesting to not place any new fields in the config space? >

[virtio-dev] RE: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, June 28, 2023 6:27 AM > > On Wed, Jun 28, 2023 at 04:23:09AM +, Parav Pandit wrote: > > > > > From: Jason Wang > > > Sent: Tuesday, June 27, 2023 11:46 PM > > > > > > Having it in the config space, then a type agnostic provisioning > > > throu

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 04:18:02PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, June 28, 2023 6:27 AM > > > > On Wed, Jun 28, 2023 at 04:23:09AM +, Parav Pandit wrote: > > > > > > > From: Jason Wang > > > > Sent: Tuesday, June 27, 2023 11:46 PM > > > > >

[virtio-dev] RE: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

2023-06-28 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, June 28, 2023 6:41 AM > > > So just quickly add the new capability in the spec and then the > > > number of linux releases that will have the new feature but not > > > config command or whatever that is will be too small for vendors to care. > > > >

[virtio-dev] RE: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, June 28, 2023 12:46 PM > Actually, my preblem is exactly if there's no one single interface that can do > everything. > Extended config space reading via single DMA interface is just enough. > > Two interfaces that do the same might seem redundant

[virtio-dev] Re: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 04:46:04PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, June 28, 2023 6:41 AM > > > > > So just quickly add the new capability in the spec and then the > > > > number of linux releases that will have the new feature but not > > > > config

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 05:06:40PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, June 28, 2023 12:46 PM > > > Actually, my preblem is exactly if there's no one single interface that can > > do > > everything. > > > Extended config space reading via single DMA in

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 05:06:40PM +, Parav Pandit wrote: > > > > > > > > Please let people just focus on fixing config space instead of > > > > temporary cvq hacks. > > > > > > The ask is to have predictable sizing for existing defined config space > > > field and > > not keep infinitely grow

[virtio-dev] RE: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, June 28, 2023 1:16 PM > > 1. Because than device is 100% sure that it does not fulfill MMIO > > needs 2. Single interface to access extended config space, which is what you > asked for. > > 3. Single driver code because there is single way to get it

[virtio-dev] RE: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, June 28, 2023 1:24 PM > > Because when device has two ways to access config space, it always have to > account and build the interface that, hey some driver will not use DMA. > > Hence have it always in the MMIO accessible area. > > Maybe I get it

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 05:38:29PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, June 28, 2023 1:24 PM > > > > > Because when device has two ways to access config space, it always have to > > account and build the interface that, hey some driver will not use DMA

[virtio-dev] RE: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, June 28, 2023 3:45 PM > > > Maybe I get it. You want to use the new features as a carrot to > > > force drivers to implement DMA? You suspect they will ignore the > > > spec requirement just because things seem to work? > > > > > Right because it is

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Heng Qi
在 2023/6/29 上午9:56, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Wednesday, June 28, 2023 3:45 PM Maybe I get it. You want to use the new features as a carrot to force drivers to implement DMA? You suspect they will ignore the spec requirement just because things seem to work? Right b

[virtio-dev] Re: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Jason Wang
On Thu, Jun 29, 2023 at 12:00 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Wednesday, June 28, 2023 1:38 AM > > [..] > > > Provisioning is far simpler thing to do in device specific way than > > > asking device > > to store this value in onchip area which is rarely accessed. > > >

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Jason Wang
On Wed, Jun 28, 2023 at 11:55 PM Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2023 at 02:06:32PM +0800, Xuan Zhuo wrote: > > On Wed, 28 Jun 2023 10:49:45 +0800, Jason Wang wrote: > > > On Tue, Jun 27, 2023 at 6:54 PM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 27 Jun 2023 17:00:06 +0800, Ja

[virtio-dev] Re: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Jason Wang
在 2023/6/28 18:10, Michael S. Tsirkin 写道: On Wed, Jun 28, 2023 at 11:46:22AM +0800, Jason Wang wrote: On Wed, Jun 28, 2023 at 12:35 AM Heng Qi wrote: 1. Currently, a received encapsulated packet has an outer and an inner header, but the virtio device is unable to calculate the hash for the

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Michael S. Tsirkin
On Thu, Jun 29, 2023 at 01:56:34AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, June 28, 2023 3:45 PM > > > > Maybe I get it. You want to use the new features as a carrot to > > > > force drivers to implement DMA? You suspect they will ignore the > > > > spec

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Heng Qi
On Thu, Jun 29, 2023 at 01:56:34AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, June 28, 2023 3:45 PM > > > > Maybe I get it. You want to use the new features as a carrot to > > > > force drivers to implement DMA? You suspect they will ignore the > > > > spec