On Thu, Jul 06, 2023 at 04:20:03AM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, July 5, 2023 7:09 AM
>
> > OK I sent a bunch of comments. Pls try to address, unfortunately I didn't
> > go in
> > depth over the last patch, but I feel it should be squashed int
On Wed, Jul 05, 2023 at 06:26:13PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, July 5, 2023 7:05 AM
>
>
> > > +These commands are currently only defined for the PCI SR-IOV group
> > > +type and
> >
> > We call it SR-IOV group type not PCI SR-IOV group type
On Wed, Jul 05, 2023 at 04:34:02PM +, Parav Pandit wrote:
>
>
> > From: Cornelia Huck
> > Sent: Wednesday, July 5, 2023 6:24 AM
> > > +
> > > +In some systems, there is a need to support utilizing the legacy
> > > +driver with the device that do not directly support the legacy
> > > +interfa
> From: Michael S. Tsirkin
> Sent: Wednesday, July 5, 2023 7:09 AM
> OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go
> in
> depth over the last patch, but I feel it should be squashed into the generic
> legacy command sections avoiding need for indirection, so rewr
Currently all opcode appears to be in a single row.
Separate them with a line similar to other tables.
Signed-off-by: Parav Pandit
Reviewed-by: Cornelia Huck
---
changelog:
v2->v3:
- new patch
---
admin.tex | 2 ++
1 file changed, 2 insertions(+)
diff --git a/admin.tex b/admin.tex
index 2efd4
This patch links how in a PCI transport a group owner can access group
member (PCI VFs) legacy registers using a legacy registers access
commands using administration virtqueue infrastructure.
Additionally it extend the PCI notification capability through which a
PCI VF device indicates to the dri
Requirements are put one additional level down. Fix it.
Signed-off-by: Parav Pandit
---
changelog:
v9->v10:
- addressed comments from Cornelia
- fixed requirements for administration virtqueue section
v4->v5:
- new patch
---
admin.tex | 8
1 file changed, 4 insertions(+), 4 deletions(-)
This short series introduces legacy registers access commands for the owner
group member access the legacy registers of the member VFs.
This short series introduces legacy region access commands by the group owner
device for its member devices.
Currently it is applicable to the PCI PF and VF device
Introduce group member legacy common configuration and legacy device
configuration access read/write commands.
Group member legacy registers access commands enable group owner driver
software to access legacy registers on behalf of the guest virtual
machine.
Usecase:
1. A hypervisor/syst
> From: Michael S. Tsirkin
> Sent: Wednesday, July 5, 2023 7:05 AM
[..]
> > +Refer to the specific transport section for the definition of the
> > +\field{region_data}.
>
> Transport sections are huge. Links please do not make the reader guess.
Yes, it is taken care in 4th patch when the trans
> From: Michael S. Tsirkin
> Sent: Wednesday, July 5, 2023 7:05 AM
> > +These commands are currently only defined for the PCI SR-IOV group
> > +type and
>
> We call it SR-IOV group type not PCI SR-IOV group type. Please be consistent.
>
Ack.
> > +have, generally, the same effect as member d
> From: Cornelia Huck
> Sent: Wednesday, July 5, 2023 6:29 AM
>
> > diff --git a/admin-cmds-legacy-interface.tex
> > b/admin-cmds-legacy-interface.tex index 09001d5..571b256 100644
> > --- a/admin-cmds-legacy-interface.tex
> > +++ b/admin-cmds-legacy-interface.tex
> > @@ -150,7 +150,7 @@ \subs
> From: Cornelia Huck
> Sent: Wednesday, July 5, 2023 6:24 AM
> > +
> > +In some systems, there is a need to support utilizing the legacy
> > +driver with the device that do not directly support the legacy
> > +interface. In such scenarios,
>
> Maybe better:
>
> "In some systems, there is a n
> From: virtio-dev@lists.oasis-open.org On
> Behalf Of Cornelia Huck
> Sent: Wednesday, July 5, 2023 6:10 AM
>
> Same thing applies to the normative statements for the admin vq (in the same
> file) -- do you want to fix that as well?
Yes, let me fix it.
I will do this as pre-work and this pat
> From: Cornelia Huck
> Sent: Wednesday, July 5, 2023 9:43 AM
>
> >> From: Michael S. Tsirkin
> >> Sent: Wednesday, July 5, 2023 7:09 AM
> >>
> >> OK I sent a bunch of comments. Pls try to address, unfortunately I
> >> didn't go in depth over the last patch, but I feel it should be
> >> squa
On Wed, Jul 05 2023, Parav Pandit wrote:
>> From: Michael S. Tsirkin
>> Sent: Wednesday, July 5, 2023 7:09 AM
>>
>> OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go
>> in
>> depth over the last patch, but I feel it should be squashed into the generic
>> legacy comma
> From: Michael S. Tsirkin
> Sent: Wednesday, July 5, 2023 7:09 AM
>
> OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go
> in
> depth over the last patch, but I feel it should be squashed into the generic
> legacy command sections avoiding need for indirection, so rew
On Wed, Jul 05, 2023 at 02:37:20AM +0300, Parav Pandit wrote:
> This short series introduces legacy registers access commands for the owner
> group member access the legacy registers of the member VFs.
> This short series introduces legacy region access commands by the group owner
> device for its
On Wed, Jul 05, 2023 at 02:37:23AM +0300, Parav Pandit wrote:
> Introduce group member legacy common configuration and legacy device
> configuration access read/write commands.
>
> Group member legacy configuration structure access commands enable group
> owner driver software to access legacy con
On Wed, Jul 05, 2023 at 02:37:24AM +0300, Parav Pandit wrote:
> This patch links how in a PCI transport a group owner can access group
> member (PCI VFs) legacy registers using a legacy registers access
> commands using administration virtqueue infrastructure.
>
> Additionally it extend the PCI no
On Wed, Jul 05 2023, Parav Pandit wrote:
> diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex
> index 09001d5..571b256 100644
> --- a/admin-cmds-legacy-interface.tex
> +++ b/admin-cmds-legacy-interface.tex
> @@ -150,7 +150,7 @@ \subsubsection{Legacy Interfaces}\label{s
On Wed, Jul 05 2023, Parav Pandit wrote:
> diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex
> new file mode 100644
> index 000..09001d5
> --- /dev/null
> +++ b/admin-cmds-legacy-interface.tex
> @@ -0,0 +1,205 @@
> +\subsubsection{Legacy Interfaces}\label{sec:Basi
On Wed, Jul 05 2023, Parav Pandit wrote:
> Requirements are put one additional level down. Fix it.
>
> Signed-off-by: Parav Pandit
> ---
> changelog:
> v4->v5:
> - new patch
> ---
> admin.tex | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Same thing applies to the normative statem
On Wed, Jul 05 2023, Parav Pandit wrote:
> Currently all opcode appears to be in a single row.
> Separate them with a line similar to other tables.
>
> Signed-off-by: Parav Pandit
> ---
> changelog:
> v2->v3:
> - new patch
> ---
> admin.tex | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-
24 matches
Mail list logo
