Introduce group member legacy common configuration and legacy device
configuration access read/write commands.
Group member legacy registers access commands enable group owner driver
software to access legacy registers on behalf of the guest virtual
machine.
Usecase:
1. A hypervisor/syst
Currently all opcode appears to be in a single row.
Separate them with a line similar to other tables.
Signed-off-by: Parav Pandit
Reviewed-by: Cornelia Huck
---
changelog:
v2->v3:
- new patch
---
admin.tex | 2 ++
1 file changed, 2 insertions(+)
diff --git a/admin.tex b/admin.tex
index 2efd4
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 6:36 PM
[..]
> I notice you decided to silently ignore my suggestion to document how are
> notifications performed. Repeating myself like this is despiriting for me.
I am sorry if it appeared that way,
But no, I didn’t silently ignored.
This short series introduces legacy registers access commands for the owner
group member access the legacy registers of the member VFs.
This short series introduces legacy region access commands by the group owner
device for its member devices.
Currently it is applicable to the PCI PF and VF device
Requirements are put one additional level down. Fix it.
Signed-off-by: Parav Pandit
Reviewed-by: Cornelia Huck
---
changelog:
v9->v10:
- addressed comments from Cornelia
- fixed requirements for administration virtqueue section
v4->v5:
- new patch
---
admin.tex | 8
1 file changed, 4 i
On Fri, Jul 07, 2023 at 12:27:19AM +0300, Parav Pandit wrote:
> This short series introduces legacy registers access commands for the owner
> group member access the legacy registers of the member VFs.
> This short series introduces legacy region access commands by the group owner
> device for its
On Fri, Jul 07, 2023 at 12:27:22AM +0300, Parav Pandit wrote:
> Introduce group member legacy common configuration and legacy device
> configuration access read/write commands.
>
> Group member legacy registers access commands enable group owner driver
> software to access legacy registers on beha
Introduce group member legacy common configuration and legacy device
configuration access read/write commands.
Group member legacy registers access commands enable group owner driver
software to access legacy registers on behalf of the guest virtual
machine.
Usecase:
1. A hypervisor/syst
Currently all opcode appears to be in a single row.
Separate them with a line similar to other tables.
Signed-off-by: Parav Pandit
Reviewed-by: Cornelia Huck
---
changelog:
v2->v3:
- new patch
---
admin.tex | 2 ++
1 file changed, 2 insertions(+)
diff --git a/admin.tex b/admin.tex
index 2efd4
Requirements are put one additional level down. Fix it.
Signed-off-by: Parav Pandit
Reviewed-by: Cornelia Huck
---
changelog:
v9->v10:
- addressed comments from Cornelia
- fixed requirements for administration virtqueue section
v4->v5:
- new patch
---
admin.tex | 8
1 file changed, 4 i
This short series introduces legacy registers access commands for the owner
group member access the legacy registers of the member VFs.
This short series introduces legacy region access commands by the group owner
device for its member devices.
Currently it is applicable to the PCI PF and VF device
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 4:42 PM
[..]
> > Can we please avoid this over engineering?
> > Interface has the doors open for driver to make wise decision depending on
> its environment.
>
> what if driver can access both with the same ease? this is the case that
On Thu, Jul 06, 2023 at 08:35:37PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 4:29 PM
> >
> > The driver has a final decision. Let's make it a SHOULD and then if driver
> > knows
> > best then it has the choice?
> >
>
> As you said, the driver ha
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 4:29 PM
>
> The driver has a final decision. Let's make it a SHOULD and then if driver
> knows
> best then it has the choice?
>
As you said, the driver has the final say.
There is really no reason to complicate the spec for a narrow ca
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 3:59 PM
> > Hardwaring BAR0 is in BAR area of the VF.
> > But virtio pci capabilities without this can still report bar 0 and virtio
> capabilities.
>
> How do they do this?
>
Device must not do it, but a broken device can report pci c
On Thu, Jul 06, 2023 at 08:21:13PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 3:43 PM
>
> > > > As the order is there anyway, why not just prescribe entries are used in
> > order?
> > >
> > > I don't see any value in defining any order. It is an ar
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 3:43 PM
> > > As the order is there anyway, why not just prescribe entries are used in
> order?
> >
> > I don't see any value in defining any order. It is an array of entries not
> > a priority
> list.
>
> I think we are losing out. Fo
On Thu, Jul 06, 2023 at 07:07:42PM +, Parav Pandit wrote:
> > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 3:01 PM
>
> > > +\begin{lstlisting}
> > > +struct virtio_pci_legacy_notify_region {
> > > +u8 owner; /*
On Thu, Jul 06, 2023 at 07:00:22PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 2:57 PM
>
> > > I am just saying to keep things simple. Let driver choose any entry it
> > > wants to
> > use instead of device deciding on priority and hints etc.
> >
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 3:01 PM
> > +\begin{lstlisting}
> > +struct virtio_pci_legacy_notify_region {
> > +u8 owner; /* When set to 1, notification region is of the
> > +owner device */
>
> I pr
On Thu, Jul 06, 2023 at 07:17:14AM +0300, Parav Pandit wrote:
> This patch links how in a PCI transport a group owner can access group
> member (PCI VFs) legacy registers using a legacy registers access
> commands using administration virtqueue infrastructure.
>
> Additionally it extend the PCI no
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 2:57 PM
> > I am just saying to keep things simple. Let driver choose any entry it
> > wants to
> use instead of device deciding on priority and hints etc.
>
> Let's say driver can support both types which to choose?
Any entry that dri
On Thu, Jul 06, 2023 at 06:53:55PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 2:48 PM
>
>
> > > The driver of the owner device can send a driver notification to the
> > > member device by executing
> > VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE
>
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 2:48 PM
> > The driver of the owner device can send a driver notification to the
> > member device by executing
> VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE
> > with the \field{offset} matching \field{Queue Notify} and the
> > \field{dat
On Thu, Jul 06, 2023 at 06:16:10PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 2:06 PM
> >
> > But again even if you add it there, you can not claim it's exactly the same
> > as
> > legacy because the address is different, the address type is diffe
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 2:06 PM
>
> But again even if you add it there, you can not claim it's exactly the same as
> legacy because the address is different, the address type is different, the
> driver
> is different (this is owner driver) and even the device
On Thu, Jul 06, 2023 at 05:47:08PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 1:34 PM
> >
> > On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote:
> > >
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Thursday, July 6, 2023 12:42
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 1:34 PM
>
> On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote:
> >
> >
> > > From: Michael S. Tsirkin
> > > Sent: Thursday, July 6, 2023 12:42 PM
> > >
> > > We will need to detail how notifications work though. The reason i
On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 12:42 PM
> >
> > We will need to detail how notifications work though. The reason is that the
> > legacy notifications are received by owner driver (which is not legac
On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 12:42 PM
> >
> > We will need to detail how notifications work though. The reason is that the
> > legacy notifications are received by owner driver (which is not legac
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 12:42 PM
>
> We will need to detail how notifications work though. The reason is that the
> legacy notifications are received by owner driver (which is not legacy!) and
> forwarded to device.
> We need to explain exactly how this is don
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 12:51 PM
> I don't see a statement that devices MAY support
> VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY
> with entries returning just owner, just member, or both.
>
Ok. understood.
>From the driver notifications wording it didn't imply that
> From: Cornelia Huck
> Sent: Thursday, July 6, 2023 12:47 PM
>
> On Thu, Jul 06 2023, Parav Pandit wrote:
>
> >> From: Cornelia Huck
> >> Sent: Thursday, July 6, 2023 12:28 PM
> >>
> >> On Thu, Jul 06 2023, Parav Pandit wrote:
> >>
> >> > diff --git a/transport-pci-legacy-regs.tex
> >> >
On Thu, Jul 06, 2023 at 04:45:50PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Thursday, July 6, 2023 12:39 PM
>
> > > > +The group owner device or the group member device or both MAY
> > > > +support driver notifications region.
> > >
> > > Make this "a driver notific
On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote:
> Currently QEMU has to know some details about the back-end to be able
> to setup the guest. While various parts of the setup can be delegated
> to the backend (for example config handling) this is a very piecemeal
> approach.
> This pa
On Thu, Jul 06 2023, Parav Pandit wrote:
>> From: Cornelia Huck
>> Sent: Thursday, July 6, 2023 12:28 PM
>>
>> On Thu, Jul 06 2023, Parav Pandit wrote:
>>
>> > diff --git a/transport-pci-legacy-regs.tex
>> > b/transport-pci-legacy-regs.tex new file mode 100644 index
>> > 000..ceea28c
>> >
> From: Michael S. Tsirkin
> Sent: Thursday, July 6, 2023 12:39 PM
> > > +The group owner device or the group member device or both MAY
> > > +support driver notifications region.
> >
> > Make this "a driver notification region"?
>
> I think in fact for conformance we can just refer to suppor
On Thu, Jul 06, 2023 at 04:33:01PM +, Parav Pandit wrote:
>
>
> > From: Cornelia Huck
> > Sent: Thursday, July 6, 2023 12:28 PM
> >
> > On Thu, Jul 06 2023, Parav Pandit wrote:
> >
> > > diff --git a/transport-pci-legacy-regs.tex
> > > b/transport-pci-legacy-regs.tex new file mode 100644
On Thu, Jul 06, 2023 at 06:28:21PM +0200, Cornelia Huck wrote:
> On Thu, Jul 06 2023, Parav Pandit wrote:
>
> > diff --git a/transport-pci-legacy-regs.tex b/transport-pci-legacy-regs.tex
> > new file mode 100644
> > index 000..ceea28c
> > --- /dev/null
> > +++ b/transport-pci-legacy-regs.tex
> From: Cornelia Huck
> Sent: Thursday, July 6, 2023 12:28 PM
>
> On Thu, Jul 06 2023, Parav Pandit wrote:
>
> > diff --git a/transport-pci-legacy-regs.tex
> > b/transport-pci-legacy-regs.tex new file mode 100644 index
> > 000..ceea28c
> > --- /dev/null
> > +++ b/transport-pci-legacy-reg
Alex Bennée writes:
> Currently QEMU has to know some details about the back-end to be able
> to setup the guest. While various parts of the setup can be delegated
> to the backend (for example config handling) this is a very piecemeal
> approach.
>
> This patch suggests a new feature flag (VHO
On Thu, Jul 06 2023, Parav Pandit wrote:
> diff --git a/transport-pci-legacy-regs.tex b/transport-pci-legacy-regs.tex
> new file mode 100644
> index 000..ceea28c
> --- /dev/null
> +++ b/transport-pci-legacy-regs.tex
> @@ -0,0 +1,42 @@
> +\subsection{Legacy Interface: Group member device Confi
> From: Cornelia Huck
> Sent: Thursday, July 6, 2023 12:12 PM
> > +In some systems, there is a need to support utilizing the legacy
> > +driver with the device that do not directly support the legacy
> > +interface. In such scenarios,
>
> Please use either Michael's or my suggestion from v9 h
On Thu, Jul 06 2023, Parav Pandit wrote:
> diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex
> new file mode 100644
> index 000..dd01c0a
> --- /dev/null
> +++ b/admin-cmds-legacy-interface.tex
> @@ -0,0 +1,261 @@
> +\subsubsection{Legacy Interfaces}\label{sec:Basi
On Thu, Jul 06 2023, Parav Pandit wrote:
> Requirements are put one additional level down. Fix it.
>
> Signed-off-by: Parav Pandit
> ---
> changelog:
> v9->v10:
> - addressed comments from Cornelia
> - fixed requirements for administration virtqueue section
> v4->v5:
> - new patch
> ---
> admin
Hi Gerd Hoffmann,
Thank you for your review and suggestions.
On 2023/7/6 19:54, Gerd Hoffmann wrote:
> Hi,
>
>> +\item[VIRTIO_GPU_CMD_STATUS_FREEZING]
>> +Notify freezing status through controlq.
>> +Request data is \field{struct virtio_gpu_status_freezing}.
>> +Response type is VIRTIO_GPU_RES
Hi,
> +\item[VIRTIO_GPU_CMD_STATUS_FREEZING]
> +Notify freezing status through controlq.
> +Request data is \field{struct virtio_gpu_status_freezing}.
> +Response type is VIRTIO_GPU_RESP_OK_NODATA.
> +
> +Guest notifies QEMU if virtio-gpu is in freezing status or not in
> \field{freezing}.
> +z
Hi Alex,
Sorry for the late reply. I think this is a nice solution, specially for
the host-guest
memory management part. I was intrigued with how would you solve this, as
the v4l2 struct memory fields can't be directly used.
In that sense, sending a field that is going to be ignored by both drive
48 matches
Mail list logo
