[virtio-dev] Potential ways to describe virtio-video device capabilities

2023-09-21 Thread Alexander Gordeev
Hi, I'm working on updating virtio-video draft v8 spec [1] and the virtio-video V4L2 driver [2]. One of the things, that I don't like in the current spec draft is sharing the device's capabilities with the guest VM. The main requirement is making these capabilities compatible with V4L2. The

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/22/2023 11:08 AM, Jason Wang wrote: On Thu, Sep 21, 2023 at 12:19 PM Parav Pandit wrote: From: Jason Wang Sent: Thursday, September 21, 2023 9:39 AM On Thu, Sep 21, 2023 at 12:01 PM Parav Pandit wrote: From: Jason Wang Sent: Thursday, September 21, 2023 8:48 AM As replied in a

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Jason Wang
On Thu, Sep 21, 2023 at 6:39 PM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 3:40 PM > > > > On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > > > Vdpa stack make total sense when the underlying device is not virtio and > > hence emulat

Re: [virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-21 Thread Jason Wang
On Thu, Sep 21, 2023 at 2:28 PM Chen, Jiqian wrote: > > Hi Jason, > > On 2023/9/21 12:22, Jason Wang wrote: > > On Tue, Sep 19, 2023 at 7:43 PM Jiqian Chen wrote: > >> > >> When guest vm does S3, Qemu will reset and clear some things of virtio > >> devices, but guest can't aware that, so that may

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Jason Wang
On Thu, Sep 21, 2023 at 12:29 PM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, September 21, 2023 9:50 AM > > > Parav, I think I've clarified several times: > > > > migration using the admin command is probably fine in some use cases. > > > This is definitely, was not clear t

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Jason Wang
On Thu, Sep 21, 2023 at 12:19 PM Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Thursday, September 21, 2023 9:39 AM > > > > On Thu, Sep 21, 2023 at 12:01 PM Parav Pandit wrote: > > > > > > > > > > > > > From: Jason Wang > > > > Sent: Thursday, September 21, 2023 8:48 AM > > > > > > > A

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/21/2023 7:28 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Thursday, September 21, 2023 3:25 PM On 9/21/2023 5:26 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Thursday, September 21, 2023 2:49 PM TDISP devices can not be migrated for now, and the TDISP spec make clear example

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 12:39:31PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 5:53 PM > > > > > Again the thread has been side-tracked, which linux module does what is not > > what it was talking about. By the way I wonder who decided to dr

RE: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 21, 2023 5:53 PM > > Again the thread has been side-tracked, which linux module does what is not > what it was talking about. By the way I wonder who decided to drop virtio > comment from this and copy virtio-dev. Guys please don't do thi

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 10:39:23AM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 3:40 PM > > > > On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > > > Vdpa stack make total sense when the underlying device is not virtio and > > hen

RE: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Parav Pandit
> From: Zhu, Lingshan > Sent: Thursday, September 21, 2023 3:25 PM > > On 9/21/2023 5:26 PM, Parav Pandit wrote: > > > >> From: Zhu, Lingshan > >> Sent: Thursday, September 21, 2023 2:49 PM TDISP devices can not be > >> migrated for now, and the TDISP spec make clear examples of attacking > >>

RE: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 21, 2023 3:32 PM > > On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Thursday, September 21, 2023 1:41 PM > > > > > > I mean to say, > > > > Virtio spec has not achieved medi

RE: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 21, 2023 3:40 PM > > On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > > Vdpa stack make total sense when the underlying device is not virtio and > hence emulation. > > Which linux framework is used is kind of beside the poin

Re: [virtio-dev] [PATCH] virtio-tee: Reserve device ID 46 for TEE device

2023-09-21 Thread NK, JESHWANTHKUMAR
On 20-Sep-23 3:15 PM, Parav Pandit wrote: Hi, From: virtio-dev@lists.oasis-open.org On Behalf Of jeshwank Sent: Wednesday, September 6, 2023 3:13 PM The virtio-tee device allows guest OS to access the TEE present in host system, to perform secure operations. This patch is to reserve a devi

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > Vdpa stack make total sense when the underlying device is not virtio and > hence emulation. Which linux framework is used is kind of beside the point but since you bring this up - not necessarily. E.g. I personally don't care much a

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 1:41 PM > > > > I mean to say, > > > Virtio spec has not achieved mediation less, device migration. > > > Virtio spec has not achieved device migration using med

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/21/2023 5:26 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Thursday, September 21, 2023 2:49 PM TDISP devices can not be migrated for now, and the TDISP spec make clear examples of attacking models, your admin vq LM on the PF exactly match the model. I gave hint yesterday to you t

RE: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Parav Pandit
> From: Zhu, Lingshan > Sent: Thursday, September 21, 2023 2:49 PM > TDISP devices can not be migrated for now, and the TDISP spec make clear > examples of attacking models, your admin vq LM on the PF exactly match the > model. I gave hint yesterday to you to consult Ravi at Intel who showed T

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/20/2023 9:41 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, September 20, 2023 6:12 PM And Parav same goes for you - can you summarize Zhu Lingshan's position? Below is my summary about Zhu Lingshan's position: One line summary of his position in my view: 0. Use inb

RE: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 21, 2023 1:41 PM > > I mean to say, > > Virtio spec has not achieved mediation less, device migration. > > Virtio spec has not achieved device migration using mediation. > > But yes it has - it was implemented with shadow vq. > Shadow vq

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/21/2023 1:41 PM, Michael S. Tsirkin wrote: On Thu, Sep 21, 2023 at 03:43:12AM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Thursday, September 21, 2023 1:34 AM On Wed, Sep 20, 2023 at 05:21:52PM +, Parav Pandit wrote: OK so with this summary in mind, can you find an

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 07:53:18AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 12:51 PM > > > > > As I said, doable without mediation but already done with. > > > > > > > It is not done in the virtio spec that can work without mediation rig

RE: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, September 21, 2023 12:51 PM > > > As I said, doable without mediation but already done with. > > > > > It is not done in the virtio spec that can work without mediation right? > > have trouble parsing this sentence I mean to say, Virtio spec has no

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 06:31:01AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 11:37 AM > > > > We should be enhancing the device context so that more and more items can > > be annotated. > > > I started with small to get the design and ide