[virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-28 Thread Viresh Kumar
On 28-11-23, 20:58, Haixu Cui wrote: > On 11/27/2023 6:17 PM, Viresh Kumar wrote: > > On 24-11-23, 15:20, Haixu Cui wrote: > > > +For half-duplex read transfer, \field{rx_buf} is filled by Virtio SPI > > > device and consumed > > > +by Virtio SPI driver. For half-duplex write transfer, \field{tx_b

[virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-28 Thread Haixu Cui
Hi Viresh, Thank you for your comments and please refer to my replies below each comment. On 11/27/2023 6:17 PM, Viresh Kumar wrote: Hi Haixu, Cornelia has already covered most of the issues, I will try to add few more things I noticed. On 24-11-23, 15:20, Haixu Cui wrote: virtio-spi i

[virtio-dev] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-28 Thread Haixu Cui
Hi Huck, On 11/27/2023 10:26 PM, Cornelia Huck wrote: On Mon, Nov 27 2023, Haixu Cui wrote: On 11/24/2023 11:46 PM, Cornelia Huck wrote: On Fri, Nov 24 2023, Haixu Cui wrote: +The \field{chip_select_max_number} is the maximum number of chipselect the host SPI controller supports. "chips

[virtio-dev] Re: [virtio-comment] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-28 Thread Haixu Cui
On 11/27/2023 10:33 PM, Cornelia Huck wrote: On Mon, Nov 27 2023, Cornelia Huck wrote: On Mon, Nov 27 2023, Haixu Cui wrote: On 11/24/2023 11:46 PM, Cornelia Huck wrote: On Fri, Nov 24 2023, Haixu Cui wrote: +The \field{chip_select_max_number} is the maximum number of chipselect the