Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Haixu Cui
Hi Viresh, On 12/1/2023 1:44 PM, Viresh Kumar wrote: On 01-12-23, 13:35, Haixu Cui wrote: Hi Viresh, SPI transfer modes here may cause misunderstanding, in Wikipedia, SPI mode is the combinations of clock polarity and clock phases:

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Viresh Kumar
On 01-12-23, 13:35, Haixu Cui wrote: > Hi Viresh, > > SPI transfer modes here may cause misunderstanding, in Wikipedia, SPI > mode is the combinations of clock polarity and clock phases: > > > https://en.wikipedia.org/w/index.php?title=Serial_Peripheral_Interface=edit=4 The word 'mode' is

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Haixu Cui
On 12/1/2023 12:32 PM, Viresh Kumar wrote: On 01-12-23, 12:05, Haixu Cui wrote: Looks good. Will update as follows: \field{tx_nbits_supported} and \field{rx_nbits_supported} indicate the different n-bit transfer modes supported by the device, for writing and reading respectively. SINGLE is

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Viresh Kumar
On 01-12-23, 12:05, Haixu Cui wrote: > Looks good. Will update as follows: > > \field{tx_nbits_supported} and \field{rx_nbits_supported} indicate the > different n-bit transfer modes supported by the device, for writing and > reading respectively. SINGLE is always supported. A set bit here

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Haixu Cui
Hi Huck, On 11/30/2023 7:38 PM, Cornelia Huck wrote: On Thu, Nov 30 2023, Haixu Cui wrote: The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that allows the driver to operate and use the SPI controller under the control of the device. This patch adds the

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Haixu Cui
Hi Viresh, On 11/30/2023 7:19 PM, Viresh Kumar wrote: On 30-11-23, 17:22, Haixu Cui wrote: The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that allows the driver to operate and use the SPI controller under the control of the device. This patch adds the

Re: [virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-30 Thread Jonathon Reinhart
On Wed, Nov 29, 2023 at 5:00 AM Viresh Kumar wrote: > > On 29-11-23, 16:54, Haixu Cui wrote: > > On 11/29/2023 4:33 PM, Cornelia Huck wrote: > > > On Wed, Nov 29 2023, Haixu Cui wrote: > > > > On 11/29/2023 3:30 PM, Viresh Kumar wrote: > > > > > On 28-11-23, 20:58, Haixu Cui wrote: > > > > > >

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Cornelia Huck
On Thu, Nov 30 2023, Haixu Cui wrote: > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the device. > > This patch adds the specification for virtio-spi. > > Signed-off-by: Haixu

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Viresh Kumar
On 30-11-23, 17:22, Haixu Cui wrote: > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the device. > > This patch adds the specification for virtio-spi. > > Signed-off-by: Haixu

Re: [virtio-dev] [PATCH V6 1/2] content: Rename SPI master to SPI controller

2023-11-30 Thread Viresh Kumar
On 30-11-23, 17:22, Haixu Cui wrote: > SPI master is an outdated term and should use SPI controller. > > Signed-off-by: Haixu Cui > --- > content.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/content.tex b/content.tex > index 0a62dce..1c608eb 100644 > ---

[virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Haixu Cui
The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that allows the driver to operate and use the SPI controller under the control of the device. This patch adds the specification for virtio-spi. Signed-off-by: Haixu Cui --- device-types/spi/description.tex|

[virtio-dev] [PATCH V6 1/2] content: Rename SPI master to SPI controller

2023-11-30 Thread Haixu Cui
SPI master is an outdated term and should use SPI controller. Signed-off-by: Haixu Cui --- content.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content.tex b/content.tex index 0a62dce..1c608eb 100644 --- a/content.tex +++ b/content.tex @@ -737,7 +737,7 @@

[virtio-dev] [PATCH V6 0/2] virtio-spi: add virtual SPI controller

2023-11-30 Thread Haixu Cui
The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that allows the driver to operate and use the SPI controller under the control of the device, either a physical SPI controller, or an emulated one. Patch summary: patch 1 rename virtual SPI device name patch 2 add

[virtio-dev] Re: [virtio-comment] [PATCH v2 0/1] Define low power mode for devices

2023-11-30 Thread Michael S. Tsirkin
On Mon, Nov 13, 2023 at 03:19:49PM +0900, David Stevens wrote: > The virtio spec currently does not include the concept of device power > management. The lack means that there is no good action drivers can take > when they are requested to put the device into a low power state (e.g. > when a guest

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/1] Define a low power mode for devices

2023-11-30 Thread Michael S. Tsirkin
On Mon, Nov 13, 2023 at 03:19:50PM +0900, David Stevens wrote: > Define a low power mode for virtio devices where the devices are > expected to maintain their state. This gives drivers an option for power > management besides simply resetting their device. In the virtualization > use case, this

[virtio-dev] Re: [PATCH v2 0/1] Define low power mode for devices

2023-11-30 Thread David Stevens
On Mon, Nov 13, 2023 at 3:20 PM David Stevens wrote: > > The virtio spec currently does not include the concept of device power > management. The lack means that there is no good action drivers can take > when they are requested to put the device into a low power state (e.g. > when a guest is