[virtio-dev] Re: [PATCH v3 0/6] Add virtio-iommu built-in topology

2020-10-06 Thread Auger Eric
Hello Al, On 10/2/20 8:23 PM, Al Stone wrote: > On 24 Sep 2020 11:54, Auger Eric wrote: >> Hi, >> >> Adding Al in the loop >> >> On 9/24/20 11:38 AM, Michael S. Tsirkin wrote: >>> On Thu, Sep 24, 2020 at 11:21:29AM +0200, Joerg Roedel wrote: >>>

[virtio-dev] Re: [PATCH v3 0/6] Add virtio-iommu built-in topology

2020-09-24 Thread Auger Eric
Hi, Adding Al in the loop On 9/24/20 11:38 AM, Michael S. Tsirkin wrote: > On Thu, Sep 24, 2020 at 11:21:29AM +0200, Joerg Roedel wrote: >> On Thu, Sep 24, 2020 at 05:00:35AM -0400, Michael S. Tsirkin wrote: >>> OK so this looks good. Can you pls repost with the minor tweak >>> suggested and all

[virtio-dev] Re: [PATCH v3 0/6] Add virtio-iommu built-in topology

2020-09-04 Thread Auger Eric
Hi, On 8/21/20 3:15 PM, Jean-Philippe Brucker wrote: > Add a topology description to the virtio-iommu driver and enable x86 > platforms. > > Since [v2] we have made some progress on adding ACPI support for > virtio-iommu, which is the preferred boot method on x86. It will be a > new vendor-agnost

[virtio-dev] Re: [PATCH v3 2/6] iommu/virtio: Add topology helpers

2020-09-04 Thread Auger Eric
Hi Jean, On 8/21/20 3:15 PM, Jean-Philippe Brucker wrote: > To support topology description from ACPI and from the builtin > description, add helpers to keep track of I/O topology descriptors. > > To ease re-use of the helpers by other drivers and future ACPI > extensions, use the "virt_" prefix

[virtio-dev] Re: [PATCH v3 5/6] iommu/virtio: Support topology description in config space

2020-09-04 Thread Auger Eric
Y))) { > + pci_dbg(dev, "device doesn't have topology description"); > + goto out_reset; > + } > + > + ret = viommu_pci_find_capability(dev, VIRTIO_PCI_CAP_DEVICE_CFG, &cap); > + if (!ret) { > + pci_warn(dev, &quo

[virtio-dev] Re: [PATCH v3 4/6] iommu/virtio: Add topology definitions

2020-09-04 Thread Auger Eric
Hi Jean, On 8/21/20 3:15 PM, Jean-Philippe Brucker wrote: > Add struct definitions for describing endpoints managed by the > virtio-iommu. When VIRTIO_IOMMU_F_TOPOLOGY is offered, an array of > virtio_iommu_topo_* structures in config space describes the endpoints, > identified either by their PCI

Re: [virtio-dev] [PATCH virtio v2] virtio-iommu: Add built-in topology description

2020-09-04 Thread Auger Eric
Hi Jean, On 8/20/20 3:29 PM, Jean-Philippe Brucker wrote: > Add a simple method to describe the IOMMU topology in the config space, > guarded by a new feature bit. A list of capabilities in the config space > describes the devices managed by the IOMMU and their endpoint IDs. > > As outlined in pa

[virtio-dev] Re: [PATCH v3 1/6] iommu/virtio: Move to drivers/iommu/virtio/

2020-09-04 Thread Auger Eric
Hi Jean, On 8/21/20 3:15 PM, Jean-Philippe Brucker wrote: > Before adding new files to the virtio-iommu driver, move it to its own > subfolder, similarly to other IOMMU drivers. > > Signed-off-by: Jean-Philippe Brucker > --- > drivers/iommu/Makefile| 3 +-- > drivers/iommu/v

[virtio-dev] Re: [PATCH virtio] virtio-iommu: Add built-in topology description

2020-07-15 Thread Auger Eric
Hi Jean, On 7/9/20 5:40 PM, Jean-Philippe Brucker wrote: > Add a simple method to describe the IOMMU topology in the config space, > guarded by a new feature bit. A list of capabilities in the config space > describes the devices managed by the IOMMU and their endpoint IDs. > > As outlined in par

Re: [virtio-dev] Re: [EXT] Re: [virtio-dev] Re: [RFC PATCH] virtio-iommu: Add PAGE_SIZE_MASK property

2020-03-27 Thread Auger Eric
gt;>> Sent: Friday, March 27, 2020 2:46 PM >>> To: @mx0a-0016f401.pphosted.com >>> Cc: Auger Eric ; virtio-dev@lists.oasis-open.org >>> Subject: RE: [EXT] Re: [virtio-dev] Re: [RFC PATCH] virtio-iommu: Add >>> PAGE_SIZE_MASK property >>> >>> H

Re: [virtio-dev] Re: [RFC PATCH] virtio-iommu: Add PAGE_SIZE_MASK property

2020-03-26 Thread Auger Eric
Hi Jean, On 3/26/20 11:49 AM, Jean-Philippe Brucker wrote: > On Mon, Mar 23, 2020 at 03:22:40PM +0100, Auger Eric wrote: >> Hi Jean, >> >> On 3/23/20 2:38 PM, Jean-Philippe Brucker wrote: >>> Add a PROBE property to declare the mapping granularity per endpoint. >&

[virtio-dev] Re: [RFC PATCH] virtio-iommu: Add PAGE_SIZE_MASK property

2020-03-23 Thread Auger Eric
Hi Jean, On 3/23/20 2:38 PM, Jean-Philippe Brucker wrote: > Add a PROBE property to declare the mapping granularity per endpoint. > The virtio-iommu device already declares a granule in its config space, > but when endpoints are behind different physical IOMMUs, they may have > different mapping g

Re: [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding

2020-03-23 Thread Auger Eric
Hi jean, On 3/23/20 2:20 PM, Jean-Philippe Brucker wrote: > This reference to 'padding' is a leftover from a previous draft of the > virtio-iommu device. The field doesn't exist anymore, remove the > requirement. > > Signed-off-by: Jean-Philippe Brucker > --- > I just noticed this was still here,

[virtio-dev] Re: [PATCH v8 5/7] iommu: Add virtio-iommu driver

2019-06-14 Thread Auger Eric
Hi jean, On 5/30/19 7:09 PM, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio transport without emulating page > tables. This implementation handles ATTACH, DETACH, MAP and UNMAP > requests. > > The bulk

[virtio-dev] Re: [PATCH v8 0/7] Add virtio-iommu driver

2019-06-13 Thread Auger Eric
Hi, On 5/30/19 7:09 PM, Jean-Philippe Brucker wrote: > Implement the virtio-iommu driver, following specification v0.12 [1]. > Since last version [2] we've worked on improving the specification, > which resulted in the following changes to the interface: > * Remove the EXEC flag. > * Add feature b

Re: [virtio-dev] [PATCH v2] Add virtio-iommu device specification

2019-04-25 Thread Auger Eric
Hi, On 4/23/19 1:15 PM, Jean-Philippe Brucker wrote: > Hi, > > On 14/03/2019 15:32, Jean-Philippe Brucker wrote: >> The IOMMU device allows a guest to manage DMA mappings for physical, >> emulated and paravirtualized endpoints. Add device description for the >> virtio-iommu device and driver. Intr

Re: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-13 Thread Auger Eric
Hi Robin On 12/13/18 1:37 PM, Robin Murphy wrote: > On 2018-12-12 3:27 pm, Auger Eric wrote: >> Hi, >> >> On 12/12/18 3:56 PM, Michael S. Tsirkin wrote: >>> On Fri, Dec 07, 2018 at 06:52:31PM +, Jean-Philippe Brucker wrote: >>>> Sorry for the delay

Re: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-12 Thread Auger Eric
Hi, On 12/12/18 3:56 PM, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 06:52:31PM +, Jean-Philippe Brucker wrote: >> Sorry for the delay, I wanted to do a little more performance analysis >> before continuing. >> >> On 27/11/2018 18:10, Michael S. Tsirkin wrote: >>> On Tue, Nov 27, 2018

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-12-03 Thread Auger Eric
Hi Michael, On 11/27/18 6:16 PM, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 06:09:25PM +0100, Auger Eric wrote: >> Hi Michael, >> >> On 11/27/18 5:53 PM, Michael S. Tsirkin wrote: >>> On Thu, Nov 22, 2018 at 07:37:54PM +, Jean-Philippe Brucker wrote: &

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-11-27 Thread Auger Eric
Hi Michael, On 11/27/18 6:16 PM, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 06:09:25PM +0100, Auger Eric wrote: >> Hi Michael, >> >> On 11/27/18 5:53 PM, Michael S. Tsirkin wrote: >>> On Thu, Nov 22, 2018 at 07:37:54PM +, Jean-Philippe Brucker wrote: &

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-11-27 Thread Auger Eric
Hi Michael, On 11/27/18 5:53 PM, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2018 at 07:37:54PM +, Jean-Philippe Brucker wrote: >> Implement the virtio-iommu driver, following specification v0.9 [1]. >> >> Since v4 [2] I fixed the issues reported by Eric, and added Reviewed-by >> from Eric and

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-11-23 Thread Auger Eric
Hi Jean, On 11/22/18 8:37 PM, Jean-Philippe Brucker wrote: > Implement the virtio-iommu driver, following specification v0.9 [1]. > > Since v4 [2] I fixed the issues reported by Eric, and added Reviewed-by > from Eric and Rob. Thanks! > > I changed the specification to fix one inconsistency disc

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-23 Thread Auger Eric
Hi Jean, On 11/22/18 8:37 PM, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio transport without emulating page > tables. This implementation handles ATTACH, DETACH, MAP and UNMAP > requests. > > The bulk

Re: [virtio-dev] Re: [PATCH v4 5/7] iommu: Add virtio-iommu driver

2018-11-21 Thread Auger Eric
Hi jean, On 11/20/18 6:30 PM, Jean-Philippe Brucker wrote: > On 16/11/2018 18:46, Jean-Philippe Brucker wrote: +/* + * __viommu_sync_req - Complete all in-flight requests + * + * Wait for all added requests to complete. When this function returns, all + * requests th

[virtio-dev] Re: [PATCH v4 0/7] Add virtio-iommu driver

2018-11-16 Thread Auger Eric
Hi Jean, On 11/15/18 5:52 PM, Jean-Philippe Brucker wrote: > Implement the virtio-iommu driver, following specification v0.8 [1]. > > Changes since v3 [2]: > * Rebase onto v4.20-rc2. Patch 3 now touches drivers/of/base.c instead > of drivers/pci/of.c, since the map_rid() function has moved. > *

[virtio-dev] Re: [PATCH v4 6/7] iommu/virtio: Add probe request

2018-11-16 Thread Auger Eric
Hi Jean, On 11/15/18 5:52 PM, Jean-Philippe Brucker wrote: > When the device offers the probe feature, send a probe request for each > device managed by the IOMMU. Extract RESV_MEM information. When we > encounter a MSI doorbell region, set it up as a IOMMU_RESV_MSI region. > This will tell other

[virtio-dev] Re: [PATCH v4 7/7] iommu/virtio: Add event queue

2018-11-15 Thread Auger Eric
Hi Jean, On 11/15/18 5:52 PM, Jean-Philippe Brucker wrote: > The event queue offers a way for the device to report access faults from > endpoints. It is implemented on virtqueue #1. Whenever the host needs to > signal a fault, it fills one of the buffers offered by the guest and > interrupts it. >

[virtio-dev] Re: [PATCH v4 5/7] iommu: Add virtio-iommu driver

2018-11-15 Thread Auger Eric
Hi Jean, On 11/15/18 5:52 PM, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio transport without emulating page > tables. This implementation handles ATTACH, DETACH, MAP and UNMAP > requests. > > The bulk

[virtio-dev] Re: [RFC PATCH v2 2/5] iommu/virtio-iommu: Add probe request

2018-01-19 Thread Auger Eric
Hi Jean-Philippe, On 19/01/18 17:21, Jean-Philippe Brucker wrote: > On 16/01/18 23:26, Auger Eric wrote: > [...] >>> + switch (mem->subtype) { >>> + case VIRTIO_IOMMU_RESV_MEM_T_MSI: >>> + region = iomm

[virtio-dev] Re: [RFC PATCH v2 2/5] iommu/virtio-iommu: Add probe request

2018-01-16 Thread Auger Eric
Hi Jean-Philippe, On 17/11/17 19:52, Jean-Philippe Brucker wrote: > When the device offers the probe feature, send a probe request for each > device managed by the IOMMU. Extract RESV_MEM information. When we > encounter a MSI doorbell region, set it up as a IOMMU_RESV_MSI region. > This will tell

[virtio-dev] Re: [RFC PATCH v2 3/5] iommu/virtio-iommu: Add event queue

2018-01-16 Thread Auger Eric
Hi, On 17/11/17 19:52, Jean-Philippe Brucker wrote: > The event queue offers a way for the device to report access faults from > devices. end points? It is implemented on virtqueue #1, whenever the host needs to > signal a fault it fills one of the buffers offered by the guest and > interrupts it

[virtio-dev] Re: [RFC PATCH v2 2/5] iommu/virtio-iommu: Add probe request

2018-01-16 Thread Auger Eric
Hi Jean-Philippe, On 17/11/17 19:52, Jean-Philippe Brucker wrote: > When the device offers the probe feature, send a probe request for each > device managed by the IOMMU. Extract RESV_MEM information. When we > encounter a MSI doorbell region, set it up as a IOMMU_RESV_MSI region. > This will tell

[virtio-dev] Re: [RFC PATCH v2 1/5] iommu: Add virtio-iommu driver

2018-01-15 Thread Auger Eric
Hi Jean-Philippe, please find some comments below. On 17/11/17 19:52, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio-mmio transport without emulating > page tables. This implementation handle ATTACH, DE

Re: [virtio-dev] [RFC] virtio-iommu version 0.4

2017-10-03 Thread Auger Eric
Hi Jean, On 04/08/2017 20:19, Jean-Philippe Brucker wrote: > This is the continuation of my proposal for virtio-iommu, the para- > virtualized IOMMU. Here is a summary of the changes since last time [1]: > > * The virtio-iommu document now resembles an actual specification. It is > split into a

[virtio-dev] Re: [RFC] virtio-iommu version 0.4

2017-09-20 Thread Auger Eric
Hi Jean, On 19/09/2017 12:47, Jean-Philippe Brucker wrote: > Hi Eric, > > On 12/09/17 18:13, Auger Eric wrote: >> 2.6.7 >> - As I am currently integrating v0.4 in QEMU here are some other comments: >> At the moment struct virtio_iommu_req_probe flags is missing i

[virtio-dev] Re: [RFC] virtio-iommu version 0.4

2017-09-12 Thread Auger Eric
Hi jean, On 04/08/2017 20:19, Jean-Philippe Brucker wrote: > This is the continuation of my proposal for virtio-iommu, the para- > virtualized IOMMU. Here is a summary of the changes since last time [1]: > > * The virtio-iommu document now resembles an actual specification. It is > split into a

Re: [virtio-dev] [RFC] virtio-iommu version 0.4

2017-08-23 Thread Auger Eric
Hi Jean-Philippe, On 04/08/2017 20:19, Jean-Philippe Brucker wrote: > This is the continuation of my proposal for virtio-iommu, the para- > virtualized IOMMU. Here is a summary of the changes since last time [1]: > > * The virtio-iommu document now resembles an actual specification. It is > spl