Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread David Riddoch
tor ring. This is exactly the same sequence that needs to happen when enabling driver notifications. Yes fair enough.  I was trying to allow a device that never has to read descriptors speculatively, but such a device can always have the avail_idx update flag enabled permanently. --

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-12 Thread David Riddoch
implementations it would be nice to be able to express "I support X, and X+Y, but not Y by itself" and similar.  There is no way to do that today. -- David Riddoch -- Chief Architect, Solarflare - To unsubscrib

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-12 Thread David Riddoch
On 12/02/2019 05:08, Michael S. Tsirkin wrote: On Mon, Feb 11, 2019 at 02:58:30PM +, David Riddoch wrote: This can result in a very high rate of doorbells with some drivers, which can become a severe bottleneck (because x86 CPUs can't emit MMIOs at very high rates). Interesting. Is

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-11 Thread David Riddoch
OK then you need it in the same aligned 256 byte boundary. The event suppression structs currently require 4byte align.  Are you suggesting we increase the align required when VIRTIO_F_RING_PACKED_AVAIL_IDX is negotiated?  Sounds good to me, but 8bytes would presumably suffice. Thanks for t

[virtio-dev] Re: [virtio] RE: Re: [virtio-dev] Device-to-driver notification management for hardware implementations

2019-02-11 Thread David Riddoch
high priority: Because it is an optional feature it would not reduce complexity since a device has to be able to operate without it.  I'm not sure the benefits are worth the complexity added. David -- David Riddoch -- Chief Architect,

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-11 Thread David Riddoch
On 11/02/2019 07:33, Michael S. Tsirkin wrote: On Fri, Feb 01, 2019 at 02:23:55PM +, David Riddoch wrote: All, I'd like to propose a small extension to the packed virtqueue mode.  My proposal is to add an offset/wrap field, written by the driver, indicating how many available descri

Re: [virtio-dev] Device-to-driver notification management for hardware implementations

2019-02-01 Thread David Riddoch
ential for performance, and it doesn't reduce complexity in the design if optional, as we still have to operate without it. I have however, found another problem that is much more important to solve...see next email. Best, David -- David Riddoch -- Chief Archit

[virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-01 Thread David Riddoch
a patch to the spec is there still time to get this into v1.1? Best, David -- David Riddoch -- Chief Architect, Solarflare - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mai

Re: [virtio-dev] Device-to-driver notification management for hardware implementations

2018-11-08 Thread David Riddoch
On 05/11/18 08:53, Stefan Hajnoczi wrote: On Wed, Sep 12, 2018 at 05:41:07PM +0100, David Riddoch wrote: The VIRTIO_F_NOTIFICATION_DATA feature helps hardware implementations by telling them directly how many descriptors are available in the ring, saving speculative reads.  There is a related

[virtio-dev] Device-to-driver notification management for hardware implementations

2018-09-12 Thread David Riddoch
All, The VIRTIO_F_NOTIFICATION_DATA feature helps hardware implementations by telling them directly how many descriptors are available in the ring, saving speculative reads.  There is a related issue with interrupts: As things stand, after writing 'used' descriptors into the ring (packed or s

Re: [virtio-dev] [PATCH v11] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-09-12 Thread David Riddoch
_DATA(36)] This feature indicates + that drivers pass extra data (besides identifying the Virtqueue) + in their device notifications. + See \ref{sec:Virtqueues / Driver notifications}~\nameref{sec:Virtqueues / Driver notifications}. \end{description} \drivernormative{\section}{Reserved F