[virtio-dev] Re: [PATCH v13 00/10] Introduce device group and device management

2023-05-10 Thread Jiri Pirko
Wed, May 10, 2023 at 04:33:52PM CEST, pa...@nvidia.com wrote: > >> From: Jiri Pirko >> Sent: Wednesday, May 10, 2023 10:30 AM > >> >> Michael, not sure if it is problem of this patchset or on my side but makepdf >> fails to build this. With master bra

[virtio-dev] Re: [PATCH v13 00/10] Introduce device group and device management

2023-05-10 Thread Jiri Pirko
Fri, May 05, 2023 at 05:40:33PM CEST, m...@redhat.com wrote: > > > >Change log: > >since 13: > command specific data is u8 again > exclude admin queues in blk's num_queues > minor other tweaks > >since 11: > addressed lots of comments, all minor. consistency with >

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: Fix virtqueues spelling error

2023-03-13 Thread Jiri Pirko
Fri, Mar 10, 2023 at 04:05:19PM CET, pa...@nvidia.com wrote: >Correct spelling from virtqueus to virtqueues. > >Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko - To unsubscribe, e-mail: virtio-dev-unsubscr...@li

[virtio-dev] Re: [virtio-comment] [PATCH] transport-pci: Remove duplicate word structure

2023-03-13 Thread Jiri Pirko
Fri, Mar 10, 2023 at 04:06:20PM CET, pa...@nvidia.com wrote: >Remove duplicate word structure. > >Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Jiri Pirko
Thu, Mar 09, 2023 at 01:36:00PM CET, pa...@nvidia.com wrote: > > >> From: Jiri Pirko >> Sent: Thursday, March 9, 2023 2:37 AM > > >> >We want the ability to program/provision the virtio feature bits and virtio >> config space parameters of the VF through P

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 10:45:18PM CET, pa...@nvidia.com wrote: > >> From: Jiri Pirko >> Sent: Wednesday, March 8, 2023 5:05 AM > >> >For example a common feature is to program a vlan and have device put a >> >given VF inside this vlan. >> >> I don't

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 10:25:32PM CET, pa...@nvidia.com wrote: > >> From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of David Edmondson > >> In support of live migration, might we end up moving large amounts of device >> state through the admin queue? >> >Correct. > >> If so, that

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 10:09:22PM CET, m...@redhat.com wrote: >On Wed, Mar 08, 2023 at 10:58:59PM +0200, Max Gurtovoy wrote: >> We have a non-spec prototypes for LM so please use our experience in this >> area. > >Don't see what the fuss is about. Nothing will prevent your device from >using a

[virtio-dev] Re: [virtio] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 05:30:21PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 06:52:03PM +, Parav Pandit wrote: >> > And I wonder whether it's worth it - it definitely makes contributing to >> > Linux >> > harder, and even within Linux it pushes contributors away. >> The number of

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 07:01:02PM CET, david.edmond...@oracle.com wrote: >Max Gurtovoy writes: > >> On 08/03/2023 14:08, Jiri Pirko wrote: >>> Wed, Mar 08, 2023 at 12:50:48PM CET, m...@redhat.com wrote: >>>> On Wed, Mar 08, 2023 at 11:05:00AM +0100, Jiri Pirko wro

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 05:30:48PM CET, coh...@redhat.com wrote: >On Mon, Mar 06 2023, "Michael S. Tsirkin" wrote: > >> On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: >>> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: >>> >>&g

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 02:44:08PM CET, david.edmond...@oracle.com wrote: >Jiri Pirko writes: > >> Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmond...@oracle.com wrote: >>>"Michael S. Tsirkin" writes: >>> >>>> On Tue, Mar 07, 2023 at 11:04

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmond...@oracle.com wrote: >"Michael S. Tsirkin" writes: > >> On Tue, Mar 07, 2023 at 11:04:33AM +, David Edmondson wrote: >>> "Michael S. Tsirkin" writes: >>> > +The driver MAY block use of VIRTIO_ADMIN_CMD_LIST_QUERY and >>> >

[virtio-dev] Re: [virtio] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 01:44:18PM CET, stefa...@redhat.com wrote: >On Wed, Mar 08, 2023 at 11:17:35AM +0100, Jiri Pirko wrote: >> Tue, Mar 07, 2023 at 08:03:47PM CET, stefa...@redhat.com wrote: >> >On Tue, Mar 07, 2023 at 04:07:54PM +0100, Jiri Pirko wrote: >> >> Tue,

Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 12:54:52PM CET, m...@redhat.com wrote: >On Mon, Mar 06, 2023 at 01:22:30PM +0100, Jiri Pirko wrote: >> Thu, Mar 02, 2023 at 02:05:22PM CET, m...@redhat.com wrote: >> >Add commands to find out which commands does each group support, >> >as well as

Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery

2023-03-08 Thread Jiri Pirko
Thu, Mar 02, 2023 at 02:05:22PM CET, m...@redhat.com wrote: >Add commands to find out which commands does each group support, >as well as enable their use by driver. >This will be especially useful once we have multiple group types. > >An alternative is per-type VQs. This is possible but will

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Wed, Mar 08, 2023 at 12:50:48PM CET, m...@redhat.com wrote: >On Wed, Mar 08, 2023 at 11:05:00AM +0100, Jiri Pirko wrote: >> Tue, Mar 07, 2023 at 05:30:18PM CET, m...@redhat.com wrote: >> >On Tue, Mar 07, 2023 at 08:36:41AM +0100, Jiri Pirko wrote: >> >> Hmm, if no

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 08:03:47PM CET, stefa...@redhat.com wrote: >On Tue, Mar 07, 2023 at 04:07:54PM +0100, Jiri Pirko wrote: >> Tue, Mar 07, 2023 at 03:39:11PM CET, stefa...@redhat.com wrote: >> >On Tue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: >> >> Mon,

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 05:13:01PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: >> I sense there is no concete idea about what the "admin virtqueue" should >> serve for exactly. > >Because the virtqueue is just a virtqueue -

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 05:30:18PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 08:36:41AM +0100, Jiri Pirko wrote: >> Hmm, if not for now, the future exension would not be so simple, I fear. > >Without knowing what it is I can't say. Yep, so basically you say, f

[virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Jiri Pirko
Tue, Mar 07, 2023 at 06:20:03PM CET, m...@redhat.com wrote: >On Tue, Mar 07, 2023 at 08:21:54AM +0100, Jiri Pirko wrote: >> Mon, Mar 06, 2023 at 11:54:45PM CET, m...@redhat.com wrote: >> >On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: >> >> Thu, Mar

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-07 Thread Jiri Pirko
Tue, Mar 07, 2023 at 03:39:11PM CET, stefa...@redhat.com wrote: >On Tue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: >> Mon, Mar 06, 2023 at 07:37:31PM CET, m...@redhat.com wrote: >> >On Mon, Mar 06, 2023 at 06:03:40AM -0500, Stefan Hajnoczi wrote: >> >> On S

Re: [virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-07 Thread Jiri Pirko
Fri, Mar 03, 2023 at 09:23:14PM CET, stefa...@redhat.com wrote: >On Fri, Mar 03, 2023 at 08:18:43AM -0500, Michael S. Tsirkin wrote: >> On Fri, Mar 03, 2023 at 08:13:37AM -0500, Stefan Hajnoczi wrote: >> > On Thu, Mar 02, 2023 at 06:57:24PM -0500, Michael S. Tsirkin wrote: >> > > On Thu, Mar 02,

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-07 Thread Jiri Pirko
Mon, Mar 06, 2023 at 07:37:31PM CET, m...@redhat.com wrote: >On Mon, Mar 06, 2023 at 06:03:40AM -0500, Stefan Hajnoczi wrote: >> On Sun, Mar 05, 2023 at 07:18:24PM -0500, Michael S. Tsirkin wrote: >> > On Sun, Mar 05, 2023 at 07:03:02PM -0500, Stefan Hajnoczi wrote: >> > > On Sun, Mar 05, 2023 at

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Jiri Pirko
Mon, Mar 06, 2023 at 04:14:09PM CET, mgurto...@nvidia.com wrote: > > >On 03/03/2023 2:05, Michael S. Tsirkin wrote: >> On Thu, Mar 02, 2023 at 03:40:07PM -0500, Stefan Hajnoczi wrote: >> > On Thu, Mar 02, 2023 at 08:05:06AM -0500, Michael S. Tsirkin wrote: >> > > The admin virtqueues will be the

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-06 Thread Jiri Pirko
Mon, Mar 06, 2023 at 07:46:09PM CET, m...@redhat.com wrote: >On Mon, Mar 06, 2023 at 11:35:15AM +0100, Jiri Pirko wrote: >> Well, lots of these things (if not majority) are customary, not >> really written up anywhere in Linux kernel netdev world. It's most of >> t

[virtio-dev] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Jiri Pirko
Mon, Mar 06, 2023 at 07:40:38PM CET, m...@redhat.com wrote: >On Mon, Mar 06, 2023 at 01:41:30PM +0100, Jiri Pirko wrote: >> Thu, Mar 02, 2023 at 02:05:06PM CET, m...@redhat.com wrote: >> >The admin virtqueues will be the first interface to issue admin commands. >>

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-06 Thread Jiri Pirko
Mon, Mar 06, 2023 at 11:54:45PM CET, m...@redhat.com wrote: >On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: >> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: >> >> [...] >> >> > >> >TODO (maybe?) - probably ok to defer until

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-06 Thread Jiri Pirko
Mon, Mar 06, 2023 at 11:48:32PM CET, m...@redhat.com wrote: >On Mon, Mar 06, 2023 at 05:40:04PM +0100, Jiri Pirko wrote: >> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: >> >> [...] >> >> >> > admin: introduce device group and rel

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-06 Thread Jiri Pirko
Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: [...] > admin: introduce device group and related concepts > admin: introduce group administration commands > admin: introduce virtio admin virtqueues The ordering seems a bit odd to me. I think that at the beginning, the admin

[virtio-dev] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Jiri Pirko
Mon, Mar 06, 2023 at 08:58:12AM CET, jasow...@redhat.com wrote: > >在 2023/3/3 08:05, Michael S. Tsirkin 写道: >> On Thu, Mar 02, 2023 at 03:40:07PM -0500, Stefan Hajnoczi wrote: >> > On Thu, Mar 02, 2023 at 08:05:06AM -0500, Michael S. Tsirkin wrote: >> > > The admin virtqueues will be the first

[virtio-dev] Re: [virtio] [PATCH v10 03/10] admin: introduce group administration commands

2023-03-06 Thread Jiri Pirko
Thu, Mar 02, 2023 at 02:05:02PM CET, m...@redhat.com wrote: >This introduces a general structure for group administration commands, >used to control device groups through their owner. > >Following patches will introduce specific commands and an interface for >submitting these commands to the

[virtio-dev] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Jiri Pirko
Thu, Mar 02, 2023 at 02:05:06PM CET, m...@redhat.com wrote: >The admin virtqueues will be the first interface to issue admin commands. > >Currently virtio specification defines control virtqueue to manipulate >features and configuration of the device it operates on. However, >control virtqueue

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-06 Thread Jiri Pirko
Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: [...] > >TODO (maybe?) - probably ok to defer until this part is upstream: > > Add "all members" member id. > > Add commands for MSI, feature discovery. > > Add commands for transport vq. > > >My intent is to try and

Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery

2023-03-06 Thread Jiri Pirko
Thu, Mar 02, 2023 at 02:05:22PM CET, m...@redhat.com wrote: >Add commands to find out which commands does each group support, >as well as enable their use by driver. >This will be especially useful once we have multiple group types. > >An alternative is per-type VQs. This is possible but will

[virtio-dev] Re: [virtio] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-06 Thread Jiri Pirko
Fri, Mar 03, 2023 at 09:34:14AM CET, m...@redhat.com wrote: >On Thu, Mar 02, 2023 at 06:40:55PM +, Parav Pandit wrote: >> Did you miss reviewed-by from [1] or this is an old series reposted? >> [1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00242.html > >As a general rule, we

Re: [virtio-dev] [PATCH 3/3] transport-mmio: Refer to the vq by its number

2023-02-24 Thread Jiri Pirko
chives/virtio-dev/202302/msg00527.html > >Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 >Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.or

Re: [virtio-dev] [PATCH 2/3] transport-mmio: Rename QueueNum register

2023-02-24 Thread Jiri Pirko
eueNumMax and QueueNum >registers to QueueSizeMax and QueueSize respectively. > >[1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00527.html > >Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 >Si

Re: [virtio-dev] [PATCH 1/3] transport-pci: Refer to the vq by its number

2023-02-24 Thread Jiri Pirko
chives/virtio-dev/202302/msg00527.html > >Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 >Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.or