[virtio-dev] Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-05-29 Thread Rob Miller
why there is a qemu option? Rob Miller rob.mil...@broadcom.com (919)721-3339 On Fri, May 29, 2020 at 4:03 AM Jason Wang wrote: > Currently the doorbell is relayed via eventfd which may have > significant overhead because of the cost of vmexits or syscall. This > patch introduces mm

Re: [virtio-dev] Dirty Page Tracking (DPT)

2020-04-13 Thread Rob Miller
On Mon, Apr 13, 2020 at 8:16 AM Eugenio Perez Martin wrote: > On Fri, Apr 10, 2020 at 4:40 AM Jason Wang wrote: > > > > > > On 2020/4/10 上午5:06, Michael S. Tsirkin wrote: > > > On Tue, Apr 07, 2020 at 11:52:46AM +0200, Eugenio Perez Martin wrote: > > >> Hi! > > >> > > >> So, from the previous ma

Re: [virtio-dev] Dirty Page Tracking (DPT)

2020-04-07 Thread Rob Miller
another question on vDPA vs vendor specific driver portion... Are the subsystem vendor & device IDs to be different from the primary (Red Hat) versions as there has to be a way for a vendor specific driver to "see" its device. Rob Miller rob.mil...@broadcom.com (919)721-3339

Re: [virtio-dev] Dirty Page Tracking (DPT)

2020-04-07 Thread Rob Miller
Does this mean that SW takes over the datapath during LM? If so, is there any infrastructure to "gracefully" do a hand-off from HW mode (pci device is managing the rings) to SW mode, in that when switching from HW->SW, HW is stalled & quiesced, then the SW takes from where HW left

Re: [virtio-dev] Dirty Page Tracking (DPT)

2020-03-18 Thread Rob Miller
these users in ram_list because dirty memory tracking can be enabled or disabled independently for each of these users. http://blog.vmsplice.net/2016/01/qemu-internals-how-guest-physical-ram.html Rob Miller rob.mil...@broadcom.com (919)721-3339 On Tue, Mar 10, 2020 at 2:39 AM Jason Wang wrote: &

[virtio-dev] Dirty Page Tracking (DPT)

2020-03-06 Thread Rob Miller
ng (from byte->bit) or have the capability to handle the granularity diffs. Thoughts? Rob Miller rob.mil...@broadcom.com (919)721-3339

Re: [virtio-dev] [PATCH v4 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-03 Thread Rob Miller
Given that this new feature clarifies RSS, should the existing references to RSS be updated in the spec to have RSS replaced with RFS (aka Receive Flow Steering)? Rob Miller rob.mil...@broadcom.com (919)721-3339 On Mon, Mar 2, 2020 at 6:52 AM Yuri Benditovich wrote: > RSS (Receive-s

Re: [virtio-dev] [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-03 Thread Rob Miller
OK my bad, missed the update to the working copy of the spec. Rob Miller rob.mil...@broadcom.com (919)721-3339 On Mon, Mar 2, 2020 at 8:04 AM Yuri Benditovich wrote: > On Mon, Mar 2, 2020 at 2:17 PM Rob Miller wrote: > > > > I think it would be good to have a means to negoti

Re: [virtio-dev] [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-02 Thread Rob Miller
a failure. Also, what is the definitions of the xxx_EX options? Rob Miller rob.mil...@broadcom.com (919)721-3339 On Sun, Mar 1, 2020 at 9:33 AM Yuri Benditovich wrote: > RSS (Receive-side scaling) defines hash calculation > rules and decision on receive virtqueue according to > the c

Re: [virtio-dev] [PATCH v3 1/3] virtio-net: Introduce extended RSC feature

2020-03-02 Thread Rob Miller
Can we add some words about the new fields in the virtio_net_hdr structure, such as SHOULD, MUST,... Also, should the virtio_net_hdr be bumped to v2? Rob Miller rob.mil...@broadcom.com (919)721-3339 On Sun, Mar 1, 2020 at 9:33 AM Yuri Benditovich wrote: > VIRTIO_NET_F_RSC_EXT feature

Re: [virtio-dev] [PATCH] split-ring: Demand that a device must not change descriptor entries

2020-03-02 Thread Rob Miller
In reviewing my comments, I agree that I misunderstood what was being requested. Please ignore my comments and continue as needed. Rob Miller rob.mil...@broadcom.com (919)721-3339 On Thu, Feb 27, 2020 at 5:05 AM Michael S. Tsirkin wrote: > On Mon, Nov 11, 2019 at 06:26:58PM +0100, Jan Kis

Re: [virtio-dev] [PATCH] split-ring: Demand that a device must not change descriptor entries

2019-11-11 Thread Rob Miller
what is trying to be solved here? There is a reason why this is allowed as some vendors update the table when using RX_MERABLE_BUFFERs & F_IN_ORDER features Rob Miller rob.mil...@broadcom.com (919)721-3339 On Mon, Nov 11, 2019 at 12:13 PM Jan Kiszka wrote: > From: Jan Kiszka > &g

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-22 Thread Rob Miller
I don’t know enough about how they get named, but is it possible for user space to suggest its interface name, such that the interface name would we as unique as the VM name itself. and is limited to scope to be within the network boundry of an organization? In other words, as a company, i decided

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-12 Thread Rob Miller
On Tue, Feb 12, 2019 at 1:55 PM Michael S. Tsirkin wrote: > On Fri, Feb 01, 2019 at 09:43:02AM -0800, Rob Miller wrote: > > Agreed that this is needed. > > > > I would also like to suggest splitting the F_IN_ORDER into > > F_RX_IN_ORDER and F_TX_IN_ORDER to sup

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-01 Thread Rob Miller
Agreed that this is needed. I would also like to suggest splitting the F_IN_ORDER into F_RX_IN_ORDER and F_TX_IN_ORDER to support hw LRO implementations, which can be more of a scatter/gather than tx. This would allow batchmode for tx at least in packed rings. Finally, i would suggest a means to