On Mon, Dec 10, 2018 at 7:46 PM Michael S. Tsirkin wrote:
>
> On Mon, Dec 10, 2018 at 05:34:53PM +0200, Sameeh Jubran wrote:
> > On Mon, Dec 10, 2018 at 5:13 PM Sameeh Jubran wrote:
> > >
> > > On Sat, Dec 8, 2018 at 3:54 AM si-wei liu wrote:
> > > >
&
On Mon, Dec 10, 2018 at 5:13 PM Sameeh Jubran wrote:
>
> On Sat, Dec 8, 2018 at 3:54 AM si-wei liu wrote:
> >
> >
> >
> > On 12/05/2018 08:18 AM, Sameeh Jubran wrote:
> > > Hi all,
> > >
> > > This is a followup on the discussion in the DP
On Sat, Dec 8, 2018 at 3:54 AM si-wei liu wrote:
>
>
>
> On 12/05/2018 08:18 AM, Sameeh Jubran wrote:
> > Hi all,
> >
> > This is a followup on the discussion in the DPDK and Virtio monthly meeting.
> >
> > Michael suggested that layer 2 tests should
intel that implemented
> > > the guest changes after all, so I expect he's motivated to make them
> > > work well.
> > >
> > >
> > > > >Let's
> > > > > assume drivers are fixed to do that. How does userspace know
>
On Mon, Nov 26, 2018 at 10:22 PM Samudrala, Sridhar
wrote:
>
> On 11/26/2018 7:43 AM, Sameeh Jubran wrote:
> > On Mon, Nov 26, 2018 at 5:13 PM Sameeh Jubran wrote:
> >> On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote:
> >>> On Wed, Nov 21, 2018 at 10:0
On Mon, Nov 26, 2018 at 5:13 PM Sameeh Jubran wrote:
>
> On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote:
> >
> > On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote:
> > > On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin
> > > wro
On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote:
>
> On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote:
> > On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote:
> > >
> > > Great to see you making progress on this!
> > > Some com
On Thu, Nov 22, 2018 at 1:51 AM Samudrala, Sridhar
wrote:
>
> On 11/21/2018 12:04 PM, Sameeh Jubran wrote:
> > On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote:
> >> Great to see you making progress on this!
> >> Some comments below:
> >>
> &
On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote:
>
> Great to see you making progress on this!
> Some comments below:
>
> On Wed, Nov 21, 2018 at 05:39:38PM +0200, Sameeh Jubran wrote:
> > I have created a setup which has two hosts (host A and host B) with X710 10
> I think MAC matching removes downtime when device is removed but not
> > > when it's re-added, yes. It has the advantage of an already present
> > > linux driver support, but if you are prepared to work on
> > > adding e.g. bridge based matching, that will go away.
> >
> > The removal order and consequence will be the same between MAC
> > matching and group ID based matching. It's just the initial discovery
> > that's slightly different. Why do you think the downtime will be
> > different for the removal scenario? And why do you think it's needed
> > to alter the current PF driver behavior to support bridge based
> > matching? Sorry I'm really confused about your suggestion. Those PF
> > driver model changes are not needed acutally. The fact is that the
> > bridge based matching is supposed to work quite well for any PF driver
> > implementation no matter when the MAC address filters gets added or
> > enabled.
> >
> > Thanks,
> > -Siwei
>
> It seems that it requires a bunch of changes for all VF drivers
> though.
>
> >
> > >
> > >
> > > > >
> > > > > --
> > > > > MST
> > > > >
> > > > >
> -
> > > > > To unsubscribe, e-mail:
> virtio-dev-unsubscr...@lists.oasis-open.org
> > > > > For additional commands, e-mail:
> virtio-dev-h...@lists.oasis-open.org
> > > > >
>
> -
> To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
>
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*
e of
unplug/plug requests to the guest.
Please share your thoughts on this approach versus the draft implementation.
_________
commit 06afc24a613b2cb31c064859e89b709ec54fecdc (HEAD -> failover)
Author
ate of the
primary device in order to implement the migration feature.
Please share your thoughts and insights
commit 39a350ee65a26ab6ede4c08b3ca3b9e945fcf305 (HEAD -> failover)
Author: Sameeh Jubran
Date: Sun Sep 16 13:21:41 2018 +0300
virtio-net: Implement standby feature
Signed-o
On Thu, Sep 27, 2018 at 8:25 PM Samudrala, Sridhar
wrote:
>
>
> On 9/27/2018 9:17 AM, Michael S. Tsirkin wrote:
> > On Thu, Sep 27, 2018 at 10:17:37AM +0300, Sameeh Jubran wrote:
> >> What do you think about the following alternative implementation which
>
es not need to care about it.
> >> >
> >> >>
> >> >> The thing is the current MAC based implementation has intrinsic flaw
> >> >> that doesn't propagate errors to hypervisor, or there's no back
> >> >> chan
On Tue, Sep 18, 2018 at 4:25 PM Michael S. Tsirkin wrote:
>
> On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote:
> > On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote:
> > >
> > > On Wed, 12 Sep 2018 11:22:12 -0400
> > > "Michael S. T
ut adding unnecessary ids to the bridges.
The mac address approach seems to be very complicated as there is no
standard way to find the mac address of a given device and it is
vendor dependent,
which makes the task of identifying the target standby device by it's
mac address a very tough one.
From: Sameeh Jubran
Difference from v4:
* Added hash offload feature bit. This separates the hash offload from the
steering mode feature as was suggested by Michael.
Sameeh Jubran (4):
content: net: Add VIRTIO_NET_F_CTRL_STEERING_MODE feature
conformance: net: Add steering mode
content
From: Sameeh Jubran
This commit introduces the RSS feature into virtio-net. It is introduced
as a sub mode for a general command which configures the steering mode.
Most modern high end network devices today support configurable hash functions,
this commit introduces RSS - Receive Side Scaling
From: Sameeh Jubran
This commit introduces hash offload support into network device. The device
calculates hashes for packets all the time and especially when it uses
multiqueue, these hash values can be very useful for the driver and OS in some
cases.
This feature allows the delivery of the
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
conformance.tex | 1 +
1 file changed, 1 insertion(+)
diff --git a/conformance.tex b/conformance.tex
index f59e360..f68911d 100644
--- a/conformance.tex
+++ b/conformance.tex
@@ -97,6 +97,7 @@ A network driver MUST conform to the following
From: Sameeh Jubran
This commit introduces steering mode into network device. Steering
mode is a general infrastructure for various steering modes that can
be implemented on top of it such as Automatic and RSS.
Signed-off-by: Sameeh Jubran
---
content.tex | 57
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
conformance.tex | 1 +
1 file changed, 1 insertion(+)
diff --git a/conformance.tex b/conformance.tex
index f59e360..f68911d 100644
--- a/conformance.tex
+++ b/conformance.tex
@@ -97,6 +97,7 @@ A network driver MUST conform to the following
From: Sameeh Jubran
Difference from v3:
* Added steering mode to conformance
* Replaced should with SHOULD
* Rephrased few lines based on Vijayabhaskar's suggestions
Sameeh Jubran (3):
content: net: Add VIRTIO_NET_F_CTRL_STEERING_MODE feature
conformance: net: Add steering mode
co
From: Sameeh Jubran
This commit introduces the RSS feature into virtio-net. It is introduced
as a sub mode for a general command which configures the steering mode.
Most modern high end network devices today support configurable hash functions,
this commit introduces RSS - Receive Side Scaling
From: Sameeh Jubran
This commit introduces steering mode into network device. Steering
mode is a general infrastructure for various steering modes that can
be implemented on top of it such as Automatic and RSS.
Signed-off-by: Sameeh Jubran
---
content.tex | 61
On Sat, Apr 28, 2018 at 1:09 AM, Vijayabhaskar Balakrishna <
vijay.balakris...@oracle.com> wrote:
> Hi Sameeh,
>
> See inline..
>
> Thanks,
> Vijay
>
> On 4/18/2018 3:46 AM, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
>> This commi
On Fri, Apr 27, 2018 at 9:17 PM, Vijayabhaskar Balakrishna <
vijay.balakris...@oracle.com> wrote:
> Hi Sameeh,
>
> See inline..
>
> On 4/18/2018 3:46 AM, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
>> This commit introduces steering mode into net
ping
On Wed, Apr 18, 2018 at 1:46 PM, Sameeh Jubran wrote:
> From: Sameeh Jubran
>
> Please ignore the feature number value (60) in the patch, it is not final
> for now.
>
> Difference from v2:
>
> * Dropped RSS_HASH_FUNCTION_NONE flag from RSS as it seems to be
>
From: Sameeh Jubran
This commit introduces the RSS feature into virtio-net. It is introduced
as a sub mode for a general command which configures the steering mode.
Most modern high end network devices today support configurable hash functions,
this commit introduces RSS - Receive Side Scaling
From: Sameeh Jubran
This commit introduces steering mode into network device. Steering
mode is a general infrastructure for various steering modes that can
be implemented on top of it such as Automatic and RSS.
Signed-off-by: Sameeh Jubran
---
content.tex | 61
From: Sameeh Jubran
Please ignore the feature number value (60) in the patch, it is not final for
now.
Difference from v2:
* Dropped RSS_HASH_FUNCTION_NONE flag from RSS as it seems to be
useless.
* Added more comments to the code.
* Beautifications.
* Fixed some sentences to make them
On Tue, Apr 17, 2018 at 5:14 PM, Michael S. Tsirkin wrote:
> On Tue, Apr 17, 2018 at 02:50:15PM +0300, Sameeh Jubran wrote:
> >
> >
> > On Tue, Apr 17, 2018 at 4:50 AM, Michael S. Tsirkin
> wrote:
> >
> > On Mon, Apr 16, 2018 at 04:05:26PM +0300, Sameeh
On Tue, Apr 17, 2018 at 4:50 AM, Michael S. Tsirkin wrote:
> On Mon, Apr 16, 2018 at 04:05:26PM +0300, Sameeh Jubran wrote:
> > From: Sameeh Jubran
> >
> > This commit introduces the RSS feature into virtio-net. It is introduced
> > as a sub mode for a general c
On Tue, Apr 17, 2018 at 4:30 AM, Vijayabhaskar Balakrishna <
vijay.balakris...@oracle.com> wrote:
>
>
> On 4/16/2018 6:05 AM, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
>> This commit introduces the RSS feature into virtio-net. It is introduced
>>
On Tue, Apr 17, 2018 at 4:30 AM, Vijayabhaskar Balakrishna <
vijay.balakris...@oracle.com> wrote:
> On 4/16/2018 6:05 AM, Sameeh Jubran wrote:
>
> From: Sameeh Jubran
>>
>> This commit introduces steering mode into network device. Steering
>> mode is a general in
On Tue, Apr 17, 2018 at 1:43 PM, Sameeh Jubran wrote:
>
>
> On Tue, Apr 17, 2018 at 2:05 AM, Michael S. Tsirkin
> wrote:
>
>> On Mon, Apr 16, 2018 at 04:05:25PM +0300, Sameeh Jubran wrote:
>> > From: Sameeh Jubran
>> >
>> > This commit introd
On Tue, Apr 17, 2018 at 2:05 AM, Michael S. Tsirkin wrote:
> On Mon, Apr 16, 2018 at 04:05:25PM +0300, Sameeh Jubran wrote:
> > From: Sameeh Jubran
> >
> > This commit introduces steering mode into network device. Steering
> > mode is a general infrastructure for vari
From: Sameeh Jubran
This commit introduces steering mode into network device. Steering
mode is a general infrastructure for various steering modes that can
be implemented on top of it such as Automatic and RSS.
Signed-off-by: Sameeh Jubran
---
content.tex | 59
From: Sameeh Jubran
This commit introduces the RSS feature into virtio-net. It is introduced
as a sub mode for a general command which configures the steering mode.
Most modern high end network devices today support configurable hash functions,
this commit introduces RSS - Receive Side Scaling
From: Sameeh Jubran
Hi all,
This patch series introduces an infrastructure into virtio-net for
adding steering modes while introducing RSS as one.
Please take a look and share your thoughts.
Difference from v1:
* generic steering mode introduced and RSS is defined as part of the steering
On Tue, Mar 20, 2018 at 5:10 AM, Jason Wang wrote:
>
>
> On 2018年03月19日 21:33, Sameeh Jubran wrote:
>
>>
>>
>> On Thu, Mar 15, 2018 at 4:19 AM, Jason Wang > jasow...@redhat.com>> wrote:
>>
>>
>>
>> On 2018年01月26
On Tue, Mar 20, 2018 at 12:29 AM, Vijayabhaskar Balakrishna <
vijay.balakris...@oracle.com> wrote:
> On 3/19/2018 6:33 AM, Sameeh Jubran wrote:
>
>
>
> On Thu, Mar 15, 2018 at 4:19 AM, Jason Wang wrote:
>
>>
>>
>> On 2018年01月26日 00:27, Samee
On Thu, Mar 15, 2018 at 4:19 AM, Jason Wang wrote:
>
>
> On 2018年01月26日 00:27, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
>> Most modern high end network devices today support configurable hash
>> functions,
>> this commit introduces RSS
ping
On Thu, Jan 25, 2018 at 6:53 PM, Sameeh Jubran wrote:
> Please ignore the typos, I mistakenly sent the patch without the fixes.
> I'll resend the fixes along with v2.
>
> On Thu, Jan 25, 2018 at 6:27 PM, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
Please ignore the typos, I mistakenly sent the patch without the fixes.
I'll resend the fixes along with v2.
On Thu, Jan 25, 2018 at 6:27 PM, Sameeh Jubran wrote:
> From: Sameeh Jubran
>
> Most modern high end network devices today support configurable hash
> functio
From: Sameeh Jubran
Most modern high end network devices today support configurable hash functions,
this commit introduces RSS - Receive Side Scaling - [1] to virtio net device.
The RSS is a technology from Microsoft that boosts network device performance
by efficiently distributing the traffic
From: Sameeh Jubran
Hi all,
Most modern high end network devices today support configurable hash functions,
the following commit introduces RSS - Receive Side Scaling - [1] into virtio net
device. RSS is a technology developed by Microsoft that boosts network device
performance by efficiently
From: sameehj
The flag VIRTIO_NET_HDR_F_DATA_VALID is aleady mentioned in the virtio-net
spec however it is not defined in the struct. This flag is already defined
and used in virtio-net device in Qemu as well as some of it's drivers.
---
content.tex | 1 +
1 file changed, 1 insertion(+)
diff
48 matches
Mail list logo
