Re: Using packed virtqueues in Confidential VMs

2023-11-20 Thread Stefan Hajnoczi
On Mon, Nov 20, 2023 at 10:13:15AM +, Reshetova, Elena wrote: > Hi Stefan, > > Thank you for following up on this! Please find my comments inline. > > > -Original Message- > > From: Stefan Hajnoczi > > Sent: Thursday, November 16, 2023 10:03 PM &g

[virtio-dev] Using packed virtqueues in Confidential VMs

2023-11-16 Thread Stefan Hajnoczi
Hi Elena, You raised concerns about using packed virtqueues with untrusted devices at Linux Plumbers Conference. I reviewed the specification and did not find fundamental issues that would preclude the use of packed virtqueues in untrusted devices. Do you have more information about issues with pac

[virtio-dev] Re: [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

2023-09-08 Thread Stefan Hajnoczi
On Fri, Sep 08, 2023 at 01:03:26PM +0100, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Fri, Sep 01, 2023 at 12:00:18PM +0100, Alex Bennée wrote: > >> Currently QEMU has to know some details about the VirtIO device > >> supported by a vhost-user dae

Re: [virtio-dev] [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

2023-09-07 Thread Stefan Hajnoczi
On Tue, Sep 05, 2023 at 10:34:11AM +0100, Alex Bennée wrote: > > Albert Esteve writes: > > > This looks great! Thanks for this proposal. > > > > On Fri, Sep 1, 2023 at 1:00 PM Alex Bennée wrote: > > > > Currently QEMU has to know some details about the VirtIO device > > supported by a vhost-u

[virtio-dev] Re: [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

2023-09-07 Thread Stefan Hajnoczi
On Fri, Sep 01, 2023 at 12:00:18PM +0100, Alex Bennée wrote: > Currently QEMU has to know some details about the VirtIO device > supported by a vhost-user daemon to be able to setup the guest. This > makes it hard for QEMU to add support for additional vhost-user > daemons without adding specific s

[virtio-dev] Re: [virtio-comment] [RFC PATCH 1/5] virtio: introduce SUSPEND bit in device status

2023-08-21 Thread Stefan Hajnoczi
On Fri, Aug 18, 2023 at 05:55:42PM +0800, Zhu, Lingshan wrote: > > > On 8/18/2023 12:04 AM, Stefan Hajnoczi wrote: > > On Thu, Aug 17, 2023 at 05:15:16PM +0200, Eugenio Perez Martin wrote: > > > On Tue, Aug 15, 2023 at 2:29 PM Stefan Hajnoczi > > > wrote: >

[virtio-dev] Re: [virtio-comment] [RFC PATCH 1/5] virtio: introduce SUSPEND bit in device status

2023-08-17 Thread Stefan Hajnoczi
On Thu, Aug 17, 2023 at 05:15:16PM +0200, Eugenio Perez Martin wrote: > On Tue, Aug 15, 2023 at 2:29 PM Stefan Hajnoczi wrote: > > > > On Tue, Aug 15, 2023 at 06:31:23PM +0800, Zhu, Lingshan wrote: > > > > > > > > > On 8/14/2023 10:30 PM, Stefan Hajnoczi

[virtio-dev] Re: [virtio-comment] [RFC PATCH 3/5] virtio: The actions by the device upon SUSPEND

2023-08-16 Thread Stefan Hajnoczi
On Wed, Aug 16, 2023 at 12:25:39PM +0800, Zhu, Lingshan wrote: > > > On 8/15/2023 8:33 PM, Stefan Hajnoczi wrote: > > On Tue, Aug 15, 2023 at 07:07:42PM +0800, Zhu, Lingshan wrote: > > > > > > On 8/14/2023 11:00 PM, Stefan Hajnoczi wrote: > > > >

[virtio-dev] Re: [virtio-comment] [RFC PATCH 3/5] virtio: The actions by the device upon SUSPEND

2023-08-15 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 07:07:42PM +0800, Zhu, Lingshan wrote: > > > On 8/14/2023 11:00 PM, Stefan Hajnoczi wrote: > > On Tue, Aug 15, 2023 at 03:29:02AM +0800, Zhu Lingshan wrote: > > > This commit specifies the actions to be taken by the device upon > > > SU

[virtio-dev] Re: [virtio-comment] [RFC PATCH 1/5] virtio: introduce SUSPEND bit in device status

2023-08-15 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 06:31:23PM +0800, Zhu, Lingshan wrote: > > > On 8/14/2023 10:30 PM, Stefan Hajnoczi wrote: > > On Tue, Aug 15, 2023 at 03:29:00AM +0800, Zhu Lingshan wrote: > > > This patch introudces a new status bit in the device status: SUSPEND. > > &g

Re: [virtio-dev] [RFC PATCH 4/5] virtqueue: constraints for virtqueue state

2023-08-14 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 03:29:03AM +0800, Zhu Lingshan wrote: > This commit specifies the constraints of the virtqueue state, > and the actions should be taken by the device when SUSPEND > and DRIVER_OK is set > > Signed-off-by: Jason Wang > Signed-off-by: Zhu Lingshan > --- > content.tex | 31

[virtio-dev] Re: [virtio-comment] [RFC PATCH 3/5] virtio: The actions by the device upon SUSPEND

2023-08-14 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 03:29:02AM +0800, Zhu Lingshan wrote: > This commit specifies the actions to be taken by the device upon > SUSPEND. > > Signed-off-by: Jason Wang > Signed-off-by: Eugenio PÃrez > Signed-off-by: Zhu Lingshan > --- > content.tex | 9 + > 1 file changed, 9 insertio

[virtio-dev] Re: [virtio-comment] [RFC PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-08-14 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 03:28:59AM +0800, Zhu Lingshan wrote: > This seires introduces > 1)a new SUSPEND bit in the device status > Which is used to suspend the device, so that the device states > and virtqueue states are stablized. > > 2)virtqueue state and accessors, to get and set last_avail_id

Re: [virtio-dev] [RFC PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-08-14 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 03:29:04AM +0800, Zhu Lingshan wrote: > This patch adds two new le16 fields to common configruation structure > to support VIRTIO_F_QUEUE_STATE in PCI tranport layer. > > Signed-off-by: Jason Wang > Signed-off-by: Zhu Lingshan > --- > transport-pci.tex | 15 +

[virtio-dev] Re: [virtio-comment] [RFC PATCH 1/5] virtio: introduce SUSPEND bit in device status

2023-08-14 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 03:29:00AM +0800, Zhu Lingshan wrote: > This patch introudces a new status bit in the device status: SUSPEND. > > This SUSPEND bit can be used by the driver to suspend a device, > in order to stablize the device states and virtqueue states. > > Its main use case is live mi

Re: [virtio-dev] [RFC PATCH 2/5] virtio: introduce vq state as basic facility

2023-08-14 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 03:29:01AM +0800, Zhu Lingshan wrote: > This patch adds new device facility to save and restore virtqueue > state. The virtqueue state is split into two parts: > > - The available state: The state that is used for read the next > available buffer. > - The used state: The

[virtio-dev] Re: [virtio-comment] [RFC PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-08-14 Thread Stefan Hajnoczi
On Tue, Aug 15, 2023 at 03:28:59AM +0800, Zhu Lingshan wrote: > This seires introduces > 1)a new SUSPEND bit in the device status > Which is used to suspend the device, so that the device states > and virtqueue states are stablized. Hanna, you might be interested in this because it has overlap wit

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 12:02:33PM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 24, 2023 at 02:08:39PM -0400, Stefan Hajnoczi wrote: > > On Thu, Jul 20, 2023 at 06:22:08PM -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 20, 2023 at 05:31:03PM -0400, Stefan Hajnoczi wrote:

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-24 Thread Stefan Hajnoczi
On Thu, Jul 20, 2023 at 06:22:08PM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 20, 2023 at 05:31:03PM -0400, Stefan Hajnoczi wrote: > > On Thu, 20 Jul 2023 at 17:15, Michael S. Tsirkin wrote: > > > > > > On Thu, Jul 20, 2023 at 03:58:37PM -0400, Stefan Hajnoczi wr

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-20 Thread Stefan Hajnoczi
On Thu, Jul 06, 2023 at 12:48:20PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: > > Currently QEMU has to know some details about the back-end to be able > > to setup the guest. While various parts of the setup can be delegated > > to the backend (

Re: [virtio-dev] [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-20 Thread Stefan Hajnoczi
On Fri, Jul 07, 2023 at 12:27:39PM +0200, Stefano Garzarella wrote: > On Tue, Jul 04, 2023 at 04:02:42PM +0100, Alex Bennée wrote: > > > > Stefano Garzarella writes: > > > > > On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: > > > > diff --git a/docs/interop/vhost-user.rst b/docs/int

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-20 Thread Stefan Hajnoczi
On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > index c4e0cbd702..28b021d5d3 100644 > --- a/hw/virtio/vhost-user.c > +++ b/hw/virtio/vhost-user.c > @@ -202,6 +202,13 @@ typedef struct VhostUserInflight { > uint16_t q

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-20 Thread Stefan Hajnoczi
On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: > Currently QEMU has to know some details about the back-end to be able > to setup the guest. While various parts of the setup can be delegated > to the backend (for example config handling) this is a very piecemeal > approach. > > This

Re: [virtio-dev] virtio-snd and snapshots (e.g. in QEMU) when audio is active

2023-07-20 Thread Stefan Hajnoczi
On Wed, Jul 19, 2023 at 04:21:08PM -0700, Roman Kiryanov wrote: > Hi, > > I work in Android Studio Emulator and we use virtio-snd (implemented > ourselves) for audio output/input. According to the spec (1.2), the > device has one TX virtqueue for all output streams and one RX > virtqueue for all i

[virtio-dev] Re: [virtio-comment] [PROPOSAL] Virtio Over Fabrics(TCP/RDMA)

2023-04-25 Thread Stefan Hajnoczi
On Mon, Apr 24, 2023 at 11:40:02AM +0800, Jason Wang wrote: > On Sun, Apr 23, 2023 at 7:31 PM zhenwei pi wrote: > > I develop an kernel initiator(unstable, WIP version, currently TCP/RDMA > > supported): > > https://github.com/pizhenwei/linux/tree/virtio-of-github > > A quick glance at the code t

[virtio-dev] Re: [virtio-comment] [PROPOSAL] Virtio Over Fabrics(TCP/RDMA)

2023-04-25 Thread Stefan Hajnoczi
On Mon, Apr 24, 2023 at 11:40:02AM +0800, Jason Wang wrote: > On Sun, Apr 23, 2023 at 7:31 PM zhenwei pi wrote: > > "Virtio Over Fabrics" aims at "reuse virtio device specifications", and > > provides network defined peripheral devices. > > And this protocol also could be used in virtualization en

[virtio-dev] Re: [virtio-comment] [PATCH] transport-mmio: Replace virtual queue with virtqueue

2023-04-12 Thread Stefan Hajnoczi
+++--- > 1 file changed, 25 insertions(+), 25 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [virtio] [RFC] virtio 1.3 schedule

2023-04-05 Thread Stefan Hajnoczi
On Wed, Apr 05, 2023 at 03:57:09PM +0200, Cornelia Huck wrote: > That said, let me propose the following timeline: > > - July 1st 2023: enter feature freeze; all proposed changes must at > least have an open github issue that refers to a proposal on-list > - August 1st 2023: enter change freeze;

[virtio-dev] Re: [virtio-comment] [PATCH 00/11] Introduce transitional mmr pci device

2023-04-04 Thread Stefan Hajnoczi
On Mon, Apr 03, 2023 at 08:27:28PM +, Parav Pandit wrote: > > > From: Stefan Hajnoczi > > Sent: Monday, April 3, 2023 3:10 PM > > > > Maybe call it "Memory-mapped Transitional"? That name would be easier to > > understand. > > > Sounds

[virtio-dev] Re: [PATCH v11 09/10] admin: conformance clauses

2023-04-04 Thread Stefan Hajnoczi
n parallel with other > commands, and returning same value across uses - comment by Lingshan > add conformance clauses for new error codes > --- > admin.tex | 227 ++ > 1 file changed, 227 insertions(+) Reviewed-by: Stefan Hajnoc

[virtio-dev] Re: [PATCH v11 08/10] admin: command list discovery

2023-04-04 Thread Stefan Hajnoczi
> admin.tex | 102 +++++- > 1 file changed, 101 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [PATCH v11 05/10] pci: add admin vq registers to virtio over pci

2023-04-04 Thread Stefan Hajnoczi
On Mon, Apr 03, 2023 at 11:03:29AM -0400, Michael S. Tsirkin wrote: > @@ -1033,6 +1037,19 @@ \subsubsection{Common configuration structure > layout}\label{sec:Virtio Transport > This field exists only if VIRTIO_F_RING_RESET has been > negotiated. (see \ref{sec:Basic Facilities of

[virtio-dev] Re: [PATCH v11 04/10] admin: introduce virtio admin virtqueues

2023-04-04 Thread Stefan Hajnoczi
t; --- > admin.tex | 75 +++++ > content.tex | 7 +++-- > 2 files changed, 80 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [PATCH v11 03/10] admin: introduce group administration commands

2023-04-04 Thread Stefan Hajnoczi
data is a multiple of qword, > so things are aligned, suggested by Jiri > add Q_OK qualifier for success > --- > admin.tex| 121 +++ > introduction.tex | 3 ++ > 2 files changed, 124 insertions(+) My thoughts on status/s

[virtio-dev] Re: [PATCH v11 02/10] admin: introduce device group and related concepts

2023-04-04 Thread Stefan Hajnoczi
++++++ > content.tex | 2 ++ > 2 files changed, 65 insertions(+) > create mode 100644 admin.tex Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [virtio-comment] [PATCH 00/11] Introduce transitional mmr pci device

2023-04-03 Thread Stefan Hajnoczi
On Mon, Apr 03, 2023 at 01:48:46PM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 03, 2023 at 10:53:29AM -0400, Parav Pandit wrote: > > On 4/3/2023 10:45 AM, Stefan Hajnoczi wrote: > > > On Fri, Mar 31, 2023 at 01:58:23AM +0300, Parav Pandit wrote: > > > > 3. A hyp

[virtio-dev] Re: [virtio-comment] [PATCH 00/11] Introduce transitional mmr pci device

2023-04-03 Thread Stefan Hajnoczi
On Mon, Apr 03, 2023 at 10:53:29AM -0400, Parav Pandit wrote: > > > On 4/3/2023 10:45 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2023 at 01:58:23AM +0300, Parav Pandit wrote: > > > Overview: > > > - > > > The Transitional MMR device i

[virtio-dev] Re: [virtio-comment] [PATCH 00/11] Introduce transitional mmr pci device

2023-04-03 Thread Stefan Hajnoczi
On Fri, Mar 31, 2023 at 01:58:23AM +0300, Parav Pandit wrote: > Overview: > - > The Transitional MMR device is a variant of the transitional PCI device. What does "MMR" mean? > It has its own small Device ID range. It does not have I/O > region BAR; instead it exposes legacy configuration

Re: [virtio-dev] [PATCH 1/2] virtio-blk: migrate to the latest patchset version

2023-03-28 Thread Stefan Hajnoczi
ces") > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Fomichev > --- > drivers/block/virtio_blk.c | 238 +--- > include/uapi/linux/virtio_blk.h | 18 +-- > 2 files changed, 165 insertions(+), 91 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [virtio-dev] [PATCH 2/2] virtio-blk: fix ZBD probe in kernels without ZBD support

2023-03-28 Thread Stefan Hajnoczi
d3d ("virtio-blk: add support for zoned block devices") > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Fomichev > --- > drivers/block/virtio_blk.c | 34 ++-------- > 1 file changed, 18 insertions(+), 16 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks

2023-03-15 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 02:20:59PM +0530, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support > special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific >

[virtio-dev] Re: [PATCH V3 2/2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-15 Thread Stefan Hajnoczi
ional memory mapping requirements. > When this feature is negotiated, the front-end will send the additional > information within the memory regions themselves. > > Signed-off-by: Viresh Kumar > --- > docs/interop/vhost-user.rst | 21 +++++ > 1 file changed, 21

[virtio-dev] Re: [PATCH V3 1/2] docs: vhost-user: Define memory region separately

2023-03-15 Thread Stefan Hajnoczi
n optimization, the protocol remains the same. > > Signed-off-by: Viresh Kumar > --- > docs/interop/vhost-user.rst | 39 +-------- > 1 file changed, 18 insertions(+), 21 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 08:55:15AM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 09, 2023 at 07:35:42AM -0500, Stefan Hajnoczi wrote: > > On Wed, Mar 08, 2023 at 12:21:46PM -0500, Michael S. Tsirkin wrote: > > > On Wed, Mar 08, 2023 at 12:15:23PM -0500, Stefan Hajnoczi wrote:

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-09 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 12:21:46PM -0500, Michael S. Tsirkin wrote: > On Wed, Mar 08, 2023 at 12:15:23PM -0500, Stefan Hajnoczi wrote: > > > > > > Or we could say that admin commands must complete within bounded > > > > > > time, > > > > > &g

[virtio-dev] Re: [virtio] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
m...@redhat.com wrote: > >> >> >> >On Mon, Mar 06, 2023 at 06:03:40AM -0500, Stefan Hajnoczi wrote: > >> >> >> >> On Sun, Mar 05, 2023 at 07:18:24PM -0500, Michael S. Tsirkin > >> >> >> >> wrote: > >> >>

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 06:19:41PM +0200, Max Gurtovoy wrote: > > > On 08/03/2023 16:13, Stefan Hajnoczi wrote: > > On Wed, Mar 08, 2023 at 01:17:33PM +0200, Max Gurtovoy wrote: > > > > > > > > > On 06/03/2023 18:25, Stefan Hajnoczi wrote: > > &

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 01:17:33PM +0200, Max Gurtovoy wrote: > > > On 06/03/2023 18:25, Stefan Hajnoczi wrote: > > On Mon, Mar 06, 2023 at 05:28:03PM +0200, Max Gurtovoy wrote: > > > > > > > > > On 06/03/2023 13:20, Stefan Hajnoczi wrote: > &

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
ue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: > >> >> Mon, Mar 06, 2023 at 07:37:31PM CET, m...@redhat.com wrote: > >> >> >On Mon, Mar 06, 2023 at 06:03:40AM -0500, Stefan Hajnoczi wrote: > >> >> >> On Sun, Mar 05, 2023 at 07:18:24PM -0

[virtio-dev] Re: [virtio] RE: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 01:17:44PM +0800, Jason Wang wrote: > On Wed, Mar 8, 2023 at 3:09 AM Parav Pandit wrote: > > > > > > > > > From: Stefan Hajnoczi > > > Sent: Tuesday, March 7, 2023 2:04 PM > > > > > An alternative is unconditio

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-07 Thread Stefan Hajnoczi
on, Mar 06, 2023 at 06:03:40AM -0500, Stefan Hajnoczi wrote: > >> >> On Sun, Mar 05, 2023 at 07:18:24PM -0500, Michael S. Tsirkin wrote: > >> >> > On Sun, Mar 05, 2023 at 07:03:02PM -0500, Stefan Hajnoczi wrote: > >> >> > > On Sun, Mar 05, 2023 at

[virtio-dev] Re: [PATCH V2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-07 Thread Stefan Hajnoczi
On Tue, Mar 07, 2023 at 11:13:36AM +0530, Viresh Kumar wrote: > On 06-03-23, 10:34, Stefan Hajnoczi wrote: > > On Mon, Mar 06, 2023 at 04:40:24PM +0530, Viresh Kumar wrote: > > > +Xen mmap description > > > + > > > + > > &

[virtio-dev] Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-07 Thread Stefan Hajnoczi
On Tue, Mar 07, 2023 at 09:03:18AM +0100, Jiri Pirko wrote: > Mon, Mar 06, 2023 at 07:37:31PM CET, m...@redhat.com wrote: > >On Mon, Mar 06, 2023 at 06:03:40AM -0500, Stefan Hajnoczi wrote: > >> On Sun, Mar 05, 2023 at 07:18:24PM -0500, Michael S. Tsirkin wrote: > >> &

[virtio-dev] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Stefan Hajnoczi
On Mon, Mar 06, 2023 at 01:37:31PM -0500, Michael S. Tsirkin wrote: > On Mon, Mar 06, 2023 at 06:03:40AM -0500, Stefan Hajnoczi wrote: > > On Sun, Mar 05, 2023 at 07:18:24PM -0500, Michael S. Tsirkin wrote: > > > On Sun, Mar 05, 2023 at 07:03:02PM -0500, Stefan Hajnoczi wrote: &

[virtio-dev] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Stefan Hajnoczi
On Mon, Mar 06, 2023 at 05:28:03PM +0200, Max Gurtovoy wrote: > > > On 06/03/2023 13:20, Stefan Hajnoczi wrote: > > On Mon, Mar 06, 2023 at 04:00:50PM +0800, Jason Wang wrote: > > > > > > 在 2023/3/6 08:03, Stefan Hajnoczi 写道: > > > > On Sun, Mar 05,

[virtio-dev] Re: [PATCH V2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-06 Thread Stefan Hajnoczi
On Mon, Mar 06, 2023 at 04:40:24PM +0530, Viresh Kumar wrote: > The current model of memory mapping at the back-end works fine where a > standard call to mmap() (for the respective file descriptor) is enough > before the front-end can start accessing the guest memory. > > There are other complex c

[virtio-dev] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Stefan Hajnoczi
On Mon, Mar 06, 2023 at 04:00:50PM +0800, Jason Wang wrote: > > 在 2023/3/6 08:03, Stefan Hajnoczi 写道: > > On Sun, Mar 05, 2023 at 04:38:59AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Mar 03, 2023 at 03:21:33PM -0500, Stefan Hajnoczi wrote: > > > > What happe

[virtio-dev] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-06 Thread Stefan Hajnoczi
On Sun, Mar 05, 2023 at 07:18:24PM -0500, Michael S. Tsirkin wrote: > On Sun, Mar 05, 2023 at 07:03:02PM -0500, Stefan Hajnoczi wrote: > > On Sun, Mar 05, 2023 at 04:38:59AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Mar 03, 2023 at 03:21:33PM -0500, Stefan Hajnoczi wrote: &g

[virtio-dev] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-05 Thread Stefan Hajnoczi
On Sun, Mar 05, 2023 at 04:38:59AM -0500, Michael S. Tsirkin wrote: > On Fri, Mar 03, 2023 at 03:21:33PM -0500, Stefan Hajnoczi wrote: > > What happens if a command takes 1 second to complete, is the device > > allowed to process the next command from the virtqueue during this tim

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-03 Thread Stefan Hajnoczi
On Fri, Mar 03, 2023 at 08:18:43AM -0500, Michael S. Tsirkin wrote: > On Fri, Mar 03, 2023 at 08:13:37AM -0500, Stefan Hajnoczi wrote: > > On Thu, Mar 02, 2023 at 06:57:24PM -0500, Michael S. Tsirkin wrote: > > > On Thu, Mar 02, 2023 at 03:10:11PM -0500, Stefan Hajnoczi wrote: &

[virtio-dev] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-03 Thread Stefan Hajnoczi
On Fri, Mar 03, 2023 at 08:37:31AM -0500, Michael S. Tsirkin wrote: > On Fri, Mar 03, 2023 at 08:28:40AM -0500, Stefan Hajnoczi wrote: > > On Thu, Mar 02, 2023 at 07:05:14PM -0500, Michael S. Tsirkin wrote: > > > On Thu, Mar 02, 2023 at 03:40:07PM -0500, Stefan Hajnoczi wrote: &

[virtio-dev] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-03 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 07:05:14PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 02, 2023 at 03:40:07PM -0500, Stefan Hajnoczi wrote: > > On Thu, Mar 02, 2023 at 08:05:06AM -0500, Michael S. Tsirkin wrote: > > > The admin virtqueues will be the first interface to is

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-03 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 07:01:56PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 02, 2023 at 03:19:12PM -0500, Stefan Hajnoczi wrote: > > On Thu, Mar 02, 2023 at 06:40:29PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > >

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-03 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 06:57:24PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 02, 2023 at 03:10:11PM -0500, Stefan Hajnoczi wrote: > > On Thu, Mar 02, 2023 at 08:05:02AM -0500, Michael S. Tsirkin wrote: > > > This introduces a general structure for group administration comma

[virtio-dev] Re: [PATCH v10 10/10] ccw: document more reserved features

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 08:05:30AM -0500, Michael S. Tsirkin wrote: > vq reset and shared memory are unsupported, too. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [PATCH v10 08/10] admin: command list discovery

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 08:05:22AM -0500, Michael S. Tsirkin wrote: > Add commands to find out which commands does each group support, > as well as enable their use by driver. > This will be especially useful once we have multiple group types. > > An alternative is per-type VQs. This is possible b

[virtio-dev] Re: [PATCH v10 07/10] ccw: document ADMIN_VQ as reserved

2023-03-02 Thread Stefan Hajnoczi
t's reserved in a central place, but it > does not hurt to remind implementers to mask it. > > Note: there are more features to add to this list. > Will be done later with a patch on top. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 12 ++++ &g

[virtio-dev] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-02 Thread Stefan Hajnoczi
t's reserved in a central place, but it > does not hurt to remind implementers to mask it. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 12 > 1 file changed, 12 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[virtio-dev] Re: [PATCH v10 05/10] pci: add admin vq registers to virtio over pci

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 08:05:10AM -0500, Michael S. Tsirkin wrote: > Add new registers to the PCI common configuration structure. > > These registers will be used for querying the indices of the admin > virtqueues of the owner device. To configure, reset or enable the admin > virtqueues, the driv

[virtio-dev] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 08:05:06AM -0500, Michael S. Tsirkin wrote: > The admin virtqueues will be the first interface to issue admin commands. > > Currently virtio specification defines control virtqueue to manipulate > features and configuration of the device it operates on. However, > control v

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 06:40:29PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, March 2, 2023 8:05 AM > > > +When \field{status} is VIRTIO_ADMIN_STATUS_OK, \field{status_qialifier} > > +is reserved and set to zero by the device. > > + > s/status_qialifier/status_

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 08:05:02AM -0500, Michael S. Tsirkin wrote: > This introduces a general structure for group administration commands, > used to control device groups through their owner. > > Following patches will introduce specific commands and an interface for > submitting these commands

[virtio-dev] Re: [virtio] [PATCH v10 02/10] admin: introduce device group and related concepts

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 08:04:57AM -0500, Michael S. Tsirkin wrote: > +The following group types, and their identifiers, are currently specified): spurious ')' signature.asc Description: PGP signature

Re: [virtio-dev] [RFC QEMU] docs: vhost-user: Add custom memory mapping support

2023-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2023 at 01:49:07PM +0530, Viresh Kumar wrote: > On 01-03-23, 12:29, Stefan Hajnoczi wrote: > > What is the advantage over defining separate messages? Separate messages > > are cleaner and more typesafe. > > I thought we wanted to keep single message for one

Re: [virtio-dev] [RFC QEMU] docs: vhost-user: Add custom memory mapping support

2023-03-01 Thread Stefan Hajnoczi
On Wed, Mar 01, 2023 at 04:31:41PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > [[PGP Signed Part:Undecided]] > > Resend - for some reason my email didn't make it out. > > > > From: Stefan Hajnoczi > > Subject: Re: [virtio-dev] [R

Re: [virtio-dev] [RFC QEMU] docs: vhost-user: Add custom memory mapping support

2023-03-01 Thread Stefan Hajnoczi
Resend - for some reason my email didn't make it out. - Forwarded message from Stefan Hajnoczi - Date: Tue, 21 Feb 2023 10:17:01 -0500 From: Stefan Hajnoczi To: Viresh Kumar Cc: qemu-de...@nongnu.org, virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" , Vincent

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-blk: Define dev cfg layout before its fields

2023-02-23 Thread Stefan Hajnoczi
le32 write_granularity; > -u8 model; > -u8 unused2[3]; > -} zoned; > -}; > -\end{lstlisting} > - > - > \subsubsection{Legacy Interface: Device configuration > layout}\label{sec:Device Types / Block Device / Device configuration layout / > Legacy Interface: Device configuration layout} > When using the legacy interface, transitional devices and drivers > MUST format the fields in struct virtio_blk_config > -- > 2.26.2 Yes, please! Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [virtio-dev] [PATCH v4 2/2] virtio-blk: add support for zoned block devices

2022-11-02 Thread Stefan Hajnoczi
-specific code in the patch is heavily influenced by NVMe ZNS > code in drivers/nvme/host/zns.c, but it is simpler because the proposed > virtio ZBD draft only covers the zoned device features that are > relevant to the zoned functionality provided by Linux block layer. > > Co-devel

[virtio-dev] Re: [virtio-comment] [PATCH v7] virtio-blk: add zoned block device specification

2022-10-31 Thread Stefan Hajnoczi
Required (SWR) zones that require some additional handling from the > host > +for correct operation. All write requests to SWR zones must be sequential and There is a "must" here. Same question as above. Aside from that: Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [virtio-dev] Re: [External] Re: [PATCH v3 3/4] content: Introduce driver/device auxiliary notifications for MMIO

2022-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2022 at 02:22:22PM +, Usama Arif wrote: > On 27/10/2022 22:27, Stefan Hajnoczi wrote: > > On Fri, Oct 07, 2022 at 05:56:42PM +0100, Usama Arif wrote: > > > This includes the additions to the corresponding device and driver > > > conformances. > &

Re: [virtio-dev] Re: [PATCH v3 3/4] content: Introduce driver/device auxiliary notifications for MMIO

2022-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2022 at 11:45:55AM -0400, Michael S. Tsirkin wrote: > On Thu, Oct 27, 2022 at 05:27:28PM -0400, Stefan Hajnoczi wrote: > > On Fri, Oct 07, 2022 at 05:56:42PM +0100, Usama Arif wrote: > > > This includes the additions to the corresponding device and driver

[virtio-dev] Re: [PATCH v3 2/4] content: Introduce driver/device aux. notification cfg type for PCI

2022-10-31 Thread Stefan Hajnoczi
On Fri, Oct 07, 2022 at 05:56:41PM +0100, Usama Arif wrote: > This includes the PCI device conformances for these notification > capabilities. > > Signed-off-by: Usama Arif > Signed-off-by: Stefan Hajnoczi You can keep this, but please see comments below. > Signed-off-

[virtio-dev] Re: [PATCH v3 3/4] content: Introduce driver/device auxiliary notifications for MMIO

2022-10-31 Thread Stefan Hajnoczi
On Fri, Oct 07, 2022 at 05:56:42PM +0100, Usama Arif wrote: > This includes the additions to the corresponding device and driver > conformances. > > Signed-off-by: Usama Arif > Signed-off-by: Stefan Hajnoczi You can keep this. One thought: I realized that virtio-mmio suppor

[virtio-dev] Re: [PATCH v3 1/4] content: Introduce driver/device auxiliary notifications

2022-10-27 Thread Stefan Hajnoczi
en adding support > for virtio-vhost-user device. > > Signed-off-by: Usama Arif > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Nikos Dragazis > --- > content.tex | 35 ++- > 1 file changed, 22 insertions(+), 13 deletions(-) > > dif

[virtio-dev] Re: [PATCH v3 0/4] Introduce aux. notifications and virtio-vhost-user

2022-10-27 Thread Stefan Hajnoczi
otocol instead of a family of > new virtio device types, one for each vhost-user device type. > > A HTML version with the changes is available at [1]. > > For more information about virtio-vhost-user, see [2]. > > These patches are based on the work initially done by Stefa

Re: [virtio-dev] [PATCH v2 2/2] virtio-blk: add support for zoned block devices

2022-10-16 Thread Stefan Hajnoczi
-specific code in the patch is heavily influenced by NVMe ZNS > code in drivers/nvme/host/zns.c, but it is simpler because the proposed > virtio ZBD draft only covers the zoned device features that are > relevant to the zoned functionality provided by Linux block layer. > > Co-devel

Re: [virtio-dev] [PATCH v2 1/2] virtio-blk: use a helper to handle request queuing errors

2022-10-16 Thread Stefan Hajnoczi
- > 1 file changed, 16 insertions(+), 13 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [virtio-dev] [PATCH v6] virtio-blk: add zoned block device specification

2022-10-06 Thread Stefan Hajnoczi
On Sun, Sep 04, 2022 at 12:56:01PM -0400, Dmitry Fomichev wrote: > @@ -4746,7 +4930,15 @@ \subsection{Device Operation}\label{sec:Device Types / > Block Device / Device Ope > le32 reserved; > le64 sector; > u8 data[]; > -u8 status; > +union { > +

Re: [virtio-dev] [PATCH v6] virtio-blk: add zoned block device specification

2022-10-04 Thread Stefan Hajnoczi
On Sun, Sep 04, 2022 at 12:56:01PM -0400, Dmitry Fomichev wrote: > Introduce support for Zoned Block Devices to virtio. > > Zoned Block Devices (ZBDs) aim to achieve a better capacity, latency > and/or cost characteristics compared to commonly available block > devices by getting the entire LBA sp

Re: [virtio-dev] VM memory protection and zero-copy transfers.

2022-09-09 Thread Stefan Hajnoczi
On Fri, Sep 09, 2022 at 08:52:02AM +, Afsa, Baptiste wrote: > Hello, > > I ran some benchmarks to compare the performances achieved by the swiotlb > approach and our dynamic memory granting solution while using different buffer > sizes. Without any surprise, the swiotlb approach performs much

Re: [virtio-dev] Next VirtIO device for Project Stratos?

2022-09-07 Thread Stefan Hajnoczi
On Wed, Sep 07, 2022 at 03:09:27PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Tue, Sep 06, 2022 at 06:33:36PM +0100, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > On Sat, Se

Re: [virtio-dev] Next VirtIO device for Project Stratos?

2022-09-06 Thread Stefan Hajnoczi
On Tue, Sep 06, 2022 at 06:33:36PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Sat, Sep 03, 2022 at 07:43:08AM +, Alyssa Ross wrote: > > > Hi Alex and everyone else, just catching up on some mail and wanted to > &g

Re: [virtio-dev] Next VirtIO device for Project Stratos?

2022-09-05 Thread Stefan Hajnoczi
On Sat, Sep 03, 2022 at 07:43:08AM +, Alyssa Ross wrote: > Hi Alex and everyone else, just catching up on some mail and wanted to > clarify some things: > > Alex Bennée writes: > > > This email is driven by a brain storming session at a recent sprint > > where we considered what VirtIO devic

Re: [virtio-dev] [RFC PATCH v3] virtio-blk: add zoned block device specification

2022-08-08 Thread Stefan Hajnoczi
On Thu, 4 Aug 2022 at 18:41, Dmitry Fomichev wrote: Hi Dmitry, I think RFC can be removed from the Subject line for the next revision of this patch. For instructions on how to bring this to a Technical Committee vote, see: https://github.com/oasis-tcs/virtio-spec#use-of-github-issues > > Introd

Re: [virtio-dev] VM memory protection and zero-copy transfers.

2022-07-15 Thread Stefan Hajnoczi
On Fri, Jul 15, 2022 at 02:18:32PM +, Afsa, Baptiste wrote: > > One thing I didn't see in your proposal was a copying vs zero-copy > > threshold. Maybe it helps to look at the size of requests and copy data > > instead of granting pages when descriptors are small? On the other hand, > > a 4 KB

Re: [virtio-dev] VM memory protection and zero-copy transfers.

2022-07-12 Thread Stefan Hajnoczi
On Fri, Jul 08, 2022 at 01:56:31PM +, Afsa, Baptiste wrote: > Hello everyone, > > The traditional virtio model relies on the ability for the host to access the > entire memory of the guest VM. The VIRTIO device model (virtqueues, configuration space, feature negotiation, etc) does not rely on

Re: [virtio-dev] [RFC PATCH v2] virtio-blk: add zoned block device specification

2022-06-11 Thread Stefan Hajnoczi
On Sun, Jun 12, 2022 at 01:58:36AM +, Dmitry Fomichev wrote: > On Sat, 2022-06-11 at 21:09 +0100, Stefan Hajnoczi wrote: > > On Thu, Jun 09, 2022 at 08:43:21PM -0400, Dmitry Fomichev wrote: > > > +Host-managed zoned block devices have their LBA range divided to > > &

Re: [virtio-dev] [RFC PATCH v2] virtio-blk: add zoned block device specification

2022-06-11 Thread Stefan Hajnoczi
On Thu, Jun 09, 2022 at 08:43:21PM -0400, Dmitry Fomichev wrote: > +Host-managed zoned block devices have their LBA range divided to Sequential > +Write Required (SWR) zones that require some additional handling from the > host > +for sustainable operation. All write requests to SWR zones must be

Re: [virtio-dev] [RFC PATCH] virtio-blk: add zoned block device specification

2022-06-04 Thread Stefan Hajnoczi
On Sat, Jun 04, 2022 at 12:09:46AM +, Dmitry Fomichev wrote: > On Fri, 2022-06-03 at 09:08 +0100, Stefan Hajnoczi wrote: > > (Resent from my subscriber email.) > > > > On Fri, 3 Jun 2022 at 03:30, Dmitry Fomichev > > wrote: > > > > > > On Th

Re: [virtio-dev] [RFC PATCH] virtio-blk: add zoned block device specification

2022-06-03 Thread Stefan Hajnoczi
On Fri, Jun 03, 2022 at 05:16:01PM +0900, Damien Le Moal wrote: > On 6/3/22 16:33, Stefan Hajnoczi wrote: > [...] > >> If partial is 0, the nr_zones will contain the number of zones that > >> potentially > >> can be reported starting from the request "secto

  1   2   3   4   5   6   >