[virtio-dev] Re: [PATCH v2] content: explicitly document the VLAN filtering as best-effort

2019-07-30 Thread Tiwei Bie
On Wed, Jul 31, 2019 at 09:34:46AM +0800, Tiwei Bie wrote: > Similar to the MAC address based filtering, the VLAN filtering > is also best-effort in implementations, but it's not quite clear > in the spec. So document this behaviour explicitly to reflect > the way imple

[virtio-dev] [PATCH v2] content: explicitly document the VLAN filtering as best-effort

2019-07-30 Thread Tiwei Bie
Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave. Signed-off-by: Tiwei Bie Acked-by: Michael S. Tsirkin Review

[virtio-dev] [PATCH] content: explicitly document the VLAN filtering as best-effort

2019-07-18 Thread Tiwei Bie
ff-by: Tiwei Bie Acked-by: Michael S. Tsirkin --- v1: - Add "Fixes:" tag; RFC link: https://lists.oasis-open.org/archives/virtio-dev/201907/msg00035.html content.tex | 5 + 1 file changed, 5 insertions(+) diff --git a/content.tex b/content.tex index 8f0498e..783322b 100644 --- a/co

[virtio-dev] [RFC] content: explicitly document the VLAN filtering as best-effort

2019-07-18 Thread Tiwei Bie
Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave. Signed-off-by: Tiwei Bie --- This is a RFC for now (Comments wou

Re: [virtio-dev] [PATCH] content: fix typo in feature bit name

2019-07-17 Thread Tiwei Bie
On Wed, Jul 17, 2019 at 11:04:26AM +0100, Stefan Hajnoczi wrote: > On Tue, Jun 11, 2019 at 02:53:04PM +0800, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > --- > > content.tex | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --gi

[virtio-dev] [PATCH] content: fix typo in feature bit name

2019-06-10 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- content.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content.tex b/content.tex index 193b6e1..a143d91 100644 --- a/content.tex +++ b/content.tex @@ -3523,7 +3523,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network

[virtio-dev] [PATCH v2] virtio: support VIRTIO_F_ORDER_PLATFORM

2019-01-23 Thread Tiwei Bie
but not accepted. Signed-off-by: Tiwei Bie --- v2: - Add more explanations in commit log (MST); drivers/virtio/virtio_ring.c | 8 include/uapi/linux/virtio_config.h | 6 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio

[virtio-dev] Re: [PATCH] virtio: support VIRTIO_F_ORDER_PLATFORM

2019-01-23 Thread Tiwei Bie
On Tue, Jan 22, 2019 at 11:04:29PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 01:03:46AM +0800, Tiwei Bie wrote: > > This patch introduces the support for VIRTIO_F_ORDER_PLATFORM. > > When this feature is negotiated, driver will use the barriers > > suitable

[virtio-dev] [PATCH] virtio: support VIRTIO_F_ORDER_PLATFORM

2019-01-22 Thread Tiwei Bie
This patch introduces the support for VIRTIO_F_ORDER_PLATFORM. When this feature is negotiated, driver will use the barriers suitable for hardware devices. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 8 include/uapi/linux/virtio_config.h | 6 ++ 2 files

[virtio-dev] Re: [RFC 3/3] virtio_ring: use new vring flags

2018-12-08 Thread Tiwei Bie
On Fri, Dec 07, 2018 at 01:10:48PM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 04:48:42PM +0800, Tiwei Bie wrote: > > Switch to using the _SPLIT_ and _PACKED_ variants of vring flags > > in split ring and packed ring respectively. > > > &g

[virtio-dev] Re: [RFC 2/3] virtio_ring: add VIRTIO_RING_NO_LEGACY

2018-12-08 Thread Tiwei Bie
On Fri, Dec 07, 2018 at 01:05:35PM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 04:48:41PM +0800, Tiwei Bie wrote: > > Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy > > macros and layout definitions. > > > > Suggested-by: Michael S. Tsirki

[virtio-dev] Re: [RFC 0/3] virtio_ring: define flags as shifts consistently

2018-12-08 Thread Tiwei Bie
On Fri, Dec 07, 2018 at 01:11:42PM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 04:48:39PM +0800, Tiwei Bie wrote: > > This is a follow up of the discussion in this thread: > > https://patchwork.ozlabs.org/patch/1001015/#2042353 > > How was this tested? I'

[virtio-dev] [RFC 2/3] virtio_ring: add VIRTIO_RING_NO_LEGACY

2018-12-07 Thread Tiwei Bie
Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy macros and layout definitions. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie --- VRING_AVAIL_ALIGN_SIZE, VRING_USED_ALIGN_SIZE and VRING_DESC_ALIGN_SIZE are not pre-virtio 1.0, but can also be disabled by

[virtio-dev] [RFC 1/3] virtio_ring: define flags as shifts consistently

2018-12-07 Thread Tiwei Bie
Introduce _SPLIT_ and/or _PACKED_ variants for VRING_DESC_F_*, VRING_AVAIL_F_NO_INTERRUPT and VRING_USED_F_NO_NOTIFY. These variants are defined as shifts instead of shifted values for consistency with other _F_ flags. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie --- include/uapi

[virtio-dev] [RFC 0/3] virtio_ring: define flags as shifts consistently

2018-12-07 Thread Tiwei Bie
This is a follow up of the discussion in this thread: https://patchwork.ozlabs.org/patch/1001015/#2042353 Tiwei Bie (3): virtio_ring: define flags as shifts consistently virtio_ring: add VIRTIO_RING_NO_LEGACY virtio_ring: use new vring flags drivers/virtio/virtio_ring.c | 100

[virtio-dev] [RFC 3/3] virtio_ring: use new vring flags

2018-12-07 Thread Tiwei Bie
Switch to using the _SPLIT_ and _PACKED_ variants of vring flags in split ring and packed ring respectively. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 100 +-- 1 file changed, 59 insertions(+), 41 deletions(-) diff --git a/drivers/virtio

Re: [virtio-dev] [PATCH v4] packed-ring: fix used descriptor checking in example code

2018-12-06 Thread Tiwei Bie
On Thu, Dec 06, 2018 at 12:27:01AM +0800, Tiwei Bie wrote: > When the driver is processing used descriptors in parallel > with adding new available descriptors, the driver can't just > check whether USED bit equals to the used wrap counter when > checking whether a descriptor is

[virtio-dev] [PATCH v4] packed-ring: fix used descriptor checking in example code

2018-12-05 Thread Tiwei Bie
ptor which is wrong. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29 Signed-off-by: Tiwei Bie --- v2: - Add "Fixes" tag; - Refine commit log; v3: - Compare with vq->used_wrap_count (MST); - Add comments (MST); - Refine commit log; v4: - s/device/the device/ (Cornelia); - s/dr

[virtio-dev] Re: [PATCH v3] packed-ring: fix example code

2018-12-05 Thread Tiwei Bie
On Wed, Dec 05, 2018 at 10:18:32AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 05, 2018 at 11:03:33PM +0800, Tiwei Bie wrote: > > On Wed, Dec 05, 2018 at 03:04:08PM +0100, Cornelia Huck wrote: > > > On Wed, 5 Dec 2018 10:16:51 +0800 > > > Tiwei Bie wrote: >

[virtio-dev] Re: [PATCH v3] packed-ring: fix example code

2018-12-05 Thread Tiwei Bie
On Wed, Dec 05, 2018 at 03:04:08PM +0100, Cornelia Huck wrote: > On Wed, 5 Dec 2018 10:16:51 +0800 > Tiwei Bie wrote: > > > Driver can't just check whether USED bit equals to the used > > wrap counter when checking whether a descriptor is a used > > descript

[virtio-dev] [PATCH v3] packed-ring: fix example code

2018-12-04 Thread Tiwei Bie
vancing vq->next_used pointer, it will then also treat the next descriptor, i.e. the second descriptor (whose AVAIL and USED bits are 1 and 0 respectively) as a used descriptor which is wrong. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29 Signed-off-by: Tiwei Bie --- v2: - Add "Fi

[virtio-dev] Re: [PATCH v2] packed-ring: fix example code

2018-12-04 Thread Tiwei Bie
On Tue, Dec 04, 2018 at 12:11:38PM -0500, Michael S. Tsirkin wrote: > On Tue, Dec 04, 2018 at 06:49:29PM +0800, Tiwei Bie wrote: > > Driver can't just check whether USED bit equals to the used > > wrap counter when checking whether a descriptor is a used > > descr

[virtio-dev] [PATCH v2] packed-ring: fix example code

2018-12-04 Thread Tiwei Bie
e. the second descriptor (whose AVAIL and USED bits are 1 and 0 respectively) as a used descriptor which is wrong. The most straightforward way to fix it is to also check whether AVAIL bit equals to USED bit. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29 Signed-off-by: Tiwei Bie --- v2: - Ad

[virtio-dev] Re: [PATCH net-next v3 01/13] virtio: add packed ring types and macros

2018-11-30 Thread Tiwei Bie
On Fri, Nov 30, 2018 at 11:46:57AM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 01, 2018 at 12:24:16AM +0800, Tiwei Bie wrote: > > On Fri, Nov 30, 2018 at 10:53:07AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Nov 30, 2018 at 11:37:37PM +0800, Tiwei Bie wrote: > > >

[virtio-dev] Re: [PATCH net-next v3 01/13] virtio: add packed ring types and macros

2018-11-30 Thread Tiwei Bie
On Fri, Nov 30, 2018 at 10:53:07AM -0500, Michael S. Tsirkin wrote: > On Fri, Nov 30, 2018 at 11:37:37PM +0800, Tiwei Bie wrote: > > On Fri, Nov 30, 2018 at 08:52:42AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Nov 30, 2018 at 02:01:06PM +0100, Maxime Coquelin wrote: > &

[virtio-dev] Re: [PATCH net-next v3 01/13] virtio: add packed ring types and macros

2018-11-30 Thread Tiwei Bie
On Fri, Nov 30, 2018 at 08:52:42AM -0500, Michael S. Tsirkin wrote: > On Fri, Nov 30, 2018 at 02:01:06PM +0100, Maxime Coquelin wrote: > > On 11/30/18 1:47 PM, Michael S. Tsirkin wrote: > > > On Fri, Nov 30, 2018 at 05:53:40PM +0800, Tiwei Bie wrote: > > > > On F

[virtio-dev] Re: [PATCH net-next v3 01/13] virtio: add packed ring types and macros

2018-11-30 Thread Tiwei Bie
On Fri, Nov 30, 2018 at 04:10:55PM +0800, Jason Wang wrote: > > On 2018/11/21 下午6:03, Tiwei Bie wrote: > > Add types and macros for packed ring. > > > > Signed-off-by: Tiwei Bie > > --- > > include/uapi/linux/virtio_config.h | 3 +++ > >

[virtio-dev] Re: [PATCH net-next v3 00/13] virtio: support packed ring

2018-11-21 Thread Tiwei Bie
On Wed, Nov 21, 2018 at 07:20:27AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 21, 2018 at 06:03:17PM +0800, Tiwei Bie wrote: > > Hi, > > > > This patch set implements packed ring support in virtio driver. > > > > A performance test between pktgen (pkt

[virtio-dev] [PATCH net-next v3 10/13] virtio_ring: introduce packed ring support

2018-11-21 Thread Tiwei Bie
Introduce the packed ring support. Packed ring can only be created by vring_create_virtqueue() and each chunk of packed ring will be allocated individually. Packed ring can not be created on preallocated memory by vring_new_virtqueue() or the likes currently. Signed-off-by: Tiwei Bie

[virtio-dev] [PATCH net-next v3 06/13] virtio_ring: introduce helper for indirect feature

2018-11-21 Thread Tiwei Bie
Introduce a helper to check whether we will use indirect feature. It will be used by packed ring too. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio

[virtio-dev] [PATCH net-next v3 08/13] virtio_ring: extract split ring handling from ring creation

2018-11-21 Thread Tiwei Bie
Introduce a specific function to create the split ring. And also move the DMA allocation and size information to the .split sub-structure. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 220 --- 1 file changed, 121 insertions(+), 99 deletions

[virtio-dev] [PATCH net-next v3 11/13] virtio_ring: leverage event idx in packed ring

2018-11-21 Thread Tiwei Bie
Leverage the EVENT_IDX feature in packed ring to suppress events when it's available. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 77 1 file changed, 71 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_rin

[virtio-dev] [PATCH net-next v3 05/13] virtio_ring: introduce debug helpers

2018-11-21 Thread Tiwei Bie
Introduce debug helpers for last_add_time update, check and invalid. They will be used by packed ring too. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 49 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/drivers/virtio

[virtio-dev] [PATCH net-next v3 09/13] virtio_ring: cache whether we will use DMA API

2018-11-21 Thread Tiwei Bie
Cache whether we will use DMA API, instead of doing the check every time. We are going to check whether DMA API is used more often in packed ring. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers

[virtio-dev] [PATCH net-next v3 13/13] virtio_ring: advertize packed ring layout

2018-11-21 Thread Tiwei Bie
Advertize the packed ring layout support. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 40e4d3798d16..cd7e755484e3 100644 --- a/drivers/virtio/virtio_ring.c +++ b

[virtio-dev] [PATCH net-next v3 12/13] virtio_ring: disable packed ring on unsupported transports

2018-11-21 Thread Tiwei Bie
Currently, ccw, vop and remoteproc need some legacy virtio APIs to create or access virtio rings, which are not supported by packed ring. So disable packed ring on these transports for now. Signed-off-by: Tiwei Bie --- drivers/misc/mic/vop/vop_main.c| 13 + drivers

[virtio-dev] [PATCH net-next v3 04/13] virtio_ring: put split ring fields in a sub struct

2018-11-21 Thread Tiwei Bie
Put the split ring specific fields in a sub-struct named as "split" to avoid misuse after introducing packed ring. There is no functional change. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 156 +-- 1 file changed, 91 inserti

[virtio-dev] [PATCH net-next v3 01/13] virtio: add packed ring types and macros

2018-11-21 Thread Tiwei Bie
Add types and macros for packed ring. Signed-off-by: Tiwei Bie --- include/uapi/linux/virtio_config.h | 3 +++ include/uapi/linux/virtio_ring.h | 52 ++ 2 files changed, 55 insertions(+) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi

[virtio-dev] [PATCH net-next v3 07/13] virtio_ring: allocate desc state for split ring separately

2018-11-21 Thread Tiwei Bie
Put the split ring's desc state into the .split sub-structure, and allocate desc state for split ring separately, this makes the code more readable and more consistent with what we will do for packed ring. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c

[virtio-dev] [PATCH net-next v3 03/13] virtio_ring: put split ring functions together

2018-11-21 Thread Tiwei Bie
Put the xxx_split() functions together to make the code more readable and avoid misuse after introducing the packed ring. There is no functional change. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 587 ++- 1 file changed, 302 insertions

[virtio-dev] [PATCH net-next v3 02/13] virtio_ring: add _split suffix for split ring functions

2018-11-21 Thread Tiwei Bie
Add _split suffix for split ring specific functions. This is a preparation for introducing the packed ring support. There is no functional change. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 269 ++- 1 file changed, 164 insertions(+), 105

[virtio-dev] [PATCH net-next v3 00/13] virtio: support packed ring

2018-11-21 Thread Tiwei Bie
#x27;%' operator (Jason); - Rename free_head -> next_avail_idx (Jason); - Add comments for virtio_wmb() in virtqueue_add_packed() (Jason); - Some other refinements and bug fixes; Tiwei Bie (13): virtio: add packed ring types and macros virtio_ring: add _split suffix for split ring functi

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Tiwei Bie
On Thu, Nov 08, 2018 at 10:56:02AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > &g

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Tiwei Bie
On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > + > > > > + if (vq->vq.num_free < descs_used) { > > > > + pr_debug("Can't add buf len %i - avail = %i\n"

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-07 Thread Tiwei Bie
On Wed, Nov 07, 2018 at 12:48:46PM -0500, Michael S. Tsirkin wrote: > On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > > This commit introduces the support (without EVENT_IDX) for > > packed ring. > > > > Signed-off-by: Tiwei Bie > > --- > &

[virtio-dev] [PATCH] packed-ring: fix example code

2018-11-06 Thread Tiwei Bie
ose AVAIL and USED bits are 1 and 0) as used which is wrong. Signed-off-by: Tiwei Bie --- packed-ring.tex | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packed-ring.tex b/packed-ring.tex index ebbad95..ec116d7 100644 --- a/packed-ring.tex +++ b/packed-ring.tex @@ -6

Re: [virtio-dev] [PATCH v3] content: document SR-IOV driver requirements

2018-10-24 Thread Tiwei Bie
On Tue, Jun 12, 2018 at 01:18:00PM +0800, Tiwei Bie wrote: > Document the driver requirements for the VIRTIO_F_SR_IOV > feature bit. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/13 > --- > v2: &g

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Tiwei Bie
On Thu, Oct 11, 2018 at 10:17:15AM -0400, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2018 at 10:13:31PM +0800, Tiwei Bie wrote: > > On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > > > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > >

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Tiwei Bie
On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > > But if it's not too late, I second for a OUT_OF_ORDER feature. > > > > Starting from in order can have much simpler code in

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Tiwei Bie
On Wed, Oct 10, 2018 at 10:36:26AM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 13, 2018 at 05:47:29PM +0800, Jason Wang wrote: > > On 2018年09月13日 16:59, Tiwei Bie wrote: > > > > If what you say is true then we should take a careful look > > > > and not sup

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-13 Thread Tiwei Bie
On Wed, Sep 12, 2018 at 12:16:32PM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 11, 2018 at 01:37:26PM +0800, Tiwei Bie wrote: > > On Mon, Sep 10, 2018 at 11:33:17AM +0800, Jason Wang wrote: > > > On 2018年09月10日 11:00, Tiwei Bie wrote: > > > > On Fri, Sep 07, 2018

[virtio-dev] Re: [PATCH net-next v2 2/5] virtio_ring: support creating packed ring

2018-09-12 Thread Tiwei Bie
On Mon, Sep 10, 2018 at 10:28:37AM +0800, Tiwei Bie wrote: > On Fri, Sep 07, 2018 at 10:03:24AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 11, 2018 at 10:27:08AM +0800, Tiwei Bie wrote: > > > This commit introduces the support for creating packed ring. > > > All sp

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-10 Thread Tiwei Bie
On Mon, Sep 10, 2018 at 11:33:17AM +0800, Jason Wang wrote: > On 2018年09月10日 11:00, Tiwei Bie wrote: > > On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > > > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > > > > On Mon, Aug 27, 2018

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-09 Thread Tiwei Bie
On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > > On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: > > > Are there still plans to test the performance with vost pmd? > >

Re: [virtio-dev] Re: [PATCH net-next v2 4/5] virtio_ring: add event idx support in packed ring

2018-09-09 Thread Tiwei Bie
On Fri, Sep 07, 2018 at 10:10:14AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 11, 2018 at 10:27:10AM +0800, Tiwei Bie wrote: > > This commit introduces the EVENT_IDX support in packed ring. > > > > Signed-off-by: Tiwei Bie > > Besides the usual comment about har

[virtio-dev] Re: [PATCH net-next v2 2/5] virtio_ring: support creating packed ring

2018-09-09 Thread Tiwei Bie
On Fri, Sep 07, 2018 at 10:03:24AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 11, 2018 at 10:27:08AM +0800, Tiwei Bie wrote: > > This commit introduces the support for creating packed ring. > > All split ring specific functions are added _split suffix. > > Some necessary

[virtio-dev] Re: [PATCH net-next v2 1/5] virtio: add packed ring definitions

2018-09-09 Thread Tiwei Bie
On Fri, Sep 07, 2018 at 09:51:23AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 11, 2018 at 10:27:07AM +0800, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > --- > > include/uapi/linux/virtio_config.h | 3 +++ > > include/uapi/linux/virtio_ring.h | 43 ++

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-09-09 Thread Tiwei Bie
On Fri, Sep 07, 2018 at 09:49:14AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > > This commit introduces the support (without EVENT_IDX) for > > packed ring. > > > > Signed-off-by: Tiwei Bie > > --- > &

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-06 Thread Tiwei Bie
'm not sure whether there is any other better idea, I'd like to hear your thoughts. Thanks! > > On Wed, Jul 11, 2018 at 10:27:06AM +0800, Tiwei Bie wrote: > > Hello everyone, > > > > This patch set implements packed ring support in virtio driver. > >

Re: [virtio-dev] [PATCH v1] content: use a consistent wording for device status

2018-07-16 Thread Tiwei Bie
On Wed, Jun 13, 2018 at 05:27:02PM +0800, Tiwei Bie wrote: > There is a part called "device status field" in a > Virtio device. Currently, both of \field{status} > and \field{device status} are used to refer to it, > which is a bit confusing. This patch changes spec > to

Re: [virtio-dev] Re: [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-07-16 Thread Tiwei Bie
On Fri, Jun 29, 2018 at 07:20:23AM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 28, 2018 at 04:52:35PM +0800, Tiwei Bie wrote: > > On Wed, Jun 27, 2018 at 06:08:03PM +0200, Cornelia Huck wrote: > > > On Tue, 26 Jun 2018 21:39:22 +0300 > > > "Michael S. Tsirkin&quo

[virtio-dev] [PATCH net-next v2 0/5] virtio: support packed ring

2018-07-10 Thread Tiwei Bie
using '%' operator (Jason); - Rename free_head -> next_avail_idx (Jason); - Add comments for virtio_wmb() in virtqueue_add_packed() (Jason); - Some other refinements and bug fixes; Thanks! Tiwei Bie (5): virtio: add packed ring definitions virtio_ring: support creating packed ring virtio

[virtio-dev] [PATCH net-next v2 1/5] virtio: add packed ring definitions

2018-07-10 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- include/uapi/linux/virtio_config.h | 3 +++ include/uapi/linux/virtio_ring.h | 43 ++ 2 files changed, 46 insertions(+) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index 449132c76b1c

[virtio-dev] [PATCH net-next v2 2/5] virtio_ring: support creating packed ring

2018-07-10 Thread Tiwei Bie
This commit introduces the support for creating packed ring. All split ring specific functions are added _split suffix. Some necessary stubs for packed ring are also added. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 801 +++ include/linux

[virtio-dev] [PATCH net-next v2 4/5] virtio_ring: add event idx support in packed ring

2018-07-10 Thread Tiwei Bie
This commit introduces the EVENT_IDX support in packed ring. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 73 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index

[virtio-dev] [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-07-10 Thread Tiwei Bie
This commit introduces the support (without EVENT_IDX) for packed ring. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 495 ++- 1 file changed, 487 insertions(+), 8 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio

[virtio-dev] [PATCH net-next v2 5/5] virtio_ring: enable packed ring

2018-07-10 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/s390/virtio/virtio_ccw.c | 14 ++ drivers/virtio/virtio_ring.c | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 8f5c1d7f751a..8654f3a94635 100644 --- a/drivers

Re: [virtio-dev] Re: [PATCH net-next v1 4/5] virtio_ring: add event idx support in packed ring

2018-07-10 Thread Tiwei Bie
On Tue, Jul 10, 2018 at 01:50:03PM +0800, Jason Wang wrote: > On 2018年07月09日 15:22, Tiwei Bie wrote: > > @@ -1059,9 +1059,19 @@ static bool virtqueue_kick_prepare_packed(struct > > virtqueue *_vq) > > * suppressions. */ > > virtio_mb(vq->weak_barriers); &g

[virtio-dev] Re: [PATCH net-next v1 5/5] virtio_ring: enable packed ring

2018-07-10 Thread Tiwei Bie
On Tue, Jul 10, 2018 at 01:51:20PM +0800, Jason Wang wrote: > On 2018年07月09日 15:22, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > --- > > drivers/s390/virtio/virtio_ccw.c | 8 > > drivers/virtio/virtio_ring.c | 2 ++ > > 2 files changed, 10 in

[virtio-dev] [PATCH net-next v1 1/5] virtio: add packed ring definitions

2018-07-09 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- include/uapi/linux/virtio_config.h | 3 +++ include/uapi/linux/virtio_ring.h | 43 ++ 2 files changed, 46 insertions(+) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index 449132c76b1c

[virtio-dev] [PATCH net-next v1 4/5] virtio_ring: add event idx support in packed ring

2018-07-09 Thread Tiwei Bie
This commit introduces the EVENT_IDX support in packed ring. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 73 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index

[virtio-dev] [PATCH net-next v1 3/5] virtio_ring: add packed ring support

2018-07-09 Thread Tiwei Bie
This commit introduces the support (without EVENT_IDX) for packed ring. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 495 ++- 1 file changed, 487 insertions(+), 8 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio

[virtio-dev] [PATCH net-next v1 5/5] virtio_ring: enable packed ring

2018-07-09 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/s390/virtio/virtio_ccw.c | 8 drivers/virtio/virtio_ring.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 8f5c1d7f751a..ff5b85736d8d 100644 --- a/drivers/s390

[virtio-dev] [PATCH net-next v1 2/5] virtio_ring: support creating packed ring

2018-07-09 Thread Tiwei Bie
This commit introduces the support for creating packed ring. All split ring specific functions are added _split suffix. Some necessary stubs for packed ring are also added. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 801 +++ include/linux

[virtio-dev] [PATCH net-next v1 0/5] virtio: support packed ring

2018-07-09 Thread Tiwei Bie
n virtqueue_add_packed() (Jason); - Some other refinements and bug fixes; Thanks! Tiwei Bie (5): virtio: add packed ring definitions virtio_ring: support creating packed ring virtio_ring: add packed ring support virtio_ring: add event idx support in packed ring virtio_ring: enable packed ri

Re: [virtio-dev] Re: [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-28 Thread Tiwei Bie
On Wed, Jun 27, 2018 at 06:08:03PM +0200, Cornelia Huck wrote: > On Tue, 26 Jun 2018 21:39:22 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 27, 2018 at 02:19:22AM +0800, Tiwei Bie wrote: > > > On Tue, Jun 26, 2018 at 03:47:28PM +0200, Halil Pasic wrote

Re: [virtio-dev] Re: [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-26 Thread Tiwei Bie
On Tue, Jun 26, 2018 at 03:47:28PM +0200, Halil Pasic wrote: > On 06/25/2018 09:19 PM, Michael S. Tsirkin wrote: > > On Mon, Jun 25, 2018 at 08:24:42PM +0800, Tiwei Bie wrote: > > > VIRTIO_F_IO_BARRIER was proposed recently to allow > > > drivers to do some opt

[virtio-dev] [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-25 Thread Tiwei Bie
can assume the device is implemented in software and runs on host CPU, and also renames this feature bit to VIRTIO_F_REAL_DEVICE correspondingly. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie --- content.tex | 22 ++ 1 file changed, 10 insertions(+), 12 deletions

Re: [virtio-dev] [PATCH v3] VIRTIO_F_IO_BARRIER: use I/O barriers in driver

2018-06-20 Thread Tiwei Bie
On Wed, Jun 20, 2018 at 05:02:26PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 20, 2018 at 09:40:50PM +0800, Tiwei Bie wrote: > > On Wed, Jun 20, 2018 at 06:31:16AM +0300, Michael S. Tsirkin wrote: > > > On Thu, May 10, 2018 at 11:41:26PM +0800, Tiwei Bie wrote: > > &g

Re: [virtio-dev] [PATCH v3] VIRTIO_F_IO_BARRIER: use I/O barriers in driver

2018-06-20 Thread Tiwei Bie
On Wed, Jun 20, 2018 at 06:31:16AM +0300, Michael S. Tsirkin wrote: > On Thu, May 10, 2018 at 11:41:26PM +0800, Tiwei Bie wrote: > > There will be hardware virtio devices in the future, which > > require drivers to use the barriers suitable for I/O devices, > > compared

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-19 Thread Tiwei Bie
On Tue, Jun 19, 2018 at 12:46:45PM +0200, Halil Pasic wrote: > On 06/19/2018 11:14 AM, Tiwei Bie wrote: > > On Mon, Jun 18, 2018 at 07:28:33PM +0300, Michael S. Tsirkin wrote: [...] > > > > If it would be better to drop this patch, > > I'm fine with dropping

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-19 Thread Tiwei Bie
; > > On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: > > > > > > > On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic wrote: > > > > > > > > > > > > > > > > > > > > > > > > On 06/11/2018 09:56 AM, Tiw

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Tiwei Bie
On Fri, Jun 15, 2018 at 02:42:58PM +0200, Halil Pasic wrote: > On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic wrote: > > > > > > > > > On 06/11/2018 09:56 AM, Tiwei Bie wrote: > > > >

[virtio-dev] [PATCH v1] content: use a consistent wording for device status

2018-06-13 Thread Tiwei Bie
There is a part called "device status field" in a Virtio device. Currently, both of \field{status} and \field{device status} are used to refer to it, which is a bit confusing. This patch changes spec to use \field{device status} consistently. Suggested-by: Michael S. Tsirkin Signed-off

[virtio-dev] Re: [RFC] content: use a consistent wording for device status

2018-06-13 Thread Tiwei Bie
On Wed, Jun 13, 2018 at 11:05:52AM +0200, Cornelia Huck wrote: > On Tue, 12 Jun 2018 13:32:21 +0800 > Tiwei Bie wrote: > > > There is a part called "device status field" in a > > Virtio device. Currently, both of \field{status} > > and \field{device status}

[virtio-dev] [RFC] content: use a consistent wording for device status

2018-06-11 Thread Tiwei Bie
There is a part called "device status field" in a Virtio device. Currently, both of \field{status} and \field{device status} are used to refer to it, which is a bit confusing. This patch changes spec to use \field{device status} consistently. Suggested-by: Michael S. Tsirkin Signed-off

[virtio-dev] [PATCH v3] content: document SR-IOV driver requirements

2018-06-11 Thread Tiwei Bie
Document the driver requirements for the VIRTIO_F_SR_IOV feature bit. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/13 --- v2: - Fix the commit message (MST); - Improve the wording (MST); - Drop unnecessary parts (MST); v3

[virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-11 Thread Tiwei Bie
Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 --- v2: - Refine the wording (Cornelia); v3: - Refine the wording (MST); content.tex | 7 +++ 1 file changed, 7 insertions(+) diff --git a/content.tex b/content.tex index

[virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits

2018-06-11 Thread Tiwei Bie
On Mon, Jun 11, 2018 at 09:11:00AM +0200, Cornelia Huck wrote: > On Fri, 8 Jun 2018 19:05:30 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote: > > > On Fri, 8 Jun 2018 14:59:28 +0800 > > > Tiwe

Re: [virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Tiwei Bie
On Fri, Jun 08, 2018 at 02:38:57PM +0200, Cornelia Huck wrote: > On Fri, 8 Jun 2018 19:14:49 +0800 > Tiwei Bie wrote: > > > On Fri, Jun 08, 2018 at 11:12:31AM +0200, Cornelia Huck wrote: > > > On Fri, 8 Jun 2018 10:07:01 +0800 > > > Tiwei Bie wrote: >

[virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Tiwei Bie
On Fri, Jun 08, 2018 at 11:12:31AM +0200, Cornelia Huck wrote: > On Fri, 8 Jun 2018 10:07:01 +0800 > Tiwei Bie wrote: > > > Document the driver requirements for the VIRTIO_F_SR_IOV > > feature bit. > > > > Suggested-by: Michael S. Tsirkin > > Sig

[virtio-dev] [PATCH v2] content: enhance device requirements for feature bits

2018-06-08 Thread Tiwei Bie
Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 --- v2: - Refine the wording (Cornelia); content.tex | 7 +++ 1 file changed, 7 insertions(+) diff --git a/content.tex b/content.tex index f996fad..41cba41 100644 --- a

[virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits

2018-06-08 Thread Tiwei Bie
On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote: > On Fri, 8 Jun 2018 14:59:28 +0800 > Tiwei Bie wrote: > > > Suggested-by: Michael S. Tsirkin > > Signed-off-by: Tiwei Bie > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > > --- &g

[virtio-dev] [PATCH] content: enhance device requirements for feature bits

2018-06-08 Thread Tiwei Bie
Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 --- content.tex | 7 +++ 1 file changed, 7 insertions(+) diff --git a/content.tex b/content.tex index f996fad..8374d3f 100644 --- a/content.tex +++ b/content.tex @@ -125,6

[virtio-dev] [PATCH v2] content: document SR-IOV driver requirements

2018-06-07 Thread Tiwei Bie
Document the driver requirements for the VIRTIO_F_SR_IOV feature bit. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/13 --- v2: - Fix the commit message (MST); - Improve the wording (MST); - Drop unnecessary parts (MST

Re: [virtio-dev] [PATCH] content: document the behaviours for SR-IOV

2018-06-07 Thread Tiwei Bie
On Thu, Jun 07, 2018 at 10:17:09PM +0300, Michael S. Tsirkin wrote: > Subject should be "document SR-IOV driver requirements" I think. Yeah! > > On Thu, Jun 07, 2018 at 09:50:50AM +0800, Tiwei Bie wrote: > > Document the device and driver behaviours for SR-IOV. > &g

[virtio-dev] [PATCH] content: document the behaviours for SR-IOV

2018-06-06 Thread Tiwei Bie
Document the device and driver behaviours for SR-IOV. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/13 --- content.tex | 16 1 file changed, 16 insertions(+) diff --git a/content.tex b/content.tex index

Re: [virtio-dev] Re: [PATCH v3] virtio_pci: support enabling VFs

2018-06-06 Thread Tiwei Bie
On Wed, Jun 06, 2018 at 05:27:07PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 06, 2018 at 10:19:43PM +0800, Tiwei Bie wrote: > > On Wed, Jun 06, 2018 at 03:44:11PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 06, 2018 at 08:11:54PM +0800, Tiwei Bie wrote: > > >

Re: [virtio-dev] Re: [PATCH v3] virtio_pci: support enabling VFs

2018-06-06 Thread Tiwei Bie
On Wed, Jun 06, 2018 at 03:44:11PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 06, 2018 at 08:11:54PM +0800, Tiwei Bie wrote: > > On Tue, Jun 05, 2018 at 03:23:11PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 05, 2018 at 09:36:53AM +0800, Tiwei Bie wrote: > > >

Re: [virtio-dev] Re: [PATCH v3] virtio_pci: support enabling VFs

2018-06-06 Thread Tiwei Bie
On Tue, Jun 05, 2018 at 03:23:11PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 09:36:53AM +0800, Tiwei Bie wrote: > > On Mon, Jun 04, 2018 at 07:32:25PM +0300, Michael S. Tsirkin wrote: > > > On Fri, Jun 01, 2018 at 12:02:39PM +0800, Tiwei Bie wrote: > > &g

  1   2   3   >