Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-22 Thread David Stevens
> ok but how is this then used? will there be more commands to pass > this uuid to another device? This is intended to be used with the virtio video device being discussed here https://markmail.org/thread/ingyqlps4rbcuazh. I don't have a specific patch for how that will work, but it will likely

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-22 Thread Michael S. Tsirkin
On Wed, Jan 22, 2020 at 04:16:35PM +0900, David Stevens wrote: > Signed-off-by: David Stevens > --- > virtio-gpu.tex | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/virtio-gpu.tex b/virtio-gpu.tex > index af4ca61..a1f0210 100644 > --- a/virtio-gpu.tex >

[virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-21 Thread David Stevens
Signed-off-by: David Stevens --- virtio-gpu.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/virtio-gpu.tex b/virtio-gpu.tex index af4ca61..a1f0210 100644 --- a/virtio-gpu.tex +++ b/virtio-gpu.tex @@ -186,12 +186,16 @@ \subsubsection{Device Operation:

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-09 Thread Gurchetan Singh
I like the idea of having one central place in the kernel where virtio-devices get their uuid from -- i.e, no separate VM specific, device specific implementations calling into uuid_gen(). On Wed, Jan 8, 2020 at 3:20 AM David Stevens wrote: > > > Is there a specific reason why you want the host

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-09 Thread Gerd Hoffmann
Hi, > At that point, I think it's just a matter of aesthetics. I lean > slightly towards returning the uuid from the host, since that rules > out any implementation with the aforementioned race. Ok, design the API in a way that you can't get it wrong. Makes sense. I'd still name it

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-08 Thread David Stevens
> Is there a specific reason why you want the host pick the uuid? I would > let the guest define the uuid, i.e. move the uuid fields to > virtio_gpu_export_resource and scratch virtio_gpu_resp_export_resource. Sending the uuid in the original request doesn't really buy us anything, at least in

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-08 Thread Gerd Hoffmann
> +\begin{lstlisting} > +struct virtio_gpu_export_resource { > +struct virtio_gpu_ctrl_hdr hdr; > +le32 resource_id; > +le32 padding; > +}; > + > +struct virtio_gpu_resp_export_resource { > +struct virtio_gpu_ctrl_hdr hdr; > +le64 uuid_low; > +le64

[virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-08 Thread David Stevens
Signed-off-by: David Stevens --- virtio-gpu.tex | 29 + 1 file changed, 29 insertions(+) diff --git a/virtio-gpu.tex b/virtio-gpu.tex index af4ca61..522f478 100644 --- a/virtio-gpu.tex +++ b/virtio-gpu.tex @@ -186,12 +186,16 @@ \subsubsection{Device Operation: