[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-13 Thread Michael S. Tsirkin
On Wed, Apr 12, 2023 at 01:37:59PM +0800, Jason Wang wrote: > On Wed, Apr 12, 2023 at 1:25 PM Michael S. Tsirkin wrote: > > > > On Wed, Apr 12, 2023 at 12:53:52PM +0800, Jason Wang wrote: > > > On Wed, Apr 12, 2023 at 12:20 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Apr 12, 2023

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 1:25 PM Michael S. Tsirkin wrote: > > On Wed, Apr 12, 2023 at 12:53:52PM +0800, Jason Wang wrote: > > On Wed, Apr 12, 2023 at 12:20 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Apr 12, 2023 at 12:07:26PM +0800, Jason Wang wrote: > > > > On Wed, Apr 12, 2023 at 5:25 AM

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Wed, Apr 12, 2023 at 12:53:52PM +0800, Jason Wang wrote: > On Wed, Apr 12, 2023 at 12:20 PM Michael S. Tsirkin wrote: > > > > On Wed, Apr 12, 2023 at 12:07:26PM +0800, Jason Wang wrote: > > > On Wed, Apr 12, 2023 at 5:25 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Apr 11, 2023

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 12:21 PM Michael S. Tsirkin wrote: > > On Wed, Apr 12, 2023 at 12:04:45PM +0800, Jason Wang wrote: > > On Wed, Apr 12, 2023 at 3:01 AM Parav Pandit wrote: > > > > > > > > > > From: virtio-dev@lists.oasis-open.org > > > > On > > > > Behalf Of Jason Wang > > > > Sent: Mond

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 12:20 PM Michael S. Tsirkin wrote: > > On Wed, Apr 12, 2023 at 12:07:26PM +0800, Jason Wang wrote: > > On Wed, Apr 12, 2023 at 5:25 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 11, 2023 at 07:01:16PM +, Parav Pandit wrote: > > > > > > > > > From: virtio-dev@lis

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Wed, Apr 12, 2023 at 12:04:45PM +0800, Jason Wang wrote: > On Wed, Apr 12, 2023 at 3:01 AM Parav Pandit wrote: > > > > > > > From: virtio-dev@lists.oasis-open.org On > > > Behalf Of Jason Wang > > > Sent: Monday, April 10, 2023 11:29 PM > > > > > > However, it is not backward compatible, if th

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Wed, Apr 12, 2023 at 12:07:26PM +0800, Jason Wang wrote: > On Wed, Apr 12, 2023 at 5:25 AM Michael S. Tsirkin wrote: > > > > On Tue, Apr 11, 2023 at 07:01:16PM +, Parav Pandit wrote: > > > > > > > From: virtio-dev@lists.oasis-open.org > > > > On > > > > Behalf Of Jason Wang > > > > Sent:

RE: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, April 12, 2023 12:05 AM > > > It is kind of intended since it is only used for new PCI-E features: > > > > > New fields in new extended pci cap area is fine. > > Migrating old fields to be present in the new extended pci cap, is not your > intention. Right?

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 5:25 AM Michael S. Tsirkin wrote: > > On Tue, Apr 11, 2023 at 07:01:16PM +, Parav Pandit wrote: > > > > > From: virtio-dev@lists.oasis-open.org On > > > Behalf Of Jason Wang > > > Sent: Monday, April 10, 2023 11:29 PM > > > > > > However, it is not backward compatible,

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 3:01 AM Parav Pandit wrote: > > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Jason Wang > > Sent: Monday, April 10, 2023 11:29 PM > > > > However, it is not backward compatible, if the device place them in > > > extended capability, it will not work. > > > >

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Wed, Apr 12, 2023 at 12:40:53AM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Tuesday, April 11, 2023 5:25 PM > > > > On Tue, Apr 11, 2023 at 07:01:16PM +, Parav Pandit wrote: > > > > > > > From: virtio-dev@lists.oasis-open.org > > > > On Behalf Of Jason Wang > > > > S

RE: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, April 11, 2023 5:25 PM > > On Tue, Apr 11, 2023 at 07:01:16PM +, Parav Pandit wrote: > > > > > From: virtio-dev@lists.oasis-open.org > > > On Behalf Of Jason Wang > > > Sent: Monday, April 10, 2023 11:29 PM > > > > > > However, it is not backward c

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 07:01:16PM +, Parav Pandit wrote: > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Jason Wang > > Sent: Monday, April 10, 2023 11:29 PM > > > > However, it is not backward compatible, if the device place them in > > > extended capability, it will not work.

RE: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Jason Wang > Sent: Monday, April 10, 2023 11:29 PM > > However, it is not backward compatible, if the device place them in > > extended capability, it will not work. > > > > It is kind of intended since it is only used for new PCI-E feature

[virtio-dev] RE: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, April 11, 2023 10:10 AM > > well, of course, my question was for a new, future device, can we put all > capabilities in the extended space? will we be able to teach bios to access > these? Cannot speak for BIOS vendors, but from PCI spec side, the e

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 05:07:11PM +0800, Jason Wang wrote: > > now, imagine someone building a new device. if existing drivers are not > > a concern, it is possible to move capabilities all to extended space. is > > that possible while keeping the bios working? > > This is possible but I'm not su

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 02:07:27PM +, Parav Pandit wrote: > > > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Michael S. Tsirkin > > > > > > > > > now, imagine someone building a new device. if existing drivers are > > > > not a concern, it is possible to move capabil

[virtio-dev] RE: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Michael S. Tsirkin > > > > > > now, imagine someone building a new device. if existing drivers are > > > not a concern, it is possible to move capabilities all to extended > > > space. is that possible while keeping the bios wo

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 09:47:50AM -0400, Parav Pandit wrote: > > > On 4/11/2023 3:00 AM, Michael S. Tsirkin wrote: > > > > I meant, it depends on the capability semantics. Both PASID and legacy > > > MMIO don't need to be accessed by BIOS. We can't change legacy BIOS to > > > use legacy MMIO ba

RE: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, April 11, 2023 5:07 AM > This is possible but I'm not sure it's worthwhile. What happens if the device > puts all capabilities in the extended space but the bios can't scan there? We > can > place them at both but it then doesn't address the out of space iss

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Parav Pandit
On 4/11/2023 3:00 AM, Michael S. Tsirkin wrote: I meant, it depends on the capability semantics. Both PASID and legacy MMIO don't need to be accessed by BIOS. We can't change legacy BIOS to use legacy MMIO bars. Thanks makes sense. now, imagine someone building a new device. if existing

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 05:07:11PM +0800, Jason Wang wrote: > On Tue, Apr 11, 2023 at 3:00 PM Michael S. Tsirkin wrote: > > > > On Tue, Apr 11, 2023 at 10:19:39AM +0800, Jason Wang wrote: > > > On Mon, Apr 10, 2023 at 6:04 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Apr 10, 2023 a

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Jason Wang
On Tue, Apr 11, 2023 at 3:00 PM Michael S. Tsirkin wrote: > > On Tue, Apr 11, 2023 at 10:19:39AM +0800, Jason Wang wrote: > > On Mon, Apr 10, 2023 at 6:04 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Apr 10, 2023 at 03:16:46PM +0800, Jason Wang wrote: > > > > On Mon, Apr 10, 2023 at 2:24 PM M

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 10:19:39AM +0800, Jason Wang wrote: > On Mon, Apr 10, 2023 at 6:04 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 10, 2023 at 03:16:46PM +0800, Jason Wang wrote: > > > On Mon, Apr 10, 2023 at 2:24 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Apr 10, 2023 a

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-10 Thread Jason Wang
On Tue, Apr 11, 2023 at 1:54 AM Parav Pandit wrote: > > Hi Jason, > > On 4/9/2023 9:36 PM, Jason Wang wrote: > > On Fri, Mar 31, 2023 at 7:00 AM Parav Pandit wrote: > >> > >> PCI device configuration space for capabilities is limited to only 192 > >> bytes shared by many PCI capabilities of gener

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-10 Thread Jason Wang
On Mon, Apr 10, 2023 at 6:04 PM Michael S. Tsirkin wrote: > > On Mon, Apr 10, 2023 at 03:16:46PM +0800, Jason Wang wrote: > > On Mon, Apr 10, 2023 at 2:24 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Apr 10, 2023 at 09:36:17AM +0800, Jason Wang wrote: > > > > On Fri, Mar 31, 2023 at 7:00 AM P

[virtio-dev] RE: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-10 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Parav Pandit > We may need it even sooner than this because the AQ patch is expanding the > structure located in legacy area. I mixed up the two structures. AQ related field expansion doesn’t need capability expansion. Sorry ab

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-10 Thread Parav Pandit
Hi Jason, On 4/9/2023 9:36 PM, Jason Wang wrote: On Fri, Mar 31, 2023 at 7:00 AM Parav Pandit wrote: PCI device configuration space for capabilities is limited to only 192 bytes shared by many PCI capabilities of generic PCI device and virtio specific. Hence, introduce virtio extended capabi

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-10 Thread Michael S. Tsirkin
On Mon, Apr 10, 2023 at 03:16:46PM +0800, Jason Wang wrote: > On Mon, Apr 10, 2023 at 2:24 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 10, 2023 at 09:36:17AM +0800, Jason Wang wrote: > > > On Fri, Mar 31, 2023 at 7:00 AM Parav Pandit wrote: > > > > > > > > PCI device configuration space for

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-10 Thread Jason Wang
On Mon, Apr 10, 2023 at 2:24 PM Michael S. Tsirkin wrote: > > On Mon, Apr 10, 2023 at 09:36:17AM +0800, Jason Wang wrote: > > On Fri, Mar 31, 2023 at 7:00 AM Parav Pandit wrote: > > > > > > PCI device configuration space for capabilities is limited to only 192 > > > bytes shared by many PCI capab

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-09 Thread Michael S. Tsirkin
On Mon, Apr 10, 2023 at 09:36:17AM +0800, Jason Wang wrote: > On Fri, Mar 31, 2023 at 7:00 AM Parav Pandit wrote: > > > > PCI device configuration space for capabilities is limited to only 192 > > bytes shared by many PCI capabilities of generic PCI device and virtio > > specific. > > > > Hence, i

Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-09 Thread Jason Wang
On Fri, Mar 31, 2023 at 7:00 AM Parav Pandit wrote: > > PCI device configuration space for capabilities is limited to only 192 > bytes shared by many PCI capabilities of generic PCI device and virtio > specific. > > Hence, introduce virtio extended capability that uses PCI Express > extended capab

[virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-03-30 Thread Parav Pandit
PCI device configuration space for capabilities is limited to only 192 bytes shared by many PCI capabilities of generic PCI device and virtio specific. Hence, introduce virtio extended capability that uses PCI Express extended capability. Subsequent patch uses this virtio extended capability. Co-