Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-11 Thread Sameeh Jubran
On Mon, Dec 10, 2018 at 7:46 PM Michael S. Tsirkin wrote: > > On Mon, Dec 10, 2018 at 05:34:53PM +0200, Sameeh Jubran wrote: > > On Mon, Dec 10, 2018 at 5:13 PM Sameeh Jubran wrote: > > > > > > On Sat, Dec 8, 2018 at 3:54 AM si-wei liu wrote: > > > > > > > > > > > > > > > > On 12/05/2018 08:18

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-10 Thread Michael S. Tsirkin
On Mon, Dec 10, 2018 at 05:34:53PM +0200, Sameeh Jubran wrote: > On Mon, Dec 10, 2018 at 5:13 PM Sameeh Jubran wrote: > > > > On Sat, Dec 8, 2018 at 3:54 AM si-wei liu wrote: > > > > > > > > > > > > On 12/05/2018 08:18 AM, Sameeh Jubran wrote: > > > > Hi all, > > > > > > > > This is a followup

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-10 Thread Sameeh Jubran
On Mon, Dec 10, 2018 at 5:13 PM Sameeh Jubran wrote: > > On Sat, Dec 8, 2018 at 3:54 AM si-wei liu wrote: > > > > > > > > On 12/05/2018 08:18 AM, Sameeh Jubran wrote: > > > Hi all, > > > > > > This is a followup on the discussion in the DPDK and Virtio monthly > > > meeting. > > > > > > Michael

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-10 Thread Sameeh Jubran
On Sat, Dec 8, 2018 at 3:54 AM si-wei liu wrote: > > > > On 12/05/2018 08:18 AM, Sameeh Jubran wrote: > > Hi all, > > > > This is a followup on the discussion in the DPDK and Virtio monthly meeting. > > > > Michael suggested that layer 2 tests should be created in order to > > test the PF/VF

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-07 Thread si-wei liu
On 12/05/2018 08:18 AM, Sameeh Jubran wrote: Hi all, This is a followup on the discussion in the DPDK and Virtio monthly meeting. Michael suggested that layer 2 tests should be created in order to test the PF/VF behavior in different scenarios without using VMs at all which should speed up

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-05 Thread Sameeh Jubran
Hi all, This is a followup on the discussion in the DPDK and Virtio monthly meeting. Michael suggested that layer 2 tests should be created in order to test the PF/VF behavior in different scenarios without using VMs at all which should speed up the testing process. The following "mausezahn"

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-03 Thread Michael S. Tsirkin
On Mon, Dec 03, 2018 at 06:09:19PM -0800, si-wei liu wrote: > > I agree. But a single flag is not much of an extension. We don't even > > need it in netlink, can be anywhere in e.g. sysfs. > I think sysfs attribute is for exposing the capability, while you still need > to set up macvtap with some

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-03 Thread si-wei liu
On 11/29/2018 10:21 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 02:53:08PM -0800, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2018 at 02:53:08PM -0800, si-wei liu wrote: > > > On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: > > > > > > On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: > > > > On Wed, Nov 28, 2018 at 12:28:42PM -0800,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 07:08 PM, Samudrala, Sridhar wrote: On 11/29/2018 4:24 PM, si-wei liu wrote: On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread Samudrala, Sridhar
On 11/29/2018 4:24 PM, si-wei liu wrote: On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread Michael S. Tsirkin
On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: > > > On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: > > > On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: > > > > On Wed, Nov 28, 2018 at 09:31:32AM -0800,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread si-wei liu
On 11/28/2018 12:43 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: On Wed, Nov

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread Michael S. Tsirkin
On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: > > > On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: > > > On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: > > > > On Wed, Nov 28, 2018 at 09:31:32AM -0800,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread si-wei liu
On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 09:31:32AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:08 AM, Michael S. Tsirkin wrote: On

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread Michael S. Tsirkin
On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: > On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: > > On Wed, Nov 28, 2018 at 09:31:32AM -0800, Samudrala, Sridhar wrote: > > > > > > On 11/28/2018 9:08 AM, Michael S. Tsirkin wrote: > > > > On Mon, Nov 26, 2018 at 12:22:56PM

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread Michael S. Tsirkin
On Wed, Nov 28, 2018 at 09:31:32AM -0800, Samudrala, Sridhar wrote: > > > On 11/28/2018 9:08 AM, Michael S. Tsirkin wrote: > > On Mon, Nov 26, 2018 at 12:22:56PM -0800, Samudrala, Sridhar wrote: > > > > Update: > > > > I have just set the vf mac's address to 0 (ip link set ens2f0 vf 1 mac > > >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread Samudrala, Sridhar
On 11/28/2018 9:08 AM, Michael S. Tsirkin wrote: On Mon, Nov 26, 2018 at 12:22:56PM -0800, Samudrala, Sridhar wrote: Update: I have just set the vf mac's address to 0 (ip link set ens2f0 vf 1 mac 00:00:00:00:00:00) after unplugging it (the primary device) and the pings started working again

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread Michael S. Tsirkin
On Mon, Nov 26, 2018 at 12:22:56PM -0800, Samudrala, Sridhar wrote: > > Update: > > I have just set the vf mac's address to 0 (ip link set ens2f0 vf 1 mac > > 00:00:00:00:00:00) after unplugging it (the primary device) and the > > pings started working again on the failover interface. So it seems

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-27 Thread Sameeh Jubran
On Mon, Nov 26, 2018 at 10:22 PM Samudrala, Sridhar wrote: > > On 11/26/2018 7:43 AM, Sameeh Jubran wrote: > > On Mon, Nov 26, 2018 at 5:13 PM Sameeh Jubran wrote: > >> On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote: > >>> On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote:

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-26 Thread Samudrala, Sridhar
On 11/26/2018 7:43 AM, Sameeh Jubran wrote: On Mon, Nov 26, 2018 at 5:13 PM Sameeh Jubran wrote: On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote: On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote: On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: Great to see

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-26 Thread Sameeh Jubran
On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote: > > On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote: > > On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: > > > > > > Great to see you making progress on this! > > > Some comments below: > > > > > > On Wed, Nov 21,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-22 Thread Michael S. Tsirkin
On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote: > On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: > > > > Great to see you making progress on this! > > Some comments below: > > > > On Wed, Nov 21, 2018 at 05:39:38PM +0200, Sameeh Jubran wrote: > > > I have created a setup

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-22 Thread Sameeh Jubran
On Thu, Nov 22, 2018 at 1:51 AM Samudrala, Sridhar wrote: > > On 11/21/2018 12:04 PM, Sameeh Jubran wrote: > > On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: > >> Great to see you making progress on this! > >> Some comments below: > >> > >> On Wed, Nov 21, 2018 at 05:39:38PM +0200,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-21 Thread Samudrala, Sridhar
On 11/21/2018 12:04 PM, Sameeh Jubran wrote: On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: Great to see you making progress on this! Some comments below: On Wed, Nov 21, 2018 at 05:39:38PM +0200, Sameeh Jubran wrote: I have created a setup which has two hosts (host A and host B)

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-21 Thread Sameeh Jubran
On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: > > Great to see you making progress on this! > Some comments below: > > On Wed, Nov 21, 2018 at 05:39:38PM +0200, Sameeh Jubran wrote: > > I have created a setup which has two hosts (host A and host B) with X710 10G > > cards connected

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-21 Thread Michael S. Tsirkin
Great to see you making progress on this! Some comments below: On Wed, Nov 21, 2018 at 05:39:38PM +0200, Sameeh Jubran wrote: > I have created a setup which has two hosts (host A and host B) with X710 10G > cards connected back to back. On one host (I'll refer to this host as host A) > I > have

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-21 Thread Sameeh Jubran
Hi all, It's been a while since the last discussion here. I have been working on implementing the standby feature in Qemu. I have tried multiple approaches for implementation and in the end decided to implement using the hotplug/unplug infrastructure for multiple reasons which I'll go over when I

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-18 Thread Michael S. Tsirkin
On Wed, Oct 10, 2018 at 06:26:50PM -0700, Siwei Liu wrote: > On Fri, Oct 5, 2018 at 12:18 PM Michael S. Tsirkin wrote: > > > > On Thu, Oct 04, 2018 at 05:03:14PM -0700, Siwei Liu wrote: > > > On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: > > > > > > > > On Tue, Oct 02, 2018 at

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-18 Thread Michael S. Tsirkin
On Thu, Oct 18, 2018 at 04:20:13PM -0700, Siwei Liu wrote: > To be honest, I don't understand why there's resistance of using PV to > initiate datapath switching, I see no resistance. I see lack of man-power. Any extension needs: 1- guest driver support 2- qemu support 3- spec documentation

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-18 Thread Siwei Liu
To be honest, I don't understand why there's resistance of using PV to initiate datapath switching, and the point of relying on very specifc PF behavior for datapath swtiching, There's even no point to alter the SR-IOV driver model to accomondate the (zero) downtime requirement, how potentally can

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-10 Thread Siwei Liu
On Fri, Oct 5, 2018 at 12:18 PM Michael S. Tsirkin wrote: > > On Thu, Oct 04, 2018 at 05:03:14PM -0700, Siwei Liu wrote: > > On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: > > > > The VF's MAC can be updated by

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-10 Thread Samudrala, Sridhar
On 10/10/2018 7:40 AM, Michael S. Tsirkin wrote: On Thu, Oct 04, 2018 at 10:17:04PM -0700, Samudrala, Sridhar wrote: On 10/4/2018 5:03 PM, Siwei Liu wrote: On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: The VF's MAC can be

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-10 Thread Michael S. Tsirkin
On Tue, Oct 09, 2018 at 01:06:59AM +0300, Sameeh Jubran wrote: > Hi All, > > I have been busy trying to figure out how to implement the feature and > got very confused with the current open questions and tier impact. > > As I have stated earlier, I thought about doing the following: > > 1 -

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-10 Thread Michael S. Tsirkin
On Thu, Oct 04, 2018 at 10:17:04PM -0700, Samudrala, Sridhar wrote: > On 10/4/2018 5:03 PM, Siwei Liu wrote: > > On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: > > > On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: > > > > The VF's MAC can be updated by PF/host on the fly at

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-08 Thread Sameeh Jubran
Hi All, I have been busy trying to figure out how to implement the feature and got very confused with the current open questions and tier impact. As I have stated earlier, I thought about doing the following: 1 - Have an id for virtio-net (the standby device) and one for the vfio device

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-05 Thread Michael S. Tsirkin
On Thu, Oct 04, 2018 at 05:03:14PM -0700, Siwei Liu wrote: > On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: > > > > On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: > > > The VF's MAC can be updated by PF/host on the fly at any time. One can > > > start with a random MAC but

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-04 Thread Samudrala, Sridhar
On 10/4/2018 5:03 PM, Siwei Liu wrote: On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: The VF's MAC can be updated by PF/host on the fly at any time. One can start with a random MAC but use group ID to pair device instead.

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-04 Thread Siwei Liu
On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: > > On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: > > The VF's MAC can be updated by PF/host on the fly at any time. One can > > start with a random MAC but use group ID to pair device instead. And > > only update MAC address

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-02 Thread Michael S. Tsirkin
On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: > The VF's MAC can be updated by PF/host on the fly at any time. One can > start with a random MAC but use group ID to pair device instead. And > only update MAC address to the real one when moving MAC filter around > after PV says OK to

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-10-02 Thread Siwei Liu
On Thu, Sep 27, 2018 at 9:32 AM Michael S. Tsirkin wrote: > > On Wed, Sep 26, 2018 at 05:18:38PM -0700, Siwei Liu wrote: > > On Thu, Sep 20, 2018 at 7:23 PM, Michael S. Tsirkin wrote: > > > On Thu, Sep 20, 2018 at 04:57:56PM -0700, Siwei Liu wrote: > > >> On Wed, Sep 19, 2018 at 8:11 PM, Michael

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-30 Thread Sameeh Jubran
I have created the following pacth which implements the basic functionality of hiding and plugging the primary device upon acking the standby feature. It's not currently implemented for vfio devices but for e1000 as I don't have access to vfio device on my current setup, however the implementation

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-27 Thread Michael S. Tsirkin
On Thu, Sep 27, 2018 at 10:23:17AM -0700, Samudrala, Sridhar wrote: > > On 9/27/2018 9:17 AM, Michael S. Tsirkin wrote: > > On Thu, Sep 27, 2018 at 10:17:37AM +0300, Sameeh Jubran wrote: > > > What do you think about the following alternative implementation which > > > uses cross id validation. >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-27 Thread Michael S. Tsirkin
On Thu, Sep 27, 2018 at 10:17:37AM +0300, Sameeh Jubran wrote: > What do you think about the following alternative implementation which > uses cross id validation. > > -device > virtio-net,standby=,id= > -vfio > #address,id=,primary= virtio is a standby device, isn't it? Besides that I don't

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-26 Thread Siwei Liu
On Thu, Sep 20, 2018 at 7:23 PM, Michael S. Tsirkin wrote: > On Thu, Sep 20, 2018 at 04:57:56PM -0700, Siwei Liu wrote: >> On Wed, Sep 19, 2018 at 8:11 PM, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 11:48:46AM -0700, Siwei Liu wrote: >> >> On Tue, Sep 18, 2018 at 8:31 AM, Michael S.

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-20 Thread Michael S. Tsirkin
On Thu, Sep 20, 2018 at 10:23:22PM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 20, 2018 at 04:57:56PM -0700, Siwei Liu wrote: > > On Wed, Sep 19, 2018 at 8:11 PM, Michael S. Tsirkin wrote: > > > On Tue, Sep 18, 2018 at 11:48:46AM -0700, Siwei Liu wrote: > > >> On Tue, Sep 18, 2018 at 8:31 AM,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-20 Thread Michael S. Tsirkin
On Thu, Sep 20, 2018 at 04:57:56PM -0700, Siwei Liu wrote: > On Wed, Sep 19, 2018 at 8:11 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 18, 2018 at 11:48:46AM -0700, Siwei Liu wrote: > >> On Tue, Sep 18, 2018 at 8:31 AM, Michael S. Tsirkin > >> wrote: > >> > On Tue, Sep 18, 2018 at 10:13:37AM

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-20 Thread Siwei Liu
On Wed, Sep 19, 2018 at 8:11 PM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 11:48:46AM -0700, Siwei Liu wrote: >> On Tue, Sep 18, 2018 at 8:31 AM, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 10:13:37AM -0500, Venu Busireddy wrote: >> >> On 2018-09-18 09:35:48 -0400, Michael

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-19 Thread Sameeh Jubran
On Tue, Sep 18, 2018 at 4:25 PM Michael S. Tsirkin wrote: > > On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: > > On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: > > > > > > On Wed, 12 Sep 2018 11:22:12 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed, Sep 12,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-19 Thread Michael S. Tsirkin
On Tue, Sep 18, 2018 at 11:48:46AM -0700, Siwei Liu wrote: > On Tue, Sep 18, 2018 at 8:31 AM, Michael S. Tsirkin wrote: > > On Tue, Sep 18, 2018 at 10:13:37AM -0500, Venu Busireddy wrote: > >> On 2018-09-18 09:35:48 -0400, Michael S. Tsirkin wrote: > >> > On Tue, Sep 18, 2018 at 12:20:52PM +0200,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-19 Thread Michael S. Tsirkin
On Tue, Sep 18, 2018 at 12:10:54PM -0700, Siwei Liu wrote: > On Tue, Sep 18, 2018 at 11:39 AM, Michael S. Tsirkin wrote: > > On Tue, Sep 18, 2018 at 11:30:27AM -0700, Siwei Liu wrote: > >> On Tue, Sep 18, 2018 at 6:25 AM, Michael S. Tsirkin > >> wrote: > >> > On Tue, Sep 18, 2018 at 01:37:35PM

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Samudrala, Sridhar
On 9/18/2018 6:25 AM, Michael S. Tsirkin wrote: On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: On Wed, 12 Sep 2018 11:22:12 -0400 "Michael S. Tsirkin" wrote: On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Siwei Liu
On Tue, Sep 18, 2018 at 11:39 AM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 11:30:27AM -0700, Siwei Liu wrote: >> On Tue, Sep 18, 2018 at 6:25 AM, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: >> >> On Tue, Sep 18, 2018 at 1:21 PM

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Siwei Liu
On Tue, Sep 18, 2018 at 8:31 AM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 10:13:37AM -0500, Venu Busireddy wrote: >> On 2018-09-18 09:35:48 -0400, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 12:20:52PM +0200, Cornelia Huck wrote: >> > > On Wed, 12 Sep 2018 11:22:12 -0400 >>

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Michael S. Tsirkin
On Tue, Sep 18, 2018 at 11:30:27AM -0700, Siwei Liu wrote: > On Tue, Sep 18, 2018 at 6:25 AM, Michael S. Tsirkin wrote: > > On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: > >> On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: > >> > > >> > On Wed, 12 Sep 2018 11:22:12 -0400 >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Siwei Liu
On Tue, Sep 18, 2018 at 6:25 AM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: >> On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: >> > >> > On Wed, 12 Sep 2018 11:22:12 -0400 >> > "Michael S. Tsirkin" wrote: >> > >> > > On Wed, Sep 12, 2018 at

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Michael S. Tsirkin
On Tue, Sep 18, 2018 at 10:13:37AM -0500, Venu Busireddy wrote: > On 2018-09-18 09:35:48 -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 18, 2018 at 12:20:52PM +0200, Cornelia Huck wrote: > > > On Wed, 12 Sep 2018 11:22:12 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed, Sep 12,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Venu Busireddy
On 2018-09-18 09:35:48 -0400, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 12:20:52PM +0200, Cornelia Huck wrote: > > On Wed, 12 Sep 2018 11:22:12 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar wrote: > > > > > > > > > > > >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Michael S. Tsirkin
On Tue, Sep 18, 2018 at 12:20:52PM +0200, Cornelia Huck wrote: > On Wed, 12 Sep 2018 11:22:12 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar wrote: > > > > > > > > > On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: > > > > On Wed, Aug 15,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Michael S. Tsirkin
On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: > On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: > > > > On Wed, 12 Sep 2018 11:22:12 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar wrote: > > > > > > > > > > > >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Sameeh Jubran
On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: > > On Wed, 12 Sep 2018 11:22:12 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar wrote: > > > > > > > > > On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: > > > > On Wed, Aug 15, 2018 at

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-18 Thread Cornelia Huck
On Wed, 12 Sep 2018 11:22:12 -0400 "Michael S. Tsirkin" wrote: > On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar wrote: > > > > > > On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: > > > On Wed, Aug 15, 2018 at 11:49:15AM -0700, Sridhar Samudrala wrote: > > > >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-12 Thread Michael S. Tsirkin
On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar wrote: > > > On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: > > On Wed, Aug 15, 2018 at 11:49:15AM -0700, Sridhar Samudrala wrote: > > > VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net > > > device to act as a

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-12 Thread Samudrala, Sridhar
On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: On Wed, Aug 15, 2018 at 11:49:15AM -0700, Sridhar Samudrala wrote: VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. Signed-off-by: Sridhar Samudrala

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-07 Thread Michael S. Tsirkin
On Wed, Aug 15, 2018 at 11:49:15AM -0700, Sridhar Samudrala wrote: > VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net > device to act as a standby for another device with the same MAC address. > > Signed-off-by: Sridhar Samudrala > Acked-by: Cornelia Huck > Fixes:

[virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-08-15 Thread Sridhar Samudrala
VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. Signed-off-by: Sridhar Samudrala Acked-by: Cornelia Huck Fixes: https://github.com/oasis-tcs/virtio-spec/issues/18 --- content.tex | 8 1