[virtio-dev] RE: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Friday, July 7, 2023 5:31 AM > ok getting there. mostly notification needs a bit more work but it's close. Fixed all the comments in v13. Thanks.

[virtio-dev] Re: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 01:26:56PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Friday, July 7, 2023 5:31 AM > > [..] > > > +For VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE and > > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ commands, the driver > > SHOULD set > > > +\field{offse

[virtio-dev] RE: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Friday, July 7, 2023 5:31 AM [..] > > +For VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE and > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ commands, the driver > SHOULD set > > +\field{offset} and the length of the \field{data} to refer to a > > +single field within the v

[virtio-dev] Re: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 06:54:01AM +0300, Parav Pandit wrote: > Introduce group member legacy common configuration and legacy device > configuration access read/write commands. > > Group member legacy registers access commands enable group owner driver > software to access legacy registers on beha