[virtio-dev] RE: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 4:56 AM > > On Wed, Feb 08, 2023 at 10:20:08AM +0800, Heng Qi wrote: > > > > > > 在 2023/2/7 下午10:29, Michael S. Tsirkin 写道: > > > On Tue, Feb 07, 2023 at 12:51:26PM +, Parav Pandit wrote: > > > > > From: Xuan Zhuo > > > > >

[virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 10:20:08AM +0800, Heng Qi wrote: > > > 在 2023/2/7 下午10:29, Michael S. Tsirkin 写道: > > On Tue, Feb 07, 2023 at 12:51:26PM +, Parav Pandit wrote: > > > > From: Xuan Zhuo > > > > Sent: Tuesday, February 7, 2023 6:50 AM > > > > > > > > On Tue, 7 Feb 2023 13:25:13 +0200,

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Xuan Zhuo
On Tue, 7 Feb 2023 10:28:37 -0500, "Michael S. Tsirkin" wrote: > On Tue, Feb 07, 2023 at 03:25:55PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Tuesday, February 7, 2023 10:09 AM > > > > > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > > > >

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, February 7, 2023 10:29 AM > > On Tue, Feb 07, 2023 at 03:25:55PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Tuesday, February 7, 2023 10:09 AM > > > > > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 03:25:55PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, February 7, 2023 10:09 AM > > > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > > > An example of a question is this: we have two RX queues say 1 and 2 > > > >

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, February 7, 2023 10:09 AM > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > > An example of a question is this: we have two RX queues say 1 and 2 > > > each with a distinct interrupt vector. coalescing is set to 10 > > > packets.

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > An example of a question is this: we have two RX queues say 1 and 2 each > > with a distinct interrupt vector. coalescing is set to 10 packets. Now > > 9 packets arrive on queue 1 and 1 on queue 2. Do you expect an > > interrupt?

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Alvaro Karsz
> An example of a question is this: we have two RX queues say 1 and 2 each > with a distinct interrupt vector. coalescing is set to 10 packets. Now > 9 packets arrive on queue 1 and 1 on queue 2. Do you expect an > interrupt? If yes which one - 1 or 2 or both? Sorry, I wasn't clear enough. In

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 04:40:56PM +0200, Alvaro Karsz wrote: > > Arguably it's true. > > It will all be up to the committee vote of course ... > > To keep things a bit safer how about we just allow commands > > without qid instead of a special qid value? > > Also if we are going to change things

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Alvaro Karsz
> Arguably it's true. > It will all be up to the committee vote of course ... > To keep things a bit safer how about we just allow commands > without qid instead of a special qid value? > Also if we are going to change things how about adding a query command too? > > Also Alvaro what is your take

[virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 12:51:26PM +, Parav Pandit wrote: > > > From: Xuan Zhuo > > Sent: Tuesday, February 7, 2023 6:50 AM > > > > On Tue, 7 Feb 2023 13:25:13 +0200, Alvaro Karsz > > wrote: > > > Hi Heng, > > > > > > > Currently, the coalescing profile is directly applied to all queues. >

[virtio-dev] RE: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, February 7, 2023 6:50 AM > > On Tue, 7 Feb 2023 13:25:13 +0200, Alvaro Karsz > wrote: > > Hi Heng, > > > > > Currently, the coalescing profile is directly applied to all queues. > > > This patch supports configuring the parameters for a specified queue. > >