[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-18 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, April 18, 2023 8:31 AM > > > > > I think in any case, using device through two transports at the same > > > time shouldn't be legal. > > > > PCI is the transport. > > ... and AQ can be a transport too :) AQ is on top of the PCI transport. :)

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-18 Thread Michael S. Tsirkin
On Tue, Apr 18, 2023 at 12:09:17PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, April 18, 2023 7:58 AM > > > I think in any case, using device through two transports at the same time > > shouldn't be legal. > > PCI is the transport. ... and AQ can be a

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-18 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, April 18, 2023 7:58 AM > I think in any case, using device through two transports at the same time > shouldn't be legal. PCI is the transport.

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-18 Thread Michael S. Tsirkin
On Tue, Apr 18, 2023 at 01:30:43AM +, Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Monday, April 17, 2023 8:37 PM > > > > > > Do you mean say we have three AQs, AQ_1, AQ_2, and AQ_3; > > > > > AQ_1 of the PF used by admin work as SIOV device create, SRIOV > > > > > MSIX > > > >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Parav Pandit
> From: Jason Wang > Sent: Monday, April 17, 2023 9:02 PM > > > Isn't the size of BAR and its cap_len exposed by the device? > > Somehow, it's more about how the hypervisor is going to use this, memory > mapped or trapping. For either case, the hypervisor needs to have virtio > knowledge in

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Parav Pandit
> From: Jason Wang > Sent: Monday, April 17, 2023 9:09 PM > Note that current transport virtqueue only allows the notification via MMIO. > It > introduces a command to get the address of the notification area. > Notifications via MMIO is the obvious choice. Command is also fine to convey

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Parav Pandit
> From: Jason Wang > Sent: Monday, April 17, 2023 8:37 PM > > > > Do you mean say we have three AQs, AQ_1, AQ_2, and AQ_3; > > > > AQ_1 of the PF used by admin work as SIOV device create, SRIOV > > > > MSIX > > > configuration. > > > > AQ_2 of the PF used for transporting legacy config access

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Jason Wang
On Tue, Apr 18, 2023 at 12:59 AM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Sunday, April 16, 2023 4:44 PM > > > > On Sun, Apr 16, 2023 at 01:41:55PM +, Parav Pandit wrote: > > > > From: virtio-comm...@lists.oasis-open.org > > > > On Behalf Of Michael S. > > > > Tsirkin

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Jason Wang
On Tue, Apr 18, 2023 at 1:23 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Sunday, April 16, 2023 11:23 PM > > > > On Fri, Apr 14, 2023 at 11:51 AM Parav Pandit wrote: > > > > > > > > > > > > > From: Jason Wang > > > > Sent: Thursday, April 13, 2023 11:38 PM > > > > > > > > > 1)

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Jason Wang
On Tue, Apr 18, 2023 at 4:29 AM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, April 17, 2023 4:27 PM > > On Mon, Apr 17, 2023 at 05:23:30PM +, Parav Pandit wrote: > > > > Things might be simplified if we use separate queues for admin, > > > > transport and legacy. >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, April 17, 2023 4:27 PM > On Mon, Apr 17, 2023 at 05:23:30PM +, Parav Pandit wrote: > > > Things might be simplified if we use separate queues for admin, > > > transport and legacy. > > > > > Do you mean say we have three AQs, AQ_1, AQ_2, and AQ_3;

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Michael S. Tsirkin
On Mon, Apr 17, 2023 at 05:23:30PM +, Parav Pandit wrote: > > Things might be simplified if we use separate queues for admin, transport > > and > > legacy. > > > Do you mean say we have three AQs, AQ_1, AQ_2, and AQ_3; > AQ_1 of the PF used by admin work as SIOV device create, SRIOV MSIX >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Parav Pandit
> From: Jason Wang > Sent: Sunday, April 16, 2023 11:23 PM > > On Fri, Apr 14, 2023 at 11:51 AM Parav Pandit wrote: > > > > > > > > > From: Jason Wang > > > Sent: Thursday, April 13, 2023 11:38 PM > > > > > > > 1) spec doesn't enforce the size of a specific structure > > > > Spec will be

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-17 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Sunday, April 16, 2023 4:44 PM > > On Sun, Apr 16, 2023 at 01:41:55PM +, Parav Pandit wrote: > > > From: virtio-comm...@lists.oasis-open.org > > > On Behalf Of Michael S. > > > Tsirkin > > > Sent: Friday, April 14, 2023 2:57 AM > > > > > Do you refer to

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-16 Thread Jason Wang
On Fri, Apr 14, 2023 at 11:51 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:38 PM > > > > > 1) spec doesn't enforce the size of a specific structure > > > Spec will be extended in coming time. > > > > It's too late to do any new restriction without

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-16 Thread Michael S. Tsirkin
On Sun, Apr 16, 2023 at 01:41:55PM +, Parav Pandit wrote: > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Michael S. Tsirkin > > Sent: Friday, April 14, 2023 2:57 AM > > > Do you refer to the trick Jason proposed where BAR0 is memory but otherwise > > matches legacy

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-16 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Michael S. Tsirkin > Sent: Friday, April 14, 2023 2:57 AM > Do you refer to the trick Jason proposed where BAR0 is memory but otherwise > matches legacy BAR0 exactly? Is this your preferred solution at this point > then? We

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-14 Thread Michael S. Tsirkin
On Fri, Apr 14, 2023 at 03:51:01AM +, Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:38 PM > > > > > 1) spec doesn't enforce the size of a specific structure > > > Spec will be extended in coming time. > > > > It's too late to do any new restriction

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-14 Thread Michael S. Tsirkin
On Fri, Apr 14, 2023 at 10:36:52AM +0800, Jason Wang wrote: > On Fri, Apr 14, 2023 at 5:08 AM Parav Pandit wrote: > > > > > > > > > From: Michael S. Tsirkin > > > Sent: Thursday, April 13, 2023 5:02 PM > > > > > This thing ... you move some code to the card and reduce the amount of > > > virtio

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-14 Thread Michael S. Tsirkin
On Fri, Apr 14, 2023 at 02:43:21AM +, Parav Pandit wrote: > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 10:37 PM > > > I'm not sure I get this. With VIRTIO_NET_F_LEGACY_HEADER, we don't need > > mediation for datapath. For the control path, mediation is a must for > > legacy

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:38 PM > > > 1) spec doesn't enforce the size of a specific structure > > Spec will be extended in coming time. > > It's too late to do any new restriction without introducing a flag. We are really diverging from the topic. I don’t think

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 11:18 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:10 PM > > > > We have two options to satisfy the requirements. > > > (partly taken/repeated from Jason's yday email). > > > > > > 1. AQ (solves reset) + notification for building

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 11:22 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:18 PM > > > > > > > > > It's a must for ABI and migration compatibility: > > > > > > > > 1) The offset is not necessarily a page boundary > > > > 2) The length is not necessarily

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:18 PM > > > > > > It's a must for ABI and migration compatibility: > > > > > > 1) The offset is not necessarily a page boundary > > > 2) The length is not necessarily times of a PAGE_SIZE > > > 3) PAGE_SIZE varies among different archs > >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:10 PM > > We have two options to satisfy the requirements. > > (partly taken/repeated from Jason's yday email). > > > > 1. AQ (solves reset) + notification for building non transitional > > device that support perform well and it is both

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 11:13 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:09 PM > > > > > Actually not, I think I've mentioned the reason for several times: > > > > It's a must for ABI and migration compatibility: > > > > 1) The offset is not

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:09 PM > > Actually not, I think I've mentioned the reason for several times: > > It's a must for ABI and migration compatibility: > > 1) The offset is not necessarily a page boundary > 2) The length is not necessarily times of a

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 3:39 AM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, April 13, 2023 1:20 PM > > > > On Thu, Apr 13, 2023 at 01:14:15PM +0800, Jason Wang wrote: > > > > The proposed solution in this series enables it and avoid per > > > > field sw > >

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 1:24 AM Parav Pandit wrote: > > > > On 4/13/2023 1:14 AM, Jason Wang wrote: > > >> For LM BAR length and number should be same between two PCI VFs. But its > >> orthogonal to this point. Such checks will be done anyway. > > > > Quoted the wrong sections, I think it should

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 10:37 PM > I'm not sure I get this. With VIRTIO_NET_F_LEGACY_HEADER, we don't need > mediation for datapath. For the control path, mediation is a must for legacy > and > it's very easy to keep it work for modern, what's wrong with that?

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 5:08 AM Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > Sent: Thursday, April 13, 2023 5:02 PM > > > This thing ... you move some code to the card and reduce the amount of > > virtio > > knowledge in software but do not eliminate it completely. > Sure.

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, April 13, 2023 5:02 PM > This thing ... you move some code to the card and reduce the amount of virtio > knowledge in software but do not eliminate it completely. Sure. Practically there is no knowledge other than transporting like a vxlan

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2023 at 01:24:24PM -0400, Parav Pandit wrote: > > > > - work for virtualization (and it work even without dedicated > > > > mediation for some setups) > > > I am not aware where can it work without mediation. Do you know any > > > specific kernel version where it actually works? >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, April 13, 2023 1:20 PM > > On Thu, Apr 13, 2023 at 01:14:15PM +0800, Jason Wang wrote: > > > The proposed solution in this series enables it and avoid per > > > field sw > > > >>> interpretation and mediation in parsing values etc. > >

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
On 4/13/2023 1:14 AM, Jason Wang wrote: For LM BAR length and number should be same between two PCI VFs. But its orthogonal to this point. Such checks will be done anyway. Quoted the wrong sections, I think it should be: " length MAY include padding, or fields unused by the driver, or

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2023 at 01:14:15PM +0800, Jason Wang wrote: > > The proposed solution in this series enables it and avoid per field sw > > >>> interpretation and mediation in parsing values etc. ... except for reset, notifications, and maybe more down the road. > > >>> I don't think it's

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-12 Thread Jason Wang
On Thu, Apr 13, 2023 at 11:31 AM Parav Pandit wrote: > > > > On 4/12/2023 9:48 PM, Jason Wang wrote: > > On Wed, Apr 12, 2023 at 10:23 PM Parav Pandit wrote: > >> > >> > >> > >>> From: Jason Wang > >>> Sent: Wednesday, April 12, 2023 2:15 AM > >>> > >>> On Wed, Apr 12, 2023 at 1:55 PM Parav

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-12 Thread Parav Pandit
On 4/12/2023 9:48 PM, Jason Wang wrote: On Wed, Apr 12, 2023 at 10:23 PM Parav Pandit wrote: From: Jason Wang Sent: Wednesday, April 12, 2023 2:15 AM On Wed, Apr 12, 2023 at 1:55 PM Parav Pandit wrote: From: Jason Wang Sent: Wednesday, April 12, 2023 1:38 AM Modern device

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-12 Thread Jason Wang
On Wed, Apr 12, 2023 at 10:23 PM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Wednesday, April 12, 2023 2:15 AM > > > > On Wed, Apr 12, 2023 at 1:55 PM Parav Pandit wrote: > > > > > > > > > > > > > From: Jason Wang > > > > Sent: Wednesday, April 12, 2023 1:38 AM > > > > > > > >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-12 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, April 12, 2023 2:15 AM > > On Wed, Apr 12, 2023 at 1:55 PM Parav Pandit wrote: > > > > > > > > > From: Jason Wang > > > Sent: Wednesday, April 12, 2023 1:38 AM > > > > > > Modern device says FEAETURE_1 must be offered and must be > > > > negotiated by >

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-12 Thread Jason Wang
On Wed, Apr 12, 2023 at 1:55 PM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Wednesday, April 12, 2023 1:38 AM > > > > Modern device says FEAETURE_1 must be offered and must be negotiated by > > driver. > > > Legacy has Mac as RW area. (hypervisor can do it). > > > Reset flow is

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, April 12, 2023 1:38 AM > > Modern device says FEAETURE_1 must be offered and must be negotiated by > driver. > > Legacy has Mac as RW area. (hypervisor can do it). > > Reset flow is difference between the legacy and modern. > > Just to make sure we're at

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 1:30 PM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Wednesday, April 12, 2023 1:15 AM > > > > Because the spec for modern device do not allow it. Discussed in these > > threads. > > > > Can you please tell me which part of the spec disallows it? There's a

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, April 12, 2023 1:15 AM > > Because the spec for modern device do not allow it. Discussed in these > threads. > > Can you please tell me which part of the spec disallows it? There's a long > discussion in the virtualization-list a few months ago about

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 1:01 PM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Wednesday, April 12, 2023 12:51 AM > > > > Yes, but this proposal will drag us back to legacy, isn't it? > No. This proposal supports the legacy transitional pci device. > > > Or if it is used only in > >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, April 12, 2023 12:51 AM > > Yes, but this proposal will drag us back to legacy, isn't it? No. This proposal supports the legacy transitional pci device. > Or if it is used only in > the vitalization environment, what's the advantages of doing it over

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Jason Wang
On Wed, Apr 12, 2023 at 12:15 PM Michael S. Tsirkin wrote: > > On Wed, Apr 12, 2023 at 11:58:39AM +0800, Jason Wang wrote: > > On Tue, Apr 11, 2023 at 6:42 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 11, 2023 at 05:01:59PM +0800, Jason Wang wrote: > > > > On Tue, Apr 11, 2023 at 3:04 PM

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Michael S. Tsirkin
On Wed, Apr 12, 2023 at 11:58:39AM +0800, Jason Wang wrote: > On Tue, Apr 11, 2023 at 6:42 PM Michael S. Tsirkin wrote: > > > > On Tue, Apr 11, 2023 at 05:01:59PM +0800, Jason Wang wrote: > > > On Tue, Apr 11, 2023 at 3:04 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Apr 11, 2023

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Jason Wang
On Tue, Apr 11, 2023 at 6:42 PM Michael S. Tsirkin wrote: > > On Tue, Apr 11, 2023 at 05:01:59PM +0800, Jason Wang wrote: > > On Tue, Apr 11, 2023 at 3:04 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 11, 2023 at 10:13:40AM +0800, Jason Wang wrote: > > > > On Mon, Apr 10, 2023 at 6:06 PM

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, April 11, 2023 5:02 AM > > The point of the capability is to allow using modern device ID so such > > guests will not even try to bind. > > It means a mediation layer is required to use. Then it's not an issue for this > simple relaxing any more? > It is

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Yan Vugenfirer
Sent from my iPhone > On 11 Apr 2023, at 13:39, Michael S. Tsirkin wrote: > > On Tue, Apr 11, 2023 at 12:19:14PM +0300, Yan Vugenfirer wrote: >>> On Tue, Apr 11, 2023 at 12:02 PM Jason Wang wrote: >>> >>> On Tue, Apr 11, 2023 at 3:04 PM Michael S. Tsirkin wrote: On Tue, Apr

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 05:01:59PM +0800, Jason Wang wrote: > On Tue, Apr 11, 2023 at 3:04 PM Michael S. Tsirkin wrote: > > > > On Tue, Apr 11, 2023 at 10:13:40AM +0800, Jason Wang wrote: > > > On Mon, Apr 10, 2023 at 6:06 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Apr 10, 2023

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 12:19:14PM +0300, Yan Vugenfirer wrote: > On Tue, Apr 11, 2023 at 12:02 PM Jason Wang wrote: > > > > On Tue, Apr 11, 2023 at 3:04 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 11, 2023 at 10:13:40AM +0800, Jason Wang wrote: > > > > On Mon, Apr 10, 2023 at 6:06 PM

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-11 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 10:13:40AM +0800, Jason Wang wrote: > On Mon, Apr 10, 2023 at 6:06 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 10, 2023 at 03:20:52PM +0800, Jason Wang wrote: > > > On Mon, Apr 10, 2023 at 2:40 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Apr 10, 2023

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-10 Thread Jason Wang
On Mon, Apr 10, 2023 at 6:06 PM Michael S. Tsirkin wrote: > > On Mon, Apr 10, 2023 at 03:20:52PM +0800, Jason Wang wrote: > > On Mon, Apr 10, 2023 at 2:40 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Apr 10, 2023 at 02:20:16PM +0800, Jason Wang wrote: > > > > On Mon, Apr 10, 2023 at 2:15 PM

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-10 Thread Michael S. Tsirkin
On Mon, Apr 10, 2023 at 03:20:52PM +0800, Jason Wang wrote: > On Mon, Apr 10, 2023 at 2:40 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 10, 2023 at 02:20:16PM +0800, Jason Wang wrote: > > > On Mon, Apr 10, 2023 at 2:15 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Apr 10, 2023

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-10 Thread Jason Wang
On Mon, Apr 10, 2023 at 2:40 PM Michael S. Tsirkin wrote: > > On Mon, Apr 10, 2023 at 02:20:16PM +0800, Jason Wang wrote: > > On Mon, Apr 10, 2023 at 2:15 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Apr 10, 2023 at 09:33:32AM +0800, Jason Wang wrote: > > > > This is fine for vDPA but not

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-10 Thread Michael S. Tsirkin
On Mon, Apr 10, 2023 at 02:20:16PM +0800, Jason Wang wrote: > On Mon, Apr 10, 2023 at 2:15 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 10, 2023 at 09:33:32AM +0800, Jason Wang wrote: > > > This is fine for vDPA but not for virtio if the design can only work > > > for some specific setups

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-10 Thread Jason Wang
On Mon, Apr 10, 2023 at 2:15 PM Michael S. Tsirkin wrote: > > On Mon, Apr 10, 2023 at 09:33:32AM +0800, Jason Wang wrote: > > This is fine for vDPA but not for virtio if the design can only work > > for some specific setups (OSes/archs). > > > > Thanks > > Well virtio legacy has a long history of

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-10 Thread Michael S. Tsirkin
On Mon, Apr 10, 2023 at 09:33:32AM +0800, Jason Wang wrote: > This is fine for vDPA but not for virtio if the design can only work > for some specific setups (OSes/archs). > > Thanks Well virtio legacy has a long history of documenting existing hacks :) But yes, VIRTIO_F_ORDER_PLATFORM has to be

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-09 Thread Jason Wang
On Fri, Apr 7, 2023 at 4:55 PM Michael S. Tsirkin wrote: > > On Fri, Mar 31, 2023 at 01:58:32AM +0300, Parav Pandit wrote: > > Legacy virtio configuration registers and adjacent > > device configuration registers are located somewhere > > in a memory BAR. > > > > A new capability supplies the