[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 4:42 PM [..] > > Can we please avoid this over engineering? > > Interface has the doors open for driver to make wise decision depending on > its environment. > > what if driver can access both with the same ease? this is the case that

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 08:35:37PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 4:29 PM > > > > The driver has a final decision. Let's make it a SHOULD and then if driver > > knows > > best then it has the choice? > > > > As you said, the driver ha

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 4:29 PM > > The driver has a final decision. Let's make it a SHOULD and then if driver > knows > best then it has the choice? > As you said, the driver has the final say. There is really no reason to complicate the spec for a narrow ca

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 08:21:13PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 3:43 PM > > > > > As the order is there anyway, why not just prescribe entries are used in > > order? > > > > > > I don't see any value in defining any order. It is an ar

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 3:43 PM > > > As the order is there anyway, why not just prescribe entries are used in > order? > > > > I don't see any value in defining any order. It is an array of entries not > > a priority > list. > > I think we are losing out. Fo

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 07:00:22PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 2:57 PM > > > > I am just saying to keep things simple. Let driver choose any entry it > > > wants to > > use instead of device deciding on priority and hints etc. > >

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 07:17:14AM +0300, Parav Pandit wrote: > This patch links how in a PCI transport a group owner can access group > member (PCI VFs) legacy registers using a legacy registers access > commands using administration virtqueue infrastructure. > > Additionally it extend the PCI no

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 2:57 PM > > I am just saying to keep things simple. Let driver choose any entry it > > wants to > use instead of device deciding on priority and hints etc. > > Let's say driver can support both types which to choose? Any entry that dri

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 06:53:55PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 2:48 PM > > > > > The driver of the owner device can send a driver notification to the > > > member device by executing > > VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE >

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 2:48 PM > > The driver of the owner device can send a driver notification to the > > member device by executing > VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE > > with the \field{offset} matching \field{Queue Notify} and the > > \field{dat

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 06:16:10PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 2:06 PM > > > > But again even if you add it there, you can not claim it's exactly the same > > as > > legacy because the address is different, the address type is diffe

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 2:06 PM > > But again even if you add it there, you can not claim it's exactly the same as > legacy because the address is different, the address type is different, the > driver > is different (this is owner driver) and even the device

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 05:47:08PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 1:34 PM > > > > On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin > > > > Sent: Thursday, July 6, 2023 12:42

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 1:34 PM > > On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Thursday, July 6, 2023 12:42 PM > > > > > > We will need to detail how notifications work though. The reason i

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 12:42 PM > > > > We will need to detail how notifications work though. The reason is that the > > legacy notifications are received by owner driver (which is not legac

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 04:58:51PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 12:42 PM > > > > We will need to detail how notifications work though. The reason is that the > > legacy notifications are received by owner driver (which is not legac

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 12:42 PM > > We will need to detail how notifications work though. The reason is that the > legacy notifications are received by owner driver (which is not legacy!) and > forwarded to device. > We need to explain exactly how this is don

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 12:51 PM > I don't see a statement that devices MAY support > VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY > with entries returning just owner, just member, or both. > Ok. understood. >From the driver notifications wording it didn't imply that

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Cornelia Huck > Sent: Thursday, July 6, 2023 12:47 PM > > On Thu, Jul 06 2023, Parav Pandit wrote: > > >> From: Cornelia Huck > >> Sent: Thursday, July 6, 2023 12:28 PM > >> > >> On Thu, Jul 06 2023, Parav Pandit wrote: > >> > >> > diff --git a/transport-pci-legacy-regs.tex > >> >

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 04:45:50PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 12:39 PM > > > > > +The group owner device or the group member device or both MAY > > > > +support driver notifications region. > > > > > > Make this "a driver notific

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Thursday, July 6, 2023 12:28 PM >> >> On Thu, Jul 06 2023, Parav Pandit wrote: >> >> > diff --git a/transport-pci-legacy-regs.tex >> > b/transport-pci-legacy-regs.tex new file mode 100644 index >> > 000..ceea28c >> >

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 12:39 PM > > > +The group owner device or the group member device or both MAY > > > +support driver notifications region. > > > > Make this "a driver notification region"? > > I think in fact for conformance we can just refer to suppor

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 04:33:01PM +, Parav Pandit wrote: > > > > From: Cornelia Huck > > Sent: Thursday, July 6, 2023 12:28 PM > > > > On Thu, Jul 06 2023, Parav Pandit wrote: > > > > > diff --git a/transport-pci-legacy-regs.tex > > > b/transport-pci-legacy-regs.tex new file mode 100644

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 06:28:21PM +0200, Cornelia Huck wrote: > On Thu, Jul 06 2023, Parav Pandit wrote: > > > diff --git a/transport-pci-legacy-regs.tex b/transport-pci-legacy-regs.tex > > new file mode 100644 > > index 000..ceea28c > > --- /dev/null > > +++ b/transport-pci-legacy-regs.tex

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Cornelia Huck > Sent: Thursday, July 6, 2023 12:28 PM > > On Thu, Jul 06 2023, Parav Pandit wrote: > > > diff --git a/transport-pci-legacy-regs.tex > > b/transport-pci-legacy-regs.tex new file mode 100644 index > > 000..ceea28c > > --- /dev/null > > +++ b/transport-pci-legacy-reg

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: > diff --git a/transport-pci-legacy-regs.tex b/transport-pci-legacy-regs.tex > new file mode 100644 > index 000..ceea28c > --- /dev/null > +++ b/transport-pci-legacy-regs.tex > @@ -0,0 +1,42 @@ > +\subsection{Legacy Interface: Group member device Confi