Re: [virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-11-09 Thread Paolo Bonzini
It'd always be a write followed by a read. Usually the write provides the number of a register to be read. The opposite order does not make much sense. Paolo Il gio 5 nov 2020, 07:35 Jie Deng ha scritto: > > On 2020/10/31 21:58, Paolo Bonzini wrote: > > On 27/10/20 12:20, Michael S. Tsirkin wr

Re: [virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-11-09 Thread Jie Deng
On 2020/11/5 14:35, Jie Deng wrote: On 2020/10/31 21:58, Paolo Bonzini wrote: On 27/10/20 12:20, Michael S. Tsirkin wrote: The I2C doesn't support segments numbering and sorting. So if one creates a multi-segment transaction, then he/she should keep the segments in order. Thanks. Fine, but

Re: [virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-11-04 Thread Jie Deng
On 2020/10/31 21:58, Paolo Bonzini wrote: On 27/10/20 12:20, Michael S. Tsirkin wrote: The I2C doesn't support segments numbering and sorting. So if one creates a multi-segment transaction, then he/she should keep the segments in order. Thanks. Fine, but I see no flags to signal start/end of

Re: [virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-10-31 Thread Paolo Bonzini
On 27/10/20 12:20, Michael S. Tsirkin wrote: >> The I2C doesn't support segments numbering and sorting. >> So if one creates a multi-segment transaction, then he/she should keep the >> segments in order. >> >> Thanks. > Fine, but I see no flags to signal start/end of such a transaction. > In theo

Re: [virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-10-27 Thread Michael S. Tsirkin
On Mon, Oct 26, 2020 at 09:22:07AM +0800, Jie Deng wrote: > On 2020/10/24 0:00, Michael S. Tsirkin wrote: > > > On Fri, Oct 23, 2020 at 02:51:25PM +0800, Jie Deng wrote: > > > + > > > +The driver queues requests to the virtqueues, and they are used by the > > > +device. The request is the represen

[virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-10-26 Thread Jie Deng
On 2020/10/26 9:22, Jie Deng wrote: On 2020/10/24 0:00, Michael S. Tsirkin wrote: On Fri, Oct 23, 2020 at 02:51:25PM +0800, Jie Deng wrote: + +The driver queues requests to the virtqueues, and they are used by the +device. The request is the representation of one segment of an I2C +transactio

Re: [virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-10-25 Thread Jie Deng
On 2020/10/24 0:00, Michael S. Tsirkin wrote: On Fri, Oct 23, 2020 at 02:51:25PM +0800, Jie Deng wrote: + +The driver queues requests to the virtqueues, and they are used by the +device. The request is the representation of one segment of an I2C +transaction. Each request is of form: + +\begin{

[virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification

2020-10-23 Thread Michael S. Tsirkin
On Fri, Oct 23, 2020 at 02:51:25PM +0800, Jie Deng wrote: > virtio-i2c is a virtual I2C adapter device. It provides a way > to flexibly communicate with the I2C slave devices from the guest. > > This patch adds the specification for this device. > > Signed-off-by: Jie Deng > --- > conformance.te