[virtio-dev] RE: [PATCH v2 1/2] transport-pci: Introduce legacy registers access commands

2023-05-17 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, May 17, 2023 1:45 AM > > On Sat, May 06, 2023 at 03:01:34AM +0300, Parav Pandit wrote: > > +\begin{lstlisting} > > +struct virtio_admin_cmd_lreg_wr_data { > > + u8 offset; /* Starting byte offset of the register(s) to write */ > > + u8

[virtio-dev] Re: [PATCH v2 1/2] transport-pci: Introduce legacy registers access commands

2023-05-16 Thread Michael S. Tsirkin
On Sat, May 06, 2023 at 03:01:34AM +0300, Parav Pandit wrote: > +\begin{lstlisting} > +struct virtio_admin_cmd_lreg_wr_data { > + u8 offset; /* Starting byte offset of the register(s) to write */ > + u8 register[]; > +}; > +\end{lstlisting} So to summarize, I think the main comment here