[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-02-08 Thread Michael S. Tsirkin
On Wed, Feb 09, 2022 at 10:27:25AM +0800, Jason Wang wrote: > > 在 2022/1/30 下午11:30, Michael S. Tsirkin 写道: > > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: > > > On 1/30/2022 4:41 PM, Michael S. Tsirkin wrote: > > > > On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max Gurtovoy wrote:

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-02-08 Thread Jason Wang
在 2022/1/30 下午11:30, Michael S. Tsirkin 写道: On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: On 1/30/2022 4:41 PM, Michael S. Tsirkin wrote: On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max Gurtovoy wrote: On 1/30/2022 11:40 AM, Michael S. Tsirkin wrote: On Sun, Jan 30, 2022 at

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-02-01 Thread Michael S. Tsirkin
On Tue, Feb 01, 2022 at 06:01:34PM +0100, Cornelia Huck wrote: > On Tue, Feb 01 2022, Halil Pasic wrote: > > > On Mon, 31 Jan 2022 18:10:39 +0100 > > Cornelia Huck wrote: > > > >> On Mon, Jan 31 2022, Halil Pasic wrote: > >> > >> > On Mon, 31 Jan 2022 09:52:54 -0500 > >> > "Michael S.

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-02-01 Thread Cornelia Huck
On Tue, Feb 01 2022, Halil Pasic wrote: > On Mon, 31 Jan 2022 18:10:39 +0100 > Cornelia Huck wrote: > >> On Mon, Jan 31 2022, Halil Pasic wrote: >> >> > On Mon, 31 Jan 2022 09:52:54 -0500 >> > "Michael S. Tsirkin" wrote: >> > >> >> On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-02-01 Thread Halil Pasic
On Mon, 31 Jan 2022 18:10:39 +0100 Cornelia Huck wrote: > On Mon, Jan 31 2022, Halil Pasic wrote: > > > On Mon, 31 Jan 2022 09:52:54 -0500 > > "Michael S. Tsirkin" wrote: > > > >> On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: > >> > On Mon, Jan 31 2022, "Michael S.

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Michael S. Tsirkin
On Mon, Jan 31, 2022 at 06:10:39PM +0100, Cornelia Huck wrote: > On Mon, Jan 31 2022, Halil Pasic wrote: > > > On Mon, 31 Jan 2022 09:52:54 -0500 > > "Michael S. Tsirkin" wrote: > > > >> On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: > >> > On Mon, Jan 31 2022, "Michael S.

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, Halil Pasic wrote: > On Mon, 31 Jan 2022 09:52:54 -0500 > "Michael S. Tsirkin" wrote: > >> On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: >> > On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: >> > >> > > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, Halil Pasic wrote: > On Mon, 31 Jan 2022 10:16:43 +0100 > Cornelia Huck wrote: >> For ccw, I'd do something like >> >> #define CCW_CMD_READ_MISC_CONF 0x82 >> >> struct virtio_misc_conf { >>be16 admin_queue_index; >> }; >> >> bound to revision 3, which gets a

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Halil Pasic
On Mon, 31 Jan 2022 09:52:54 -0500 "Michael S. Tsirkin" wrote: > On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: > > On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > > > > > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: > > >> On Sun, Jan 30 2022, "Michael

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Michael S. Tsirkin
On Mon, Jan 31, 2022 at 04:47:29PM +0100, Halil Pasic wrote: > On Mon, 31 Jan 2022 10:16:43 +0100 > Cornelia Huck wrote: > > > On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: > > > > > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: > > >> > > >> On 1/30/2022 4:41 PM, Michael

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Michael S. Tsirkin
On Mon, Jan 31, 2022 at 04:48:10PM +0100, Cornelia Huck wrote: > On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > > > On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: > >> On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > >> > >> > On Mon, Jan 31, 2022 at 10:16:43AM +0100,

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: >> On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: >> >> > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: >> >> On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote:

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Halil Pasic
On Mon, 31 Jan 2022 10:16:43 +0100 Cornelia Huck wrote: > On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: > > > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: > >> > >> On 1/30/2022 4:41 PM, Michael S. Tsirkin wrote: > >> > On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Michael S. Tsirkin
On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: > On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > > > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: > >> On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: > >> > >> > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: >> On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: >> >> > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: >> >> #define VIRTIO_PCI_CAP_MISC_CFG 10 >> >> >> >> and

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Michael S. Tsirkin
On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: > On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: > > > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: > >> > >> On 1/30/2022 4:41 PM, Michael S. Tsirkin wrote: > >> > On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: >> >> On 1/30/2022 4:41 PM, Michael S. Tsirkin wrote: >> > On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max Gurtovoy wrote: >> > > On 1/30/2022 11:40 AM, Michael S. Tsirkin wrote: >> >

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-30 Thread Michael S. Tsirkin
On Sun, Jan 30, 2022 at 08:23:30PM +0200, Max Gurtovoy wrote: > > On 1/30/2022 5:30 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: > > > On 1/30/2022 4:41 PM, Michael S. Tsirkin wrote: > > > > On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max Gurtovoy

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-30 Thread Michael S. Tsirkin
On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: > > On 1/30/2022 4:41 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max Gurtovoy wrote: > > > On 1/30/2022 11:40 AM, Michael S. Tsirkin wrote: > > > > On Sun, Jan 30, 2022 at 11:13:38AM +0200, Max Gurtovoy

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-30 Thread Michael S. Tsirkin
On Sun, Jan 30, 2022 at 11:56:30AM +0200, Max Gurtovoy wrote: > > On 1/30/2022 11:40 AM, Michael S. Tsirkin wrote: > > On Sun, Jan 30, 2022 at 11:13:38AM +0200, Max Gurtovoy wrote: > > > On 1/29/2022 5:53 AM, Jason Wang wrote: > > > > On Fri, Jan 28, 2022 at 11:52 PM Michael S. Tsirkin > > > >

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-30 Thread Michael S. Tsirkin
On Sun, Jan 30, 2022 at 01:21:41PM +0200, Max Gurtovoy wrote: > > On 1/28/2022 2:14 PM, Cornelia Huck wrote: > > On Mon, Jan 24 2022, Max Gurtovoy wrote: > > > > > In one of the many use cases a user wants to manipulate features and > > > configuration of the virtio devices regardless of the

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-30 Thread Michael S. Tsirkin
On Sun, Jan 30, 2022 at 11:13:38AM +0200, Max Gurtovoy wrote: > > On 1/29/2022 5:53 AM, Jason Wang wrote: > > On Fri, Jan 28, 2022 at 11:52 PM Michael S. Tsirkin wrote: > > > On Fri, Jan 28, 2022 at 04:49:34PM +0100, Cornelia Huck wrote: > > > > On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote:

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-30 Thread Michael S. Tsirkin
On Sat, Jan 29, 2022 at 11:53:06AM +0800, Jason Wang wrote: > On Fri, Jan 28, 2022 at 11:52 PM Michael S. Tsirkin wrote: > > > > On Fri, Jan 28, 2022 at 04:49:34PM +0100, Cornelia Huck wrote: > > > On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > > > > > > > On Fri, Jan 28, 2022 at 01:14:14PM

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Jason Wang
On Fri, Jan 28, 2022 at 11:52 PM Michael S. Tsirkin wrote: > > On Fri, Jan 28, 2022 at 04:49:34PM +0100, Cornelia Huck wrote: > > On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > > > > > On Fri, Jan 28, 2022 at 01:14:14PM +0100, Cornelia Huck wrote: > > >> On Mon, Jan 24 2022, Max Gurtovoy

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > On Fri, Jan 28, 2022 at 05:14:37PM +0100, Cornelia Huck wrote: >> Maybe pci gets a new entry in common_cfg, mmio gets a new register, and >> ccw gets a new command? > > That's fine. > >> (Although I'd prefer to be conservative with new >>

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Michael S. Tsirkin
On Fri, Jan 28, 2022 at 05:14:37PM +0100, Cornelia Huck wrote: > On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > > > On Fri, Jan 28, 2022 at 04:49:34PM +0100, Cornelia Huck wrote: > >> On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > >> > >> > On Fri, Jan 28, 2022 at 01:14:14PM +0100,

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > On Fri, Jan 28, 2022 at 04:49:34PM +0100, Cornelia Huck wrote: >> On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: >> >> > On Fri, Jan 28, 2022 at 01:14:14PM +0100, Cornelia Huck wrote: >> >> On Mon, Jan 24 2022, Max Gurtovoy wrote: >> >> >

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Michael S. Tsirkin
On Fri, Jan 28, 2022 at 04:49:34PM +0100, Cornelia Huck wrote: > On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > > > On Fri, Jan 28, 2022 at 01:14:14PM +0100, Cornelia Huck wrote: > >> On Mon, Jan 24 2022, Max Gurtovoy wrote: > >> > +\section{Admin Virtqueues}\label{sec:Basic Facilities of a

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > On Fri, Jan 28, 2022 at 01:14:14PM +0100, Cornelia Huck wrote: >> On Mon, Jan 24 2022, Max Gurtovoy wrote: >> > +\section{Admin Virtqueues}\label{sec:Basic Facilities of a Virtio Device >> > / Admin Virtqueues} >> > + >> > +Admin virtqueue is

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Michael S. Tsirkin
On Fri, Jan 28, 2022 at 01:14:14PM +0100, Cornelia Huck wrote: > On Mon, Jan 24 2022, Max Gurtovoy wrote: > > > In one of the many use cases a user wants to manipulate features and > > configuration of the virtio devices regardless of the device type > > (net/block/console). Some of this

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Mon, Jan 24 2022, Max Gurtovoy wrote: > In one of the many use cases a user wants to manipulate features and > configuration of the virtio devices regardless of the device type > (net/block/console). Some of this configuration is generic enough. i.e > Number of MSI-X vectors of a virtio PCI

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-26 Thread Jason Wang
On Thu, Jan 27, 2022 at 11:55 AM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, January 26, 2022 8:11 PM > > > > On Mon, Jan 24, 2022 at 11:39:15AM +0200, Max Gurtovoy wrote: > > > +Regardless of device offering VIRTIO_F_IN_ORDER, admin queue command > > > +buffers are

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2022 at 04:54:22PM +0200, Max Gurtovoy wrote: > > On 1/26/2022 4:40 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 24, 2022 at 11:39:15AM +0200, Max Gurtovoy wrote: > > > +Regardless of device offering VIRTIO_F_IN_ORDER, admin queue command > > > buffers > > > +are used by the

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-26 Thread Michael S. Tsirkin
On Mon, Jan 24, 2022 at 11:39:15AM +0200, Max Gurtovoy wrote: > +Regardless of device offering VIRTIO_F_IN_ORDER, admin queue command buffers > +are used by the device in out of order manner. Instead of special-casing AQ I'd like to see a generic capability addressing this need. For example, TX