> From: Heng Qi
> Sent: Friday, February 17, 2023 12:17 PM
> Yes, but there seems to be such a situation: when the device is reactivated,
> as
> the specification says, all parameters are set to 0 (use parameters as the
> default
> configuration on the device).
> When CTRL_COAL_SET and CTRL_
On Fri, Feb 17, 2023 at 04:12:34PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Friday, February 17, 2023 6:35 AM
>
> > > We mention the device reset case, but nothing about VQ reset.
> > >
> > > I feel that no matter how we handle this, we break something.
> > >
> > > Hav
> From: Michael S. Tsirkin
> Sent: Friday, February 17, 2023 6:35 AM
> > We mention the device reset case, but nothing about VQ reset.
> >
> > I feel that no matter how we handle this, we break something.
> >
> > Having default coalescing values may collide with "Upon reset, a
> > device MUST i
> From: Alvaro Karsz
> Sent: Friday, February 17, 2023 7:18 AM
> I wonder if some of that should be included in my patch.
> Most of that is not relevant before introducing the per vq command.
> So maybe I could just mention in the device conformance that:
> "Coalescing parameters MUST/SHOULD per
> From: Heng Qi
> Sent: Friday, February 17, 2023 12:24 AM
> I think there are two kinds of sequences:
> #Seq1:
> 1. vq is disabled (vq params are reset to max_packets = 0, max_usecs = 0) 2.
> VQ_SET command arrives with max_packets=10, max_usecs = 8 3. vq is enabled
> (vq params are max_packe
> Not good. I feel we must come up with spec that is backwards compatible.
> Hmm, maybe this is why Parav kept talking about modes.
> I did not realize at the time, sorry Parav.
>
> I still feel modes are not the best way to describe things so I propose this:
> - in addition to per vq parameters, d
On Fri, Feb 17, 2023 at 01:17:50PM +0200, Alvaro Karsz wrote:
> > > Yes, max_packets and max_usecs SHOULD be reset to 0.
> > > When the virtqueue is re-enabled, it means that notification conditions
> > > are met after each packet is sent/received.
> > >
> > > As described by Alvaro in "[PATCH v5]
> > Yes, max_packets and max_usecs SHOULD be reset to 0.
> > When the virtqueue is re-enabled, it means that notification conditions are
> > met after each packet is sent/received.
> >
> > As described by Alvaro in "[PATCH v5] virtio-net: Fix and update
> > VIRTIO_NET_F_NOTF_COAL feature":
> > "+
On Fri, Feb 17, 2023 at 01:24:04PM +0800, Heng Qi wrote:
> On Thu, Feb 16, 2023 at 11:17:48AM -0500, Michael S. Tsirkin wrote:
> > On Thu, Feb 16, 2023 at 10:43:01PM +0800, Heng Qi wrote:
> > > Currently coalescing parameters are grouped for all transmit and receive
> > > virtqueues. This patch sup
On Thu, Feb 16, 2023 at 10:43:01PM +0800, Heng Qi wrote:
> Currently coalescing parameters are grouped for all transmit and receive
> virtqueues. This patch supports setting or getting the parameters for a
> specified virtqueue, and a typical application of this function is netdim[1].
>
> When the
> From: Heng Qi
> Sent: Thursday, February 16, 2023 9:43 AM
[..]
> #define VIRTIO_NET_CTRL_NOTF_COAL 6
> - #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0
> + #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0
Unrelated change. Please remove this hunk.
> #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
> + #
On Thu, Feb 16, 2023 at 10:43:01PM +0800, Heng Qi wrote:
> Currently coalescing parameters are grouped for all transmit and receive
> virtqueues. This patch supports setting or getting the parameters for a
> specified virtqueue, and a typical application of this function is netdim[1].
>
> When the
12 matches
Mail list logo
