On Thu, Apr 19, 2018 at 07:14:39PM +0800, Tiwei Bie wrote:
> On Wed, Apr 18, 2018 at 07:34:06PM +0300, Michael S. Tsirkin wrote:
> > On Thu, Apr 12, 2018 at 11:12:32PM +0800, Tiwei Bie wrote:
> > > This patch introduces VHOST_USER_PROTOCOL_F_HOST_NOTIFIER.
> > > With this feature negotiated, vhost-
ongnu.org; virtio-dev@lists.oasis-open.org; Daly, Dan
> ; Tan, Jianfeng ; Wang, Zhihong
> ; Wang, Xiao W
> Subject: Re: [virtio-dev] RE: [PATCH v3 6/6] vhost-user: support registering
> external host notifiers
>
> On Thu, Apr 19, 2018 at 04:24:29PM +, Liang, Cunming wrote:
> >
&g
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Friday, April 20, 2018 1:01 AM
> To: Liang, Cunming
> Cc: Paolo Bonzini ; Bie, Tiwei ;
> jasow...@redhat.com; alex.william...@redhat.com; stefa...@redhat.com;
> qemu-de...@nongnu.org; virtio-dev@lists.oasis-
On Thu, Apr 19, 2018 at 07:35:57PM +0200, Paolo Bonzini wrote:
> On 19/04/2018 19:27, Michael S. Tsirkin wrote:
> >
> > That CONFIG_SMP here is clearly wrong but I don't really know what
> > to set it to. Also, we probably should switch virtio_wmb to dma_XX
> > barriers.
> >
> > That's actually e
On 19/04/2018 19:27, Michael S. Tsirkin wrote:
>
> That CONFIG_SMP here is clearly wrong but I don't really know what
> to set it to. Also, we probably should switch virtio_wmb to dma_XX
> barriers.
>
> That's actually easy. Will try to do.
Should it be dma_wmb() before updating the indices, and
On Thu, Apr 19, 2018 at 06:59:39PM +0200, Paolo Bonzini wrote:
> On 19/04/2018 18:52, Liang, Cunming wrote:
> >>> Oh you are right.
> >>>
> >>> So it's only needed for non-intel platforms or when packets are
> >>> in WC memory then. And I don't know whether dpdk ever puts
> >>> packets in WC memor
On Thu, Apr 19, 2018 at 04:52:20PM +, Liang, Cunming wrote:
>
>
> > -Original Message-
> > From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> > Sent: Thursday, April 19, 2018 11:52 PM
> > To: Michael S. Tsirkin ; Liang, Cunming
> >
> > Cc: Bie, Tiwei ; jasow...@redhat.com;
> > alex.w
On 19/04/2018 18:52, Liang, Cunming wrote:
>>> Oh you are right.
>>>
>>> So it's only needed for non-intel platforms or when packets are
>>> in WC memory then. And I don't know whether dpdk ever puts
>>> packets in WC memory.
>>>
>>> I guess we'll cross this bridge when we get to it.
>> Non-TSO a
Tiwei
> > ;
> > jasow...@redhat.com; alex.william...@redhat.com; stefa...@redhat.com;
> > qemu-de...@nongnu.org; virtio-dev@lists.oasis-open.org; Daly, Dan
> > ; Tan, Jianfeng ; Wang, Zhihong
> > ; Wang, Xiao W
> > Subject: Re: [virtio-dev] RE: [PATCH v3 6/6] vhost-user:
> -Original Message-
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Sent: Thursday, April 19, 2018 11:52 PM
> To: Michael S. Tsirkin ; Liang, Cunming
>
> Cc: Bie, Tiwei ; jasow...@redhat.com;
> alex.william...@redhat.com; stefa...@redhat.com; qemu-de...@nongnu.org;
> virtio-dev@lis
On Thu, Apr 19, 2018 at 06:07:07PM +0200, Paolo Bonzini wrote:
> On 19/04/2018 17:59, Michael S. Tsirkin wrote:
> > On Thu, Apr 19, 2018 at 05:51:51PM +0200, Paolo Bonzini wrote:
> >> On 19/04/2018 17:19, Michael S. Tsirkin wrote:
> - if we make it 1 when weak barriers are needed, the device a
On Thu, Apr 19, 2018 at 05:52:23PM +0200, Paolo Bonzini wrote:
> On 19/04/2018 17:42, Michael S. Tsirkin wrote:
> >> A compiler barrier is enough on strongly-ordered memory platform.
> >> As it doesn't re-order store, PCI device won't see a stale index
> >> value. But a weakly-ordered memory needs
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Thursday, April 19, 2018 11:43 PM
> To: Liang, Cunming
> Cc: Bie, Tiwei ; jasow...@redhat.com;
> alex.william...@redhat.com; pbonz...@redhat.com; stefa...@redhat.com;
> qemu-de...@nongnu.org; virtio-dev@list
.@nongnu.org; virtio-dev@lists.oasis-open.org; Daly, Dan
> ; Tan, Jianfeng ; Wang, Zhihong
> ; Wang, Xiao W
> Subject: Re: [virtio-dev] RE: [PATCH v3 6/6] vhost-user: support registering
> external host notifiers
>
> On Thu, Apr 19, 2018 at 03:02:40PM +0200, Paolo Bonzini wrote:
>
On 19/04/2018 17:59, Michael S. Tsirkin wrote:
> On Thu, Apr 19, 2018 at 05:51:51PM +0200, Paolo Bonzini wrote:
>> On 19/04/2018 17:19, Michael S. Tsirkin wrote:
- if we make it 1 when weak barriers are needed, the device also needs
to nack feature negotiation (not allow setting the FEATU
On Thu, Apr 19, 2018 at 05:51:51PM +0200, Paolo Bonzini wrote:
> On 19/04/2018 17:19, Michael S. Tsirkin wrote:
> >> - if we make it 1 when weak barriers are needed, the device also needs
> >> to nack feature negotiation (not allow setting the FEATURES_OK) if the
> >> bit is not set by the driver.
On 19/04/2018 17:42, Michael S. Tsirkin wrote:
>> A compiler barrier is enough on strongly-ordered memory platform.
>> As it doesn't re-order store, PCI device won't see a stale index
>> value. But a weakly-ordered memory needs sfence.
>
> Oh you are right.
>
> So it's only needed for non-intel p
On 19/04/2018 17:19, Michael S. Tsirkin wrote:
>> - if we make it 1 when weak barriers are needed, the device also needs
>> to nack feature negotiation (not allow setting the FEATURES_OK) if the
>> bit is not set by the driver.
>> However, that is not enough. Live
>> migration assumes that it is
On Thu, Apr 19, 2018 at 12:43:42PM +, Liang, Cunming wrote:
>
>
> > -Original Message-
> > From: Bie, Tiwei
> > Sent: Thursday, April 19, 2018 7:15 PM
> > To: Michael S. Tsirkin
> > Cc: jasow...@redhat.com; alex.william...@redhat.com; pbonz...@redhat.com;
> > stefa...@redhat.com; qem
On Thu, Apr 19, 2018 at 03:02:40PM +0200, Paolo Bonzini wrote:
> On 19/04/2018 14:43, Liang, Cunming wrote:
> >> 2. Memory barriers. Right now after updating the avail idx,
> >> virtio does smp_wmb() and then the MMIO write. Normal hardware
> >> drivers do wmb() which is an sfence. Can a PCI devic
On 19/04/2018 14:43, Liang, Cunming wrote:
>> 2. Memory barriers. Right now after updating the avail idx,
>> virtio does smp_wmb() and then the MMIO write. Normal hardware
>> drivers do wmb() which is an sfence. Can a PCI device read bypass
>> index write and see a stale index value?
>
> A compile
> -Original Message-
> From: Bie, Tiwei
> Sent: Thursday, April 19, 2018 7:15 PM
> To: Michael S. Tsirkin
> Cc: jasow...@redhat.com; alex.william...@redhat.com; pbonz...@redhat.com;
> stefa...@redhat.com; qemu-de...@nongnu.org; virtio-dev@lists.oasis-
> open.org; Liang, Cunming ; Daly, D
On Wed, Apr 18, 2018 at 07:34:06PM +0300, Michael S. Tsirkin wrote:
> On Thu, Apr 12, 2018 at 11:12:32PM +0800, Tiwei Bie wrote:
> > This patch introduces VHOST_USER_PROTOCOL_F_HOST_NOTIFIER.
> > With this feature negotiated, vhost-user backend can register
> > memory region based host notifiers. A
On Thu, Apr 12, 2018 at 11:12:32PM +0800, Tiwei Bie wrote:
> This patch introduces VHOST_USER_PROTOCOL_F_HOST_NOTIFIER.
> With this feature negotiated, vhost-user backend can register
> memory region based host notifiers. And it will allow the guest
> driver in the VM to notify the hardware acceler
24 matches
Mail list logo
