[virtio-dev] Re: [PATCH v6] virtio-net: support the virtqueue coalescing moderation

2023-02-23 Thread David Edmondson
On Wednesday, 2023-02-22 at 04:13:06 UTC, Parav Pandit wrote: >> From: Heng Qi >> Sent: Tuesday, February 21, 2023 10:22 PM > >> +\item[VIRTIO_NET_F_VQ_NOTF_COAL(52)] Device supports virtqueue >> notification coalescing. >> + > s/notification/notifications > should be plural as multiple notific

Re: [virtio-dev] RE: [PATCH v6] virtio-net: support the virtqueue coalescing moderation

2023-02-22 Thread Heng Qi
Hi, Parav. 在 2023/2/22 下午10:28, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Wednesday, February 22, 2023 1:29 AM MMIO device has vq_index register too. I am inclined to vq_index given current state of spec [mst@tuck virtio]$ git grep vq_index|wc -l 0 :) Grep for "virtqueue index". We

[virtio-dev] RE: [PATCH v6] virtio-net: support the virtqueue coalescing moderation

2023-02-22 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 22, 2023 1:29 AM > > MMIO device has vq_index register too. > > I am inclined to vq_index given current state of spec > > [mst@tuck virtio]$ git grep vq_index|wc -l > 0 > :) Grep for "virtqueue index". We need to change "virtqueue index

[virtio-dev] Re: [PATCH v6] virtio-net: support the virtqueue coalescing moderation

2023-02-21 Thread Michael S. Tsirkin
On Wed, Feb 22, 2023 at 04:13:06AM +, Parav Pandit wrote: > > > From: Heng Qi > > Sent: Tuesday, February 21, 2023 10:22 PM > > > +\item[VIRTIO_NET_F_VQ_NOTF_COAL(52)] Device supports virtqueue > > notification coalescing. > > + > s/notification/notifications > should be plural as multiple

[virtio-dev] RE: [PATCH v6] virtio-net: support the virtqueue coalescing moderation

2023-02-21 Thread Parav Pandit
> From: Heng Qi > Sent: Tuesday, February 21, 2023 10:22 PM > +\item[VIRTIO_NET_F_VQ_NOTF_COAL(52)] Device supports virtqueue > notification coalescing. > + s/notification/notifications should be plural as multiple notifications are coalesced like the below description of VIRTIO_NET_F_NOTF_CO