Re: [virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-07-27 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 06:55:44PM +0200, Halil Pasic wrote: > Sorry I did not have any time for this last days. And this > to make it worse this is a follow up to something that was > half a year ago. That means I have to re-familiarize myself > with the topic. > > If I don't get around to answer

[virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-07-26 Thread Longpeng (Mike)
On 2018/7/27 0:55, Halil Pasic wrote: > Sorry I did not have any time for this last days. And this > to make it worse this is a follow up to something that was > half a year ago. That means I have to re-familiarize myself > with the topic. > > If I don't get around to answer in couple of weeks

[virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-07-26 Thread Halil Pasic
Sorry I did not have any time for this last days. And this to make it worse this is a follow up to something that was half a year ago. That means I have to re-familiarize myself with the topic. If I don't get around to answer in couple of weeks, feel free to ping me. Since from what I've seen mo

[virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-07-20 Thread Longpeng (Mike)
On 2018/1/10 1:05, Halil Pasic wrote: > > > On 12/30/2017 10:35 AM, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto device provides >> the following crypto services: CIPHE

Re: [virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-06-19 Thread Michael S. Tsirkin
On Wed, Jan 10, 2018 at 01:53:09PM +0800, Longpeng (Mike) wrote: > Hi Halil, > > We are fixing the Intel BUG these days, so I will go through your comments > after > we're done. Thanks. All right - are you guys done with meltdown/spectre? I'd like us to start finally getting parts of this in the

Re: [virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-03-18 Thread Michael S. Tsirkin
On Fri, Mar 16, 2018 at 07:18:45PM +0100, Halil Pasic wrote: > > > On 03/16/2018 05:27 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 09, 2018 at 06:05:41PM +0100, Halil Pasic wrote: > >>> +\item[\field{max_cipher_key_len}] is the maximum length of cipher key > >>> supported by the device. > >> >

Re: [virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-03-16 Thread Halil Pasic
On 03/16/2018 05:27 PM, Michael S. Tsirkin wrote: > On Tue, Jan 09, 2018 at 06:05:41PM +0100, Halil Pasic wrote: >>> +\item[\field{max_cipher_key_len}] is the maximum length of cipher key >>> supported by the device. >> >> I can't find what happens if this limit isn't honored by the driver. More

Re: [virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-03-16 Thread Michael S. Tsirkin
On Tue, Jan 09, 2018 at 06:05:41PM +0100, Halil Pasic wrote: > > +\item[\field{max_cipher_key_len}] is the maximum length of cipher key > > supported by the device. > > I can't find what happens if this limit isn't honored by the driver. Moreover > reading it is only SHOULD. Is it undefined behav

[virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-01-09 Thread Longpeng (Mike)
Hi Halil, We are fixing the Intel BUG these days, so I will go through your comments after we're done. Thanks. -- Regards, Longpeng(Mike) On 2018/1/10 1:05, Halil Pasic wrote: > > > On 12/30/2017 10:35 AM, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual cr

[virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-01-09 Thread Michael S. Tsirkin
On Tue, Jan 09, 2018 at 06:05:41PM +0100, Halil Pasic wrote: > > +\drivernormative{\subsubsection}{Device configuration layout}{Device Types > > / Crypto Device / Device configuration layout} > > + > > +\begin{itemize*} > > +\item The driver MUST read the \field{status} from the bottom bit of > >

[virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-01-09 Thread Halil Pasic
On 12/30/2017 10:35 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. > > In this patch, CIPHER,