[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-26 Thread Alexander Duyck
On Wed, May 20, 2020 at 1:24 AM David Hildenbrand wrote: > > On 19.05.20 23:00, Alexander Duyck wrote: > > On Tue, May 19, 2020 at 9:09 AM David Hildenbrand wrote: [...] > > Let's think this through, what about this scenario: > > The device sets \field{free_page_hint_cmd_id}

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-20 Thread David Hildenbrand
On 19.05.20 23:00, Alexander Duyck wrote: > On Tue, May 19, 2020 at 9:09 AM David Hildenbrand wrote: >> I proposed that the driver MUST reinitialize the pages when reusing (which is what Linux does), so then this is true. Reuse implies initializing, implies modification. It's somewh

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread Alexander Duyck
On Tue, May 19, 2020 at 9:09 AM David Hildenbrand wrote: > > >> I proposed that the driver MUST reinitialize the pages when reusing > >> (which is what Linux does), so then this is true. Reuse implies > >> initializing, implies modification. It's somewhat simpler than what you > >> propose, leavin

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread David Hildenbrand
>> I proposed that the driver MUST reinitialize the pages when reusing >> (which is what Linux does), so then this is true. Reuse implies >> initializing, implies modification. It's somewhat simpler than what you >> propose, leaving the case open where the driver would reuse pages by >> only readin

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread Alexander Duyck
On Mon, May 18, 2020 at 11:54 PM Cornelia Huck wrote: > > On Mon, 18 May 2020 13:15:50 -0700 > Alexander Duyck wrote: > > > On Mon, May 18, 2020 at 6:18 AM David Hildenbrand wrote: > > > > > > On 15.05.20 19:33, Alexander Duyck wrote: > > > > > +\subsubsection{Free Page Hinting}\label{sec:Device

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread Alexander Duyck
On Tue, May 19, 2020 at 2:40 AM David Hildenbrand wrote: > > [...] > >>> +\begin{description} > >>> +\item[VIRTIO_BALLOON_CMD_ID_STOP (0)] Any command ID previously supplied > >>> by > >>> + the device is invalid. The driver should halt all hinting until a new > >>> + command ID is supplied. >

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread David Hildenbrand
[...] >>> +\begin{description} >>> +\item[VIRTIO_BALLOON_CMD_ID_STOP (0)] Any command ID previously supplied by >>> + the device is invalid. The driver should halt all hinting until a new >>> + command ID is supplied. >> >> Maybe "The driver should stop hinting free pages, but should not reuse >>

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-18 Thread Cornelia Huck
On Mon, 18 May 2020 13:15:50 -0700 Alexander Duyck wrote: > On Mon, May 18, 2020 at 6:18 AM David Hildenbrand wrote: > > > > On 15.05.20 19:33, Alexander Duyck wrote: > > > +\subsubsection{Free Page Hinting}\label{sec:Device Types / Memory > > > Balloon Device / Device Operation / Free Page

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-18 Thread Alexander Duyck
On Mon, May 18, 2020 at 6:18 AM David Hildenbrand wrote: > > On 15.05.20 19:33, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Free page hints allow the balloon driver to provide information on what > > pages are not currently in use so that we can avoid the cost of copying > > them in

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-18 Thread David Hildenbrand
>> + >> +\devicenormative{\paragraph}{Free Page Hinting}{Device Types / Memory >> Balloon Device / Device Operation / Free Page Hinting} >> + >> +Normative statements in this section apply if the >> +VIRTIO_BALLOON_F_FREE_PAGE_HINT feature has been negotiated. >> + >> +The device MUST set \field

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-18 Thread David Hildenbrand
On 15.05.20 19:33, Alexander Duyck wrote: > From: Alexander Duyck > > Free page hints allow the balloon driver to provide information on what > pages are not currently in use so that we can avoid the cost of copying > them in migration scenarios. Add a feature description for free page hints > de