RE: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-07-03 Thread Parav Pandit
Hi Xuan, > From: Xuan Zhuo > Sent: Sunday, July 2, 2023 11:22 PM > I try to describe the requirement as a common requirement. > > @Parav do you think this is a requirement in your devices? > > The core point here is that our virtio-net device is created by customers on > the > management

Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-07-03 Thread Jason Wang
On Mon, Jul 3, 2023 at 11:53 AM Xuan Zhuo wrote: > > On Wed, 28 Jun 2023 11:41:02 -0400, "Michael S. Tsirkin" > wrote: > > On Wed, Jun 28, 2023 at 10:21:04AM +0800, Xuan Zhuo wrote: > > > On Tue, 27 Jun 2023 12:02:41 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Jun 27, 2023 at

Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-07-02 Thread Xuan Zhuo
On Wed, 28 Jun 2023 11:41:02 -0400, "Michael S. Tsirkin" wrote: > On Wed, Jun 28, 2023 at 10:21:04AM +0800, Xuan Zhuo wrote: > > On Tue, 27 Jun 2023 12:02:41 -0400, "Michael S. Tsirkin" > > wrote: > > > On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote: > > > > So, this is how I

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Jason Wang
On Wed, Jun 28, 2023 at 11:55 PM Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2023 at 02:06:32PM +0800, Xuan Zhuo wrote: > > On Wed, 28 Jun 2023 10:49:45 +0800, Jason Wang wrote: > > > On Tue, Jun 27, 2023 at 6:54 PM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 27 Jun 2023 17:00:06 +0800,

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 02:06:32PM +0800, Xuan Zhuo wrote: > On Wed, 28 Jun 2023 10:49:45 +0800, Jason Wang wrote: > > On Tue, Jun 27, 2023 at 6:54 PM Xuan Zhuo > > wrote: > > > > > > On Tue, 27 Jun 2023 17:00:06 +0800, Jason Wang > > > wrote: > > > > On Tue, Jun 27, 2023 at 4:28 PM Xuan Zhuo

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2023 at 10:21:04AM +0800, Xuan Zhuo wrote: > On Tue, 27 Jun 2023 12:02:41 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote: > > > So, this is how I understand the process of creating vf: > > > > > > 1. Create a PCI VF, at this

[virtio-dev] RE: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-28 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, June 27, 2023 10:21 PM > > I can see this making sense as a feature bit that says VFs are not > > initialized by default and must first be setup through an admin command. > > This will likely need to be a feature bit because it's changing > > behaviour

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Jason Wang
On Tue, Jun 27, 2023 at 6:54 PM Xuan Zhuo wrote: > > On Tue, 27 Jun 2023 17:00:06 +0800, Jason Wang wrote: > > On Tue, Jun 27, 2023 at 4:28 PM Xuan Zhuo > > wrote: > > > > > > > > > Thanks Parav for pointing it out. We may have some gaps on the case. > > > > > > Let me introduce our case,

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Xuan Zhuo
On Tue, 27 Jun 2023 12:02:41 -0400, "Michael S. Tsirkin" wrote: > On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote: > > So, this is how I understand the process of creating vf: > > > > 1. Create a PCI VF, at this time there may be no backend virtio device, or > > there > > is only

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Michael S. Tsirkin
On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote: > So, this is how I understand the process of creating vf: > > 1. Create a PCI VF, at this time there may be no backend virtio device, or > there > is only a default backend. It does not fully meet our expectations. > 2. Create

[virtio-dev] RE: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, June 27, 2023 4:23 AM > > Thanks Parav for pointing it out. We may have some gaps on the case. > > Let me introduce our case, which I think it is simple and should be easy to > understand. > > First, the user (customer) purchased a bare metal machine. > >

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Zhu, Lingshan
On 6/27/2023 4:14 PM, Xuan Zhuo wrote: On Tue, 27 Jun 2023 10:57:13 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 6:50 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 17:56:01 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 5:16 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 16:59:48 +0800, "Zhu,

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Jason Wang
On Tue, Jun 27, 2023 at 4:28 PM Xuan Zhuo wrote: > > > Thanks Parav for pointing it out. We may have some gaps on the case. > > Let me introduce our case, which I think it is simple and should be easy to > understand. > > First, the user (customer) purchased a bare metal machine. > > ## Bare

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Jason Wang
On Mon, Jun 26, 2023 at 2:22 PM Xuan Zhuo wrote: > > The VFs of the SR-IOV are created by the user inside the guest OS, so the > virtio > devices don't know about these VFs. Because each VF may be assigned a > different role > by the user, the virtio device can not choose one VF to bind random.

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Zhu, Lingshan
On 6/26/2023 6:50 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 17:56:01 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 5:16 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 16:59:48 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 4:09 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 15:57:33 +0800, "Zhu,

[virtio-dev] RE: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 26, 2023 8:35 AM > > Yet to catch up on the thread, so likely I am missing something. > > > > The flow is for one OS (Linux) is: > > 1. user enable SR-IOV on the PF device in a host, which creates SR-IOV VFs > > in > the device. > > (num_vfs

[virtio-dev] RE: RE: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Monday, June 26, 2023 8:33 AM [..] > > The flow is for one OS (Linux) is: > > 1. user enable SR-IOV on the PF device in a host, which creates SR-IOV VFs > > in > the device. > > (num_vfs and vf enable bit in the PCI capability) > > > > 2. VFs are created at the PCI

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Michael S. Tsirkin
On Mon, Jun 26, 2023 at 12:19:04PM +, Parav Pandit wrote: > > > > From: Xuan Zhuo > > Sent: Monday, June 26, 2023 6:51 AM > > > > On Mon, 26 Jun 2023 17:56:01 +0800, "Zhu, Lingshan" > > wrote: > > > > > > > > > On 6/26/2023 5:16 PM, Xuan Zhuo wrote: > > > > On Mon, 26 Jun 2023 16:59:48

[virtio-dev] RE: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Monday, June 26, 2023 6:51 AM > > On Mon, 26 Jun 2023 17:56:01 +0800, "Zhu, Lingshan" > wrote: > > > > > > On 6/26/2023 5:16 PM, Xuan Zhuo wrote: > > > On Mon, 26 Jun 2023 16:59:48 +0800, "Zhu, Lingshan" > wrote: > > >> > > >> On 6/26/2023 4:09 PM, Xuan Zhuo wrote:

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Zhu, Lingshan
On 6/26/2023 5:16 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 16:59:48 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 4:09 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 15:57:33 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 3:08 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 14:43:17 +0800, "Zhu,

Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Zhu, Lingshan
On 6/26/2023 4:09 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 15:57:33 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 3:08 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 14:43:17 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 2:22 PM, Xuan Zhuo wrote: The VFs of the SR-IOV are created by the user

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Zhu, Lingshan
On 6/26/2023 3:08 PM, Xuan Zhuo wrote: On Mon, 26 Jun 2023 14:43:17 +0800, "Zhu, Lingshan" wrote: On 6/26/2023 2:22 PM, Xuan Zhuo wrote: The VFs of the SR-IOV are created by the user inside the guest OS, so the virtio devices don't know about these VFs. Because each VF may be assigned a

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-26 Thread Zhu, Lingshan
On 6/26/2023 2:22 PM, Xuan Zhuo wrote: The VFs of the SR-IOV are created by the user inside the guest OS, so the virtio devices don't know about these VFs. Because each VF may be assigned a different role by the user, the virtio device can not choose one VF to bind random. So only the user