[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 10:12:35AM +0200, Cornelia Huck wrote: > [Also, I notice that the discussion seems to get bogged down in tiny > details, fundamental statements, or a mixture of both. It might > sometimes be helpful to just step back, re-read the original proposal, > and only then answer. Ot

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-07 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Thursday, July 6, 2023 4:42 PM > > [..] >> > Can we please avoid this over engineering? >> > Interface has the doors open for driver to make wise decision depending on >> its environment. >> >> what if driver can acce

[virtio-dev] RE: [virtio-comment] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, July 6, 2023 3:59 PM > > Hardwaring BAR0 is in BAR area of the VF. > > But virtio pci capabilities without this can still report bar 0 and virtio > capabilities. > > How do they do this? > Device must not do it, but a broken device can report pci c

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 07:07:42PM +, Parav Pandit wrote: > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 3:01 PM > > > > +\begin{lstlisting} > > > +struct virtio_pci_legacy_notify_region { > > > +u8 owner; /*

[virtio-dev] RE: [virtio-comment] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Michael S. Tsirkin > Sent: Thursday, July 6, 2023 3:01 PM > > +\begin{lstlisting} > > +struct virtio_pci_legacy_notify_region { > > +u8 owner; /* When set to 1, notification region is of the > > +owner device */ > > I pr