[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-04-07 Thread Michael S. Tsirkin
On Thu, Apr 07, 2022 at 04:28:03PM +0200, Cornelia Huck wrote: > [sorry about resurrecting an undead thread; I'm trying to collect some > editorial changes] > > On Wed, Jan 26 2022, Jean-Philippe Brucker wrote: > > > On Mon, Jan 24, 2022 at 04:42:35PM -0500, Michael S. Tsirkin wrote: > >> So fro

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-04-07 Thread Cornelia Huck
[sorry about resurrecting an undead thread; I'm trying to collect some editorial changes] On Wed, Jan 26 2022, Jean-Philippe Brucker wrote: > On Mon, Jan 24, 2022 at 04:42:35PM -0500, Michael S. Tsirkin wrote: >> So from that point of view, we are actually relaxing the requirements, >> and yes w

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-26 Thread Halil Pasic
On Mon, 24 Jan 2022 16:42:35 -0500 "Michael S. Tsirkin" wrote: > On Mon, Jan 24, 2022 at 05:40:52PM +0100, Halil Pasic wrote: [..] > > > > So the drivers currently out there, that do the early config read to > > validate if they support some of the features don't fulfill the new > > driver requi

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-26 Thread Halil Pasic
On Tue, 25 Jan 2022 16:22:05 +0100 Cornelia Huck wrote: > On Mon, Jan 24 2022, Halil Pasic wrote: > > > On Fri, 21 Jan 2022 17:05:07 +0100 > > Cornelia Huck wrote: > > > >> On Fri, Jan 21 2022, Halil Pasic wrote: > >> > >> > On Thu, 20 Jan 2022 14:05:37 +0100 > >> > Cornelia Huck wrote:

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-26 Thread Jean-Philippe Brucker
On Mon, Jan 24, 2022 at 04:42:35PM -0500, Michael S. Tsirkin wrote: > So from that point of view, we are actually relaxing the requirements, > and yes we'll need to carefully go over each instance of > "offered". > I thought I did, but now I did a quick grep again and I found instances > in virtio-

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2022 at 03:57:30PM +0100, Cornelia Huck wrote: > On Mon, Jan 24 2022, "Michael S. Tsirkin" wrote: > > > It's true. However, that's a generic rule and specific devices > > can differ. and if you look at specific instances, you will > > see that they typically require that the featu

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, Halil Pasic wrote: > On Fri, 21 Jan 2022 17:05:07 +0100 > Cornelia Huck wrote: > >> On Fri, Jan 21 2022, Halil Pasic wrote: >> >> > On Thu, 20 Jan 2022 14:05:37 +0100 >> > Cornelia Huck wrote: >> > >> >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: >> >> >> >> >

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, "Michael S. Tsirkin" wrote: > It's true. However, that's a generic rule and specific devices > can differ. and if you look at specific instances, you will > see that they typically require that the feature is negotiated. > For example: > > \item If the VIRTIO_BLK_F_BLK_SIZE f

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-24 Thread Michael S. Tsirkin
On Mon, Jan 24, 2022 at 05:40:52PM +0100, Halil Pasic wrote: > On Fri, 21 Jan 2022 17:05:07 +0100 > Cornelia Huck wrote: > > > On Fri, Jan 21 2022, Halil Pasic wrote: > > > > > On Thu, 20 Jan 2022 14:05:37 +0100 > > > Cornelia Huck wrote: > > > > > >> On Wed, Jan 19 2022, "Michael S. Tsirkin

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-24 Thread Halil Pasic
On Fri, 21 Jan 2022 17:05:07 +0100 Cornelia Huck wrote: > On Fri, Jan 21 2022, Halil Pasic wrote: > > > On Thu, 20 Jan 2022 14:05:37 +0100 > > Cornelia Huck wrote: > > > >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > >> > >> > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-21 Thread Cornelia Huck
On Fri, Jan 21 2022, Halil Pasic wrote: > On Thu, 20 Jan 2022 14:05:37 +0100 > Cornelia Huck wrote: > >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: >> My take would be: >> - If the driver wrote a set of feature bits

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-20 Thread Halil Pasic
On Thu, 20 Jan 2022 14:05:37 +0100 Cornelia Huck wrote: > On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > > > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: > >> On Fri, 14 Jan 2022 17:50:51 -0500 > >> "Michael S. Tsirkin" wrote: > >> > Subject: virtio: clarify feature neg

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2022 at 02:05:37PM +0100, Cornelia Huck wrote: > Do we know anything about the state of e.g. hardware implementations? One I'm aware of is LE and just does not work on BE platforms in legacy mode. But generally hardware has a standard MTU so does not need it ... -- MST

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-20 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: >> On Fri, 14 Jan 2022 17:50:51 -0500 >> "Michael S. Tsirkin" wrote: >> > Subject: virtio: clarify feature negotiation >> > @@ -500,8 +500,13 @@ \section{Device Initialization}\label{s