Re: [virtio-dev] Re: queue_reset register polarity to improve

2022-04-25 Thread Michael S. Tsirkin
On Mon, Apr 25, 2022 at 02:56:39PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, April 25, 2022 9:43 AM > > > > Question is what exactly is the advantage of making changes now. If we are > > trying to save bits then maybe an alternative that uses queue enable

Re: [virtio-dev] Re: queue_reset register polarity to improve

2022-04-25 Thread Michael S. Tsirkin
On Sun, Apr 24, 2022 at 03:01:04PM +0800, Jason Wang wrote: > On Sun, Apr 24, 2022 at 2:47 PM Michael S. Tsirkin wrote: > > > > On Sun, Apr 24, 2022 at 12:49:19AM +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little weird definition > > > that we

Re: [virtio-dev] Re: queue_reset register polarity to improve

2022-04-25 Thread Michael S. Tsirkin
On Mon, Apr 25, 2022 at 12:01:21PM +, Parav Pandit wrote: > > > From: Cornelia Huck > > Sent: Monday, April 25, 2022 7:42 AM > > > > > > > Well it's been merged since November. Probably too late unless you can > > > convince the TC that the current feature should be abandoned and the > > >

[virtio-dev] Re: queue_reset register polarity to improve

2022-04-25 Thread Michael S. Tsirkin
On Mon, Apr 25, 2022 at 10:06:04AM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Sunday, April 24, 2022 2:47 AM > > > > On Sun, Apr 24, 2022 at 12:49:19AM +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little weird definition

Re: [virtio-dev] Re: queue_reset register polarity to improve

2022-04-25 Thread Cornelia Huck
On Sun, Apr 24 2022, "Michael S. Tsirkin" wrote: > On Sun, Apr 24, 2022 at 12:49:19AM +, Parav Pandit wrote: >> Hi, >> >> A recently defined queue_reset register has a little weird definition that >> we should improve. >> When driver initiate queue reset, it writes queue_reset = 1. >> When

Re: [virtio-dev] Re: queue_reset register polarity to improve

2022-04-24 Thread Jason Wang
On Sun, Apr 24, 2022 at 2:47 PM Michael S. Tsirkin wrote: > > On Sun, Apr 24, 2022 at 12:49:19AM +, Parav Pandit wrote: > > Hi, > > > > A recently defined queue_reset register has a little weird definition that > > we should improve. > > When driver initiate queue reset, it writes

[virtio-dev] Re: queue_reset register polarity to improve

2022-04-24 Thread Michael S. Tsirkin
On Sun, Apr 24, 2022 at 12:49:19AM +, Parav Pandit wrote: > Hi, > > A recently defined queue_reset register has a little weird definition that we > should improve. > When driver initiate queue reset, it writes queue_reset = 1. > When device is busy resetting the queue, on this driver